seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=430016ca22f990a7f402e3c0040057d0bf5428a4
commit 430016ca22f990a7f402e3c0040057d0bf5428a4 Author: Daniel Juyung Seo <seojuyu...@gmail.com> Date: Tue Dec 16 23:54:13 2014 +0900 genlist: Fix dereference before null check. This fixes coverity CID 1258636. No backport needed. --- src/lib/elm_genlist.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lib/elm_genlist.c b/src/lib/elm_genlist.c index f817549..df12c5f 100644 --- a/src/lib/elm_genlist.c +++ b/src/lib/elm_genlist.c @@ -2791,11 +2791,11 @@ _item_swap_cb(void *data, double pos) static void _swap_items(Elm_Gen_Item *it1, Elm_Gen_Item *it2, Elm_Focus_Direction dir) { + if (!it1 || !it2) return; + ELM_GENLIST_DATA_GET_FROM_ITEM(it1, sd); Evas_Coord xx1, yy1, xx2, yy2; - if (!it1 || !it2) return; - sd->reorder.running = EINA_TRUE; sd->reorder.dir = dir; sd->reorder.it1 = it1; --