hermet pushed a commit to branch master.

http://git.enlightenment.org/core/elementary.git/commit/?id=945b6c45ab5d56888935da80efd49c1aaff65a45

commit 945b6c45ab5d56888935da80efd49c1aaff65a45
Author: Jaeun Choi <jaeun12.c...@samsung.com>
Date:   Thu Apr 17 11:51:47 2014 +0900

    spinner: fixed odd behavior of the spinner
    
    Summary:
    when multiple key down is coming while increase/decrease the spinner values,
    the speed acceleration will be reset by the new key down.
    
    Instead, it stops the increase/decrease the spinner values behavior.
    
    @fix
    
    Test Plan: None
    
    Reviewers: Hermet, raster
    
    CC: seoz
    
    Differential Revision: https://phab.enlightenment.org/D749
---
 src/lib/elm_spinner.c | 14 ++++----------
 1 file changed, 4 insertions(+), 10 deletions(-)

diff --git a/src/lib/elm_spinner.c b/src/lib/elm_spinner.c
index a37fd59..b9ce420 100644
--- a/src/lib/elm_spinner.c
+++ b/src/lib/elm_spinner.c
@@ -487,20 +487,14 @@ _elm_spinner_elm_widget_event(Eo *obj, Elm_Spinner_Data 
*sd EINA_UNUSED, Evas_Ob
                  (!strcmp(ev->key, "KP_Enter")) ||
                  (!strcmp(ev->key, "space")))
           {
-             _entry_toggle_cb(NULL, obj, NULL, NULL);
+             if (sd->spin_timer) _spin_stop(obj);
+             else _entry_toggle_cb(NULL, obj, NULL, NULL);
           }
+        else if (sd->spin_timer) _spin_stop(obj);
      }
    else if (type == EVAS_CALLBACK_KEY_UP)
      {
-        if (!strcmp(ev->key, "Right") ||
-            ((!strcmp(ev->key, "KP_Right")) && (!ev->string)) ||
-            !strcmp(ev->key, "Up") ||
-            ((!strcmp(ev->key, "KP_Up")) && (!ev->string)) ||
-            !strcmp(ev->key, "Left") ||
-            ((!strcmp(ev->key, "KP_Left")) && (!ev->string)) ||
-            !strcmp(ev->key, "Down") ||
-            ((!strcmp(ev->key, "KP_Down")) && (!ev->string)))
-          _spin_stop(obj);
+        if (sd->spin_timer) _spin_stop(obj);
         else return EINA_FALSE;
 
         goto success;

-- 


Reply via email to