Re: [E-devel] E SVN: discomfitor IN trunk/efl: . src/lib/eina

2013-02-01 Thread Michael Blumenkrantz
yep On Fri, Feb 1, 2013 at 12:53 PM, Rafael Antognolli wrote: > On Fri, Feb 1, 2013 at 9:12 AM, Enlightenment SVN > wrote: > > + * This function is identical to eina_stringshare_replace() except that > it calls > > + * eina_stringshare_ref() instead of eina_stringshare_del() > > Typo here? Maybe

Re: [E-devel] E SVN: discomfitor IN trunk/efl: . src/lib/eina

2013-02-01 Thread Rafael Antognolli
On Fri, Feb 1, 2013 at 9:12 AM, Enlightenment SVN wrote: > + * This function is identical to eina_stringshare_replace() except that it > calls > + * eina_stringshare_ref() instead of eina_stringshare_del() Typo here? Maybe it should be s/eina_stringshare_del/eina_stringshare_add/ ? -- Rafael An

Re: [E-devel] E SVN: discomfitor IN trunk/efl: . src/lib/eina

2013-02-01 Thread Leif Middelschulte
Am Freitag, 1. Februar 2013 um 12:19 schrieb Michael Blumenkrantz: > when a function name is already over 24 characters, adding another 12 is > just not a great idea. > > Rather have a meaningful name and use autocomplete in your editor of choice! -- Leif > > On Fri, Feb 1, 2013 at 11:14 AM, G

Re: [E-devel] E SVN: discomfitor IN trunk/efl: . src/lib/eina

2013-02-01 Thread Michael Blumenkrantz
when a function name is already over 24 characters, adding another 12 is just not a great idea. On Fri, Feb 1, 2013 at 11:14 AM, Gustavo Sverzut Barbieri < barbi...@profusion.mobi> wrote: > Awful name! Maybe replace_stringshared()? > > On Friday, February 1, 2013, Enlightenment SVN wrote: > > > L

Re: [E-devel] E SVN: discomfitor IN trunk/efl: . src/lib/eina

2013-02-01 Thread Gustavo Sverzut Barbieri
Awful name! Maybe replace_stringshared()? On Friday, February 1, 2013, Enlightenment SVN wrote: > Log: > add eina_stringshare_refplace(): same as replace(), but calls ref instead > of add > also fixed a small doc error > > > Author: discomfitor > Date: 2013-02-01 03:12:33 -0800 (F