Re: [E-devel] git notes

2015-10-14 Thread Tom Hacohen
I don't know how phab deals (or apparently doesn't) with note commits. I haven't done anything special to block phab from accessing it. If you can find info on how to enable it on phab, I'll happily do it. -- Tom. On 14/10/15 19:11, Mike Blumenkrantz wrote: > Would it be possible to have phabri

Re: [E-devel] git notes

2015-10-14 Thread Mike Blumenkrantz
Would it be possible to have phabricator still parse note commits? As an example, I added a note to c4117cdae4ad0f03d3b4d4683ad93511423f65eb in efl to reference T1636, and it would be helpful if this could be pulled in. On Mon, Oct 12, 2015 at 9:51 AM Tom Hacohen wrote: > Fixed, thanks. > > Let

Re: [E-devel] git notes

2015-10-12 Thread Tom Hacohen
Fixed, thanks. Let me know if you see any other issues. -- Tom. On 10/10/15 17:28, Mike Blumenkrantz wrote: > No, the message that I posted was from git itself. Things seemed to > function as expected, so I'm not very concerned. > > Thanks for fixing this. > > On Sat, Oct 10, 2015 at 12:27 PM To

Re: [E-devel] git notes

2015-10-10 Thread Mike Blumenkrantz
No, the message that I posted was from git itself. Things seemed to function as expected, so I'm not very concerned. Thanks for fixing this. On Sat, Oct 10, 2015 at 12:27 PM Tom Hacohen wrote: > Ahhh, it's an email. Yeah, it's just spam. I'll have to look into that. Not > useful to have. > > --

Re: [E-devel] git notes

2015-10-10 Thread Tom Hacohen
Ahhh, it's an email. Yeah, it's just spam. I'll have to look into that. Not useful to have. -- Tom. On Sat, Oct 10, 2015 at 5:23 PM, Mike Blumenkrantz < [email protected]> wrote: > I've never seen them before. > > I'm not sure it's worthwhile to have mails for note commits. They hav

Re: [E-devel] git notes

2015-10-10 Thread Mike Blumenkrantz
I've never seen them before. I'm not sure it's worthwhile to have mails for note commits. They have no context attached, so it seems like it would just be spam in the majority of cases. On Sat, Oct 10, 2015 at 4:51 AM Tom Hacohen wrote: > Are those messages normal? Or is there something for me

Re: [E-devel] git notes

2015-10-10 Thread Tom Hacohen
Are those messages normal? Or is there something for me to fix? -- Tom On Fri, Oct 9, 2015 at 6:01 PM, Mike Blumenkrantz < [email protected]> wrote: > remote: *** Push-update of strange reference 'refs/notes/commits' > remote: *** - incomplete email generated. > > Seems to work. >

Re: [E-devel] git notes

2015-10-09 Thread Mike Blumenkrantz
remote: *** Push-update of strange reference 'refs/notes/commits' remote: *** - incomplete email generated. Seems to work. On Fri, Oct 9, 2015 at 7:18 AM Tom Hacohen wrote: > Gotcha. > > Enabled. Please test and let me know if works. > > On 05/10/15 23:53, Mike Blumenkrantz wrote: > > If I fin

Re: [E-devel] git notes

2015-10-09 Thread Tom Hacohen
Gotcha. Enabled. Please test and let me know if works. On 05/10/15 23:53, Mike Blumenkrantz wrote: > If I find a regression and blame it back to the original commit, I would > like to make a note on some of the blame-able commits to save time in the > future when I would potentially be blaming th

Re: [E-devel] git notes

2015-10-05 Thread Mike Blumenkrantz
If I find a regression and blame it back to the original commit, I would like to make a note on some of the blame-able commits to save time in the future when I would potentially be blaming the same line of code. On Mon, Oct 5, 2015 at 6:37 PM Tom Hacohen wrote: > Sure, we can allow that. I'll d

Re: [E-devel] git notes

2015-10-05 Thread Tom Hacohen
Sure, we can allow that. I'll do that once I'm back from LinuxCon. Out of interest, what's your usecase? -- Tom. On 04/10/15 18:16, Mike Blumenkrantz wrote: > I recently tried to add notes to a commit, but when pushing the notes I > seem to be rejected by one of the commit hooks on the server. >