[E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Tom Hacohen
Hey all, Wall and Wextra are great compilation flags they help finding a lot of coding mistakes. Warnings about unused parameters is a bit annoying in a library that has a lot of callbacks, so disabling that makes sense, but other than that, all warnings are welcomed. What do you guys say about m

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Christopher Michael
Personally I like the idea. It would certainly help spot errors in code and could help enforce cleaner code from others. WRT unused paramaters tho, I would lean toward the side of not disabling those tho because there are some situations where those warnings are legitimate. dh On 08/18/2010 10

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Cedric BAIL
On Wed, Aug 18, 2010 at 4:35 PM, Christopher Michael wrote: > Personally I like the idea. It would certainly help spot errors in code > and could help enforce cleaner code from others. WRT unused paramaters > tho, I would lean toward the side of not disabling those tho because > there are some sit

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Tom Hacohen
And now to list as well :P Those warnings are legitimate and helpful, but for some reason people find adding __UNUSED__ to parameters annoying so I decided to give this one up in order to get the general acceptance about the rest :P When it comes to warnings (and parties) I really believe in "the

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Tom Hacohen wrote: > And now to list as well :P > > Those warnings are legitimate and helpful, but for some reason people > find adding __UNUSED__ to parameters annoying so I decided to give this > one up in order to get the general acceptance about the rest :P > > When it c

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Matthew Robbetts
Hi all, As of a few days ago (I'm not sure which revision), the efl overlay won't complete a build. Most packages build fine, but when it gets to building x11-wm/enlightenment the configure stage fails at the point of: >

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Matthew Robbetts wrote: > Those new errors are fixed now, but it has just reverted to the original > breakage. I don't suppose anyone knows Gentoo well enough to event hint > at something I could check into? It's driving me nuts. > > I'm having to use KDE while enlightenment

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Matthew Robbetts
On 08/18/10 19:34, Vincent Torri wrote: > > > On Wed, 18 Aug 2010, Matthew Robbetts wrote: > >> Those new errors are fixed now, but it has just reverted to the original >> breakage. I don't suppose anyone knows Gentoo well enough to event hint >> at something I could check into? It's driving me nu

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Matthew Robbetts wrote: > On 08/18/10 19:34, Vincent Torri wrote: >> >> >> On Wed, 18 Aug 2010, Matthew Robbetts wrote: >> >>> Those new errors are fixed now, but it has just reverted to the original >>> breakage. I don't suppose anyone knows Gentoo well enough to event hint

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Matthew Robbetts
On 08/18/10 20:04, Vincent Torri wrote: > > > On Wed, 18 Aug 2010, Matthew Robbetts wrote: > >> On 08/18/10 19:34, Vincent Torri wrote: >>> >>> >>> On Wed, 18 Aug 2010, Matthew Robbetts wrote: >>> Those new errors are fixed now, but it has just reverted to the original breakage. I d

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Matthew Robbetts wrote: > On 08/18/10 20:04, Vincent Torri wrote: >> >> >> On Wed, 18 Aug 2010, Matthew Robbetts wrote: >> >>> On 08/18/10 19:34, Vincent Torri wrote: On Wed, 18 Aug 2010, Matthew Robbetts wrote: > Those new errors are fixed now, but i

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Tom Hacohen
On Wed, Aug 18, 2010 at 7:06 PM, Vincent Torri wrote: > See how I did in eina's configure.ac. It's just a macro to add. > > This? m4_ifdef([v_mic], [ EFL_COMPILER_FLAG([-Wall]) EFL_COMPILER_FLAG([-W]) ]) What does it do exactly? (I'm not an m4 expert). -- Tom. --

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Tom Hacohen wrote: > On Wed, Aug 18, 2010 at 7:06 PM, Vincent Torri wrote: > >> See how I did in eina's configure.ac. It's just a macro to add. >> >> > This? > > m4_ifdef([v_mic], > [ >EFL_COMPILER_FLAG([-Wall]) >EFL_COMPILER_FLAG([-W]) > ]) EFL_COMPILER_FLAG([

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Tom Hacohen
On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri wrote: > EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS > > m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version > of eina is defined. I did that in order to add these flags only when in > "developper mode" (not in release mo

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Tom Hacohen wrote: > On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri wrote: > >> EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS >> >> m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version >> of eina is defined. I did that in order to add these flags o

[E-devel] e_dbus: api change (better wrapping)

2010-08-18 Thread Vincent Torri
Hey, Here is a patch that tries to improve the e_dbus wrapper around dbus. It is not perfect as there is still a problem: dbus declares DBusConnection and e_dbus declares E_DBus_Connection. I'm a bit stick on how I can rename DBusConnection. So if someone has an idea... VincentIndex: e_dbu

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread Albin Tonnerre
> On Wed, 18 Aug 2010, Tom Hacohen wrote: > > > On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri wrote: > > > >> EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS > >> > >> m4_ifdef([v_mic] ***) checks if v_mic is used (that is if the micro version > >> of eina is defined. I did that in order to add

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Matthew Robbetts
On 08/18/10 20:20, Vincent Torri wrote: > > > On Wed, 18 Aug 2010, Matthew Robbetts wrote: > >> On 08/18/10 20:04, Vincent Torri wrote: >>> >>> >>> On Wed, 18 Aug 2010, Matthew Robbetts wrote: >>> On 08/18/10 19:34, Vincent Torri wrote: > > > On Wed, 18 Aug 2010, Matthew Robbetts

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Vincent Torri
On Wed, 18 Aug 2010, Matthew Robbetts wrote: >>> >>> Hope this is the right one: >>> http://pastebin.com/BwaR9jH4 >> >> add >> >> PKG_PROG_PKG_CONFIG >> >> line 292 of the configure.ac file, that is, just before : >> >> if test "x$e_cv_want_device_udev" = "xyes";then >> >> Vincent > > That sound

Re: [E-devel] Using -Wall -Wextra -Wno-unused-parameter

2010-08-18 Thread The Rasterman
On Wed, 18 Aug 2010 21:42:12 +0200 Albin Tonnerre said: > > On Wed, 18 Aug 2010, Tom Hacohen wrote: > > > > > On Wed, Aug 18, 2010 at 10:27 PM, Vincent Torri > > > wrote: > > > > > >> EFL_COMPILER_FLAG([-Wall]) adds -Wall to CFLAGS > > >> > > >> m4_ifdef([v_mic] ***) checks if v_mic is used (th

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Matthew Robbetts
On 08/18/10 21:08, Vincent Torri wrote: > > > On Wed, 18 Aug 2010, Matthew Robbetts wrote: > Hope this is the right one: http://pastebin.com/BwaR9jH4 >>> >>> add >>> >>> PKG_PROG_PKG_CONFIG >>> >>> line 292 of the configure.ac file, that is, just before : >>> >>> if test "x$e_cv_wan

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Vincent Torri
On Thu, 19 Aug 2010, Matthew Robbetts wrote: > On 08/18/10 21:08, Vincent Torri wrote: >> >> >> On Wed, 18 Aug 2010, Matthew Robbetts wrote: >> > > Hope this is the right one: > http://pastebin.com/BwaR9jH4 add PKG_PROG_PKG_CONFIG line 292 of the configu

Re: [E-devel] efl broken on Gentoo

2010-08-18 Thread Matthew Robbetts
On 08/19/2010 12:08 AM, Vincent Torri wrote: > > > On Thu, 19 Aug 2010, Matthew Robbetts wrote: > >> On 08/18/10 21:08, Vincent Torri wrote: >>> >>> >>> On Wed, 18 Aug 2010, Matthew Robbetts wrote: >>> >> >> Hope this is the right one: >> http://pastebin.com/BwaR9jH4 > > add >>