Re: [E-devel] Eobj - Request for review/comments

2012-05-16 Thread The Rasterman
On Sun, 15 Apr 2012 15:34:09 +0300 Tom Hacohen tom.haco...@samsung.com said: On 13/04/12 14:02, Carsten Haitzler (The Rasterman) wrote: 15. eobj_generic_data_* ... i really think this should support passing in a free func for generic data (NULL == dont free it), and previous egenric data

Re: [E-devel] Eobj - Request for review/comments

2012-05-16 Thread Tom Hacohen
On 16/05/12 11:01, Carsten Haitzler (The Rasterman) wrote: i'm coming back to this. i really still think we should have a free func. if it's null, nothing is freed for u. if not null it's called on object delete for any remaining properties still there. cost is just 1 more ptr. :) Oldie!

Re: [E-devel] Eobj - Request for review/comments

2012-05-16 Thread Vincent Torri
On Wed, May 16, 2012 at 10:01 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 15 Apr 2012 15:34:09 +0300 Tom Hacohen tom.haco...@samsung.com said: On 13/04/12 14:02, Carsten Haitzler (The Rasterman) wrote: 15. eobj_generic_data_* ... i really think this should support passing in a

Re: [E-devel] Doing some publicity

2012-05-16 Thread Vincent Torri
On Thu, May 10, 2012 at 3:56 AM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Let me in as well. I will do the technical review. Thanks for the job Jeff! Daniel Juyung Seo (SeoZ) On Thu, May 10, 2012 at 8:19 AM, Sanjeev BA eflel...@gmail.com wrote: I'd be happy to help with writing some

Re: [E-devel] Eobj - Request for review/comments

2012-05-16 Thread Cedric BAIL
On Wed, May 16, 2012 at 5:25 PM, Vincent Torri vincent.to...@gmail.com wrote: On Wed, May 16, 2012 at 10:01 AM, Carsten Haitzler ras...@rasterman.com wrote: On Sun, 15 Apr 2012 15:34:09 +0300 Tom Hacohen tom.haco...@samsung.com said: On 13/04/12 14:02, Carsten Haitzler (The Rasterman)

Re: [E-devel] [PATCH] Do not check for __FreeBSD_version in Ecore.h

2012-05-16 Thread Vincent Torri
On Wed, May 16, 2012 at 3:48 AM, Raphael Kubo da Costa rak...@freebsd.org wrote: FreeBSD 4.x was released more than a decade ago (the project itself only supports FreeBSD = 7 these days), so the check for __FreeBSD_version = 420001 is not necessary anymore (plus it probably never worked, as

Re: [E-devel] [Patch] elm_diskselector, set icon to added item

2012-05-16 Thread The Rasterman
On Mon, 30 Apr 2012 16:32:06 +0900 Kim Shinwoo kimcinoo@gmail.com said: actually not reviewing code itself here at all... going to review results. very interesting and quite cool! it's a step in the right direction indeed! but it does look a bit odd with the item flipping ONLY when it gets to

Re: [E-devel] E SVN: devilhorns trunk/evas/src/modules/engines/gl_x11

2012-05-16 Thread Jihoon Kim
I'm sorry. It was my mistake. I should have searched where it uded. 2012. 5. 16. 오후 5:03에 Enlightenment SVN no-re...@enlightenment.org님이 작성: Log: Evas (gl_x11): Unbreak build for gles_sgx s3c6410. Someone removed a variable that was actually being used :( Author: devilhorns Date:

Re: [E-devel] [PATCH] Only unlink the temporary file created in evas_object_image_memfile_set on cleanup (was evas_object_image_memfile_set is broken on non-Linux platforms)

2012-05-16 Thread Lucas De Marchi
On Tue, May 15, 2012 at 10:21 PM, Raphael Kubo da Costa rak...@freebsd.org wrote: Raphael Kubo da Costa rak...@freebsd.org writes: I was working on some code which uses evas_object_image_memfile_set here on FreeBSD, and it was failing. After some investigation, I found out that the problem

Re: [E-devel] E SVN: devilhorns trunk/evas/src/modules/engines/gl_x11

2012-05-16 Thread Chris Michael
No worries :) All fixed now :) dh -Original Message- From: Jihoon Kim [mailto:imfin...@gmail.com] Sent: 16 May 2012 14:00 To: enlightenment-devel@lists.sourceforge.net Subject: Re: [E-devel] E SVN: devilhorns trunk/evas/src/modules/engines/gl_x11 I'm sorry. It was my mistake. I

Re: [E-devel] [PATCH] Do not check for __FreeBSD_version in Ecore.h

2012-05-16 Thread Raphael Kubo da Costa
Vincent Torri vincent.to...@gmail.com writes: On Wed, May 16, 2012 at 3:48 AM, Raphael Kubo da Costa rak...@freebsd.org wrote: FreeBSD 4.x was released more than a decade ago (the project itself only supports FreeBSD = 7 these days), so the check for __FreeBSD_version = 420001 is not

Re: [E-devel] [PATCH] Do not check for __FreeBSD_version in Ecore.h

2012-05-16 Thread Vincent Torri
On Wed, May 16, 2012 at 4:06 PM, Raphael Kubo da Costa rak...@freebsd.org wrote: Vincent Torri vincent.to...@gmail.com writes: On Wed, May 16, 2012 at 3:48 AM, Raphael Kubo da Costa rak...@freebsd.org wrote: FreeBSD 4.x was released more than a decade ago (the project itself only supports

Re: [E-devel] [PATCH] Only unlink the temporary file created in evas_object_image_memfile_set on cleanup (was evas_object_image_memfile_set is broken on non-Linux platforms)

2012-05-16 Thread Raphael Kubo da Costa
Lucas De Marchi lucas.demar...@profusion.mobi writes: The renaming there is probably a hack so code paths that calls stat() to check if the file exists. If you know it exists, you could rename it to / for example or any path in put-here-your-choice-of-OS that is guaranteed to exist in the

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-16 Thread Davide Andreoli
2012/5/16 Enlightenment SVN no-re...@enlightenment.org Log: Elm fileselector_button: Fixed a bug when choosing a file. Author: tasn Date: 2012-05-16 05:12:34 -0700 (Wed, 16 May 2012) New Revision: 71165 Trac: http://trac.enlightenment.org/e/changeset/71165

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-16 Thread Tom Hacohen
On 16/05/12 22:02, Davide Andreoli wrote: Changelog? Backport? no? Changelog: fix a stupid bug in a widget no one uses (but my colleague it seems). Though seriously, changelog: no way I'm adding a changelog entry for that, we are really getting nuts with the changelog, we have 1 changes

Re: [E-devel] E SVN: sung IN trunk/evas: . src/lib src/modules/engines/gl_x11

2012-05-16 Thread Vincent Torri
missing doc for the new code in Evas_GL.h (don't forget @since) NEWS file, please Vincent On Mon, May 14, 2012 at 10:52 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Adding MSAA (Multisample Anti-Aliased) Surface Option to Evas GL.  Currently, this feature is only supported in

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-16 Thread The Rasterman
On Wed, 16 May 2012 23:59:38 +0300 Tom Hacohen t...@stosb.com said: On 16/05/12 22:02, Davide Andreoli wrote: Changelog? Backport? no? Changelog: fix a stupid bug in a widget no one uses (but my colleague it seems). the point of releases and stability is that regardless if *YOU* care,

[E-devel] [Patch][elm_gesture_layer] handling NULL in _tap_gesture_check_finish()

2012-05-16 Thread Kim Shinwoo
Dear All, Hello. There is a case that the Eina_List l; of Taps_Type would be NULL in _tap_gesture_check_finish(). If the below calls in the callback of gesture layer for ELM_GESTURE_N_DOUBLE_TAPS with ELM_GESTURE_STATE_END, then the callback for ELM_GESTURE_N_DOUBLE_TAPS with

Re: [E-devel] E SVN: sung IN trunk/evas: . src/lib src/modules/engines/gl_x11

2012-05-16 Thread Sung W. Park
Hi Vincent, I didn't realize I was neglecting the NEWS. I guess someone was covering my rear all this time. Thanks for getting the previous stuff in there to whoever it was. I'll get on it along with updating the Evas_GL. h. Thanks for pointing that out. cheers, Sung On Thu, May 17, 2012 at

Re: [E-devel] E SVN: hyoyoung trunk/elementary/src/lib

2012-05-16 Thread Hyoyoung Chang
Thanks, in svn - r71187 On Thu, May 17, 2012 at 1:39 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elementary/gesture_layer: add to null check at _tap_gesture_check_finish  Signed-off-by: Kim Shinwoo kimcinoo@gmail.com Author:       hyoyoung Date:         2012-05-16

Re: [E-devel] [Patch][elm_gesture_layer] handling NULL in _tap_gesture_check_finish()

2012-05-16 Thread Hyoyoung Chang
Thanks, in svn - r71187. On Thu, May 17, 2012 at 10:14 AM, Kim Shinwoo kimcinoo@gmail.com wrote: Dear All, Hello. There is a case that the Eina_List l; of Taps_Type would be NULL in _tap_gesture_check_finish(). If the below calls in the callback of gesture layer for

[E-devel] [PATCH] python-elementary: Align Table to C api

2012-05-16 Thread Kai Huuhko
--- .../elementary/elementary.c_elementary_table.pxi | 12 python-elementary/include/elementary/c_elementary.pxd | 13 - 2 files changed, 20 insertions(+), 5 deletions(-) diff --git a/python-elementary/elementary/elementary.c_elementary_table.pxi

[E-devel] [PATCH] python-elementary: Align Spinner to C api.

2012-05-16 Thread Kai Huuhko
--- .../elementary/elementary.c_elementary_spinner.pxi | 79 .../include/elementary/c_elementary.pxd| 27 +-- 2 files changed, 98 insertions(+), 8 deletions(-) diff --git a/python-elementary/elementary/elementary.c_elementary_spinner.pxi

[E-devel] [PATCH] python-elementary: Align Slider to C api.

2012-05-16 Thread Kai Huuhko
--- .../elementary/elementary.c_elementary_slider.pxi | 105 +++- .../include/elementary/c_elementary.pxd| 24 +++-- 2 files changed, 96 insertions(+), 33 deletions(-) diff --git a/python-elementary/elementary/elementary.c_elementary_slider.pxi