[E-devel] [E-Devel][PATCH] A few more fixes in e_fm

2013-10-07 Thread Yossi Kantor
This patch fixes a few thing after the changes made to an icon selection mechanism: 1) last selected icon and range selection pointers are reset after icons are freed for a a specific path (refresh, going to another path etc) 2) When no icons selected - pressing Up/Left selects the last icon an

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check."

2013-10-07 Thread ChunEon Park
Yes there was a misunderstanding. I agree. But I didn't disagree on Tom's request and revert. I agree on him(lack of commit message) and you. I just wondered one of the sentence in his revert comment. "I'm the only maintainer of. " "this commit looks wrong. evas_textblock_cursor_format_is_visibl

[E-devel] Weekly news from the automated build and QA front

2013-10-07 Thread Stefan Schmidt
Hello. *** Newsflash *** Ne statistical data proves that New research paper unvails that looking at potential problems early in the development and release process cuts down time spent on debugging aftterwards. Suggestions have been made that developers should have a look at these potential prob

Re: [E-devel] Weekly news from the automated build and QA front

2013-10-07 Thread Stefan Schmidt
On 10/07/2013 09:25 AM, Stefan Schmidt wrote: > Hello. > > *** Newsflash *** > Ne statistical data proves that ... that you should read through a mail again before sending it. regards Stefan Schmidt -- October Webinars:

Re: [E-devel] Weekly news from the automated build and QA front

2013-10-07 Thread Christopher Michael
On 10/07/2013 09:34 AM, Stefan Schmidt wrote: > On 10/07/2013 09:25 AM, Stefan Schmidt wrote: >> Hello. >> >> *** Newsflash *** >> Ne statistical data proves that > > ... that you should read through a mail again before sending it. > > regards > Stefan Schmidt LMAO dh --

[EGIT] [core/enlightenment] master 01/01: don't create border menu when border menu already exists

2013-10-07 Thread Mike Blumenkrantz
discomfitor pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=8a28ad9bb9d062381230401efbf96e0c2fde21ac commit 8a28ad9bb9d062381230401efbf96e0c2fde21ac Author: Mike Blumenkrantz Date: Mon Oct 7 10:12:54 2013 +0100 don't create border menu when

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check."

2013-10-07 Thread Tom Hacohen
On 07/10/13 09:14, ChunEon Park wrote: > Yes there was a misunderstanding. I agree. > > But I didn't disagree on Tom's request and revert. > I agree on him(lack of commit message) and you. I'm glad you agree with that, as that was the only thing I was arguing about. > > I just wondered one of th

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check."

2013-10-07 Thread ChunEon Park
OK, again to clarify this, I don't wanna arguing about commit message. Even I didn't oppose and mentioned about it in the replies. I agree on the more descrive commit msg also. My first asking was this, "is this right the evas_textblock_cursor_format_is_visible_get() cares the NULL returning?"

Re: [E-devel] [EGIT] [core/efl] master 01/01: Revert "evas/textblock - null check."

2013-10-07 Thread Tom Hacohen
On 07/10/13 11:48, ChunEon Park wrote: > OK, again to clarify this, > > I don't wanna arguing about commit message. > Even I didn't oppose and mentioned about it in the replies. > > I agree on the more descrive commit msg also. > > My first asking was this, > "is this right the evas_textblock_curso

[EGIT] [core/elementary] master 01/01: elm_spinner.c: call _value_set after resetting spin timer.

2013-10-07 Thread Daniel Juyung Seo
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=bc37f138f9595b2e4586105c616d53da637c96c0 commit bc37f138f9595b2e4586105c616d53da637c96c0 Author: Daniel Juyung Seo Date: Mon Oct 7 23:38:28 2013 +0900 elm_spinner.c: call _value_set after re

[EGIT] [core/elementary] master 01/01: elm_cnp.c: removed unused pointer value and initialized some local variables.

2013-10-07 Thread Daniel Juyung Seo
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=8ade252f622e98c897287be219dae61ca863261f commit 8ade252f622e98c897287be219dae61ca863261f Author: Daniel Juyung Seo Date: Tue Oct 8 00:03:05 2013 +0900 elm_cnp.c: removed unused pointer value

[EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Daniel Juyung Seo
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=ea7087c3ad6d24341159602dc95829daa0fa5557 commit ea7087c3ad6d24341159602dc95829daa0fa5557 Author: Daniel Juyung Seo Date: Tue Oct 8 00:08:19 2013 +0900 elm_cnp.c: Did a subtle code cleanup.

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Michael Blumenkrantz
the more important thing to note is that free(NULL) is a totally valid no-op, but for some reason people keep if() checking it... On Mon, 07 Oct 2013 08:08:08 -0700 Daniel Juyung Seo wrote: > seoz pushed a commit to branch master. > > http://git.enlightenment.org/core/elementary.git/commit/?id

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Tom Hacohen
On 07/10/13 16:19, Michael Blumenkrantz wrote: > the more important thing to note is that free(NULL) is a totally valid no-op, > but for some reason people keep if() checking it... > Yeah, ever since c89 (apparently, I thought only c99). However it's a legacy reason, probably buggy implementatio

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Michael Blumenkrantz
On Mon, 07 Oct 2013 16:32:54 +0100 Tom Hacohen wrote: > On 07/10/13 16:19, Michael Blumenkrantz wrote: > > the more important thing to note is that free(NULL) is a totally valid > > no-op, but for some reason people keep if() checking it... > > > > Yeah, ever since c89 (apparently, I thought on

[EGIT] [core/enlightenment] master 01/01: music control: add Clementine

2013-10-07 Thread q66
quaker pushed a commit to branch master. http://git.enlightenment.org/core/enlightenment.git/commit/?id=8e860facf4eb30a57883569cadf897f9ec5375d5 commit 8e860facf4eb30a57883569cadf897f9ec5375d5 Author: q66 Date: Mon Oct 7 18:16:42 2013 +0200 music control: add Clementine --- src/modules/m

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Daniel Juyung Seo
You're right. There are 40 instances of "if (xx) free(xx);" in elementary. I can clean them up as well :) My latest hobby is to clean up codes. It's just annoying. Daniel Juyung Seo (SeoZ) On Tue, Oct 8, 2013 at 12:19 AM, Michael Blumenkrantz < michael.blumenkra...@gmail.com> wrote: > the more

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Tom Hacohen
On 07/10/13 16:40, Michael Blumenkrantz wrote: > On Mon, 07 Oct 2013 16:32:54 +0100 > Tom Hacohen wrote: > >> On 07/10/13 16:19, Michael Blumenkrantz wrote: >>> the more important thing to note is that free(NULL) is a totally valid >>> no-op, but for some reason people keep if() checking it... >>

Re: [E-devel] [EGIT] [core/elementary] master 01/01: elm_cnp.c: Did a subtle code cleanup.

2013-10-07 Thread Michael Blumenkrantz
On Tue, 8 Oct 2013 01:33:07 +0900 Daniel Juyung Seo wrote: > You're right. > There are 40 instances of "if (xx) free(xx);" in elementary. > I can clean them up as well :) > My latest hobby is to clean up codes. It's just annoying. > > Daniel Juyung Seo (SeoZ) > > > On Tue, Oct 8, 2013 at 12:19

[EGIT] [bindings/python/python-efl] master 01/01: Python-EFL: unbreak the build with older Cython versions

2013-10-07 Thread davemds
davemds pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=feb9fb912c27204bb076adeb3c93ca81ae2d33df commit feb9fb912c27204bb076adeb3c93ca81ae2d33df Author: davemds Date: Mon Oct 7 21:18:44 2013 +0200 Python-EFL: unbreak the build with

[E-devel] E Menu fix for dark theme

2013-10-07 Thread Simon
Hi All, The attached patch is for the Dark theme in http://git.enlightenment.org/themes/dark.git/ it fixes E menu's. The patch came from the version of Dark in enlightenment master, i haven't looked through the changelogs yet to check for other differences this one just stops everything from w

Re: [E-devel] [EGIT] [core/enlightenment] master 01/01: music control: add Clementine

2013-10-07 Thread Lucas De Marchi
On Mon, Oct 7, 2013 at 1:17 PM, q66 wrote: > quaker pushed a commit to branch master. > > http://git.enlightenment.org/core/enlightenment.git/commit/?id=8e860facf4eb30a57883569cadf897f9ec5375d5 > > commit 8e860facf4eb30a57883569cadf897f9ec5375d5 > Author: q66 > Date: Mon Oct 7 18:16:42 2013 +02

[EGIT] [bindings/python/python-efl] master 01/01: Elementary: Make inheriting from scrollable a responsibility for the user.

2013-10-07 Thread Kai Huuhko
kuuko pushed a commit to branch master. http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=6299a6c8ae824d4d99e2dad3a937e82d50414763 commit 6299a6c8ae824d4d99e2dad3a937e82d50414763 Author: Kai Huuhko Date: Tue Oct 8 09:08:37 2013 +0300 Elementary: Make inheriting from s

[EGIT] [core/elementary] master 01/01: ctxpopup: fix elm_object_content_unset didn't unpack content from box

2013-10-07 Thread deasung . kim
seoz pushed a commit to branch master. http://git.enlightenment.org/core/elementary.git/commit/?id=0de4b6d2c3d7261f67383cd92e0b7a3453c5fa6b commit 0de4b6d2c3d7261f67383cd92e0b7a3453c5fa6b Author: deasung.kim Date: Tue Oct 8 15:41:06 2013 +0900 ctxpopup: fix elm_object_content_unset didn't