Re: [E-devel] [PATCH] Ecore_X.h typo

2011-08-26 Thread The Rasterman
On Sat, 27 Aug 2011 02:44:23 +0200 Leif Middelschulte said: > Hey guys'n'gals, > > I'm not yet sure how that happened, but I just found a typo in Ecore_X > header. Maybe dh renamed it while working on xcb? hmm no.. that was in your patch you sent: From: Leif Middelschulte To: Mike Blumenkrant

[E-devel] [PATCH] Ecore_X.h typo

2011-08-26 Thread Leif Middelschulte
Hey guys'n'gals, I'm not yet sure how that happened, but I just found a typo in Ecore_X header. Maybe dh renamed it while working on xcb? Find attached a patch. -- Leif From f22e173849871c71bc0336f68c553aa9232bb678 Mon Sep 17 00:00:00 2001 From: Leif Middelschulte Date: Sat, 27 Aug 2011 02:40:

Re: [E-devel] e_dbus safety checks

2011-08-26 Thread Gustavo Barbieri
Yeah, just missing. Commit to svn please! --Gustavo Sent from my iPhone On 26/08/2011, at 18:42, Mike Blumenkrantz wrote: > On Fri, 26 Aug 2011 23:26:18 +0200 > Leif Middelschulte wrote: > >> Hi all, >> >> by trying out shotgun I found two possible segvs in e_dbus. >> >> I don't know whether

Re: [E-devel] E SVN: acidx trunk/enjoy/src/bin

2011-08-26 Thread Gustavo Barbieri
Leandro, check e17 or ecore itself, some of used approach is not common. Nitpicking review follows: 1- events are EAPI extern int ENJOY_SOMENAME. We don't export symbols yet, so just define an EAPI and these symbols inside a new Enjoy_Plugins.h, see other public headers 2- avoid no_free, just do

Re: [E-devel] e_dbus safety checks

2011-08-26 Thread Mike Blumenkrantz
On Fri, 26 Aug 2011 23:26:18 +0200 Leif Middelschulte wrote: > Hi all, > > by trying out shotgun I found two possible segvs in e_dbus. > > I don't know whether the checks are omitted for performance reasons, > but I created a patch anyway. > > these functions are from the days before null che

[E-devel] e_dbus safety checks

2011-08-26 Thread Leif Middelschulte
Hi all, by trying out shotgun I found two possible segvs in e_dbus. I don't know whether the checks are omitted for performance reasons, but I created a patch anyway. -- Leif From 9568669c8dec8a8d10e45d0b8e8e8296bc828df0 Mon Sep 17 00:00:00 2001 From: Leif Middelschulte Date: Fri, 26 Aug 2011

Re: [E-devel] E SVN: discomfitor IN trunk/e/src/modules: bluez connman

2011-08-26 Thread Gustavo Barbieri
Ugh! Just change the pointer prototype to get const char* instead. It makes everything more clear --Gustavo Sent from my iPhone On 26/08/2011, at 14:19, Enlightenment SVN wrote: > Log: > more warnings > > > Author: discomfitor > Date: 2011-08-26 10:19:17 -0700 (Fri, 26 Aug 2011)

Re: [E-devel] E SVN: nash IN trunk/evas: . src/lib/canvas

2011-08-26 Thread Rafael Antognolli
Hello guys, I have some problem with this commit. Since the "pixels" pointer is assigned in the beginning of the function evas_object_image_render, and it points usually to o->engine_data (when there's no proxy object), and is later on this function used for drawing, if the o->engine_data becomes