[E-devel] eet cache bug (memory use after free)

2010-03-03 Thread Adam Simpkins
write contains uninitialised bytes) happened immediately after starting e17, and seem to be unrelated. The "invalid read" errors occured when bringing up the Gadget Settings. This was using revision r46451 from subversion. -- Adam Simpkins a...@adamsimpkins.net ==30241== Memcheck, a memory

Re: [E-devel] eet cache bug (memory use after free)

2010-03-04 Thread Adam Simpkins
registered accounts don't have permission to create tickets. -- Adam Simpkins a...@adamsimpkins.net On Wednesday, March 3, 2010 1:32pm, "Adam Simpkins" said: > I was running e17 under valgrind, and encountered the following error. > I'm not all that familiar with the code, but

[E-devel] [PATCH] eet: fix cache locking

2010-03-04 Thread Adam Simpkins
The previous cache locking was insufficient. eet_clearcache() used no locking at all. eet_open() locked the cache to find an existing entry, but then unlocked the cache before incrementing the file's reference count and using the file. eet_close() also did not hold a lock while decrementing the