Re: [E-devel] Quality of bugs on phab

2018-07-29 Thread Gustavo Sverzut Barbieri
ne, but some software I've used even did a REST call to search for similar issues (issues with similar backtrace, not sure how they implemented that). BR, -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 ---

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: path get actually allocate memory and can't be pure.

2018-05-24 Thread Gustavo Sverzut Barbieri
f a > case where you give the returned value to a function that calls free. The > compiler might be unable to detect that and assume that it can move out the > function call, which causes a multi-free call on the same pointer. > > Greetings > bu5hm4n > > > Am 24. Mai 2018 15:58:0

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: path get actually allocate memory and can't be pure.

2018-05-24 Thread Gustavo Sverzut Barbieri
this function returns @c NULL. > */ > EAPI char * > - eina_module_environment_path_get(const char *env, const char *sub_dir) > EINA_PURE EINA_MALLOC EINA_ARG_NONNULL(1, 2); > + eina_module_environment_path_get(const char *env, const char *sub_dir) > EINA_MALLOC EINA_ARG

Re: [E-devel] EINA_MALLOC conflicting with EINA_PURE

2018-05-15 Thread Gustavo Sverzut Barbieri
--- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > __

Re: [E-devel] [EGIT] [core/efl] master 49/66: eina: make eina_value_pget on an EINA_VALUE_TYPE_STRINGSHARE return a new reference to a stringshare.

2018-05-03 Thread Gustavo Sverzut Barbieri
is best to not ref, I will fix this the other way around. > > On May 2, 2018 7:33 AM, Gustavo Sverzut Barbieri <barbi...@gmail.com> wrote: >> this doesn't look right, we don't ref in other cases... >> >> On Tue, May 1, 2018 at 2:40 PM, Cedric BAIL cedric.b...@free.fr

Re: [E-devel] [EGIT] [core/efl] master 49/66: eina: make eina_value_pget on an EINA_VALUE_TYPE_STRINGSHARE return a new reference to a stringshare.

2018-05-02 Thread Gustavo Sverzut Barbieri
m = mem; > @@ -5197,7 +5207,7 @@ static const Eina_Value_Type _EINA_VALUE_TYPE_BASICS[] > = { > NULL, /* no convert from */ > _eina_value_type_stringshare_vset, > _eina_value_type_stringshare_pset, > - _eina_value_type_string_common_pget > +_eina_value_type_stringshare_pget >

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore ipc - fix send to skip data payload if null/0

2018-04-11 Thread Gustavo Sverzut Barbieri
On Wed, Apr 11, 2018 at 2:08 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Wed, 11 Apr 2018 13:21:22 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> On Wed, Apr 11, 2018 at 2:43 AM, Carsten Haitzler <ras...@rasterman.com> >>

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore ipc - fix send to skip data payload if null/0

2018-04-11 Thread Gustavo Sverzut Barbieri
people don't have to spread this kind of code at call sites. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Check out the vibrant tech community on one of the world's most

Re: [E-devel] [EGIT] [core/efl] master 02/05: ecore_con_url: implement transfer speed limitation options

2018-03-26 Thread Gustavo Sverzut Barbieri
b/src/lib/ecore_con/ecore_con_url_curl.h > @@ -268,6 +268,8 @@ typedef enum > CINIT(INFILESIZE_LARGE, OFF_T, 115), > CINIT(POSTFIELDSIZE_LARGE, OFF_T, 120), > CINIT(COOKIELIST, OBJECTPOINT, 135), > + CINIT(MAX_SEND_SPEED_LARGE, OFF_T, 145), > + CINIT(MAX_RECV_SPEED_L

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl.task - move to returning future insead of bool + exit event

2018-03-20 Thread Gustavo Sverzut Barbieri
exit(-122); > - return EINA_FALSE; > + return NULL; this is one place you could notify the main process and cause it to reject with the errno. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 --

Re: [E-devel] [EGIT] [core/efl] master 01/02: eo: automatically cancel a future that is attached to an invalidated object.

2018-03-20 Thread Gustavo Sverzut Barbieri
ETY_ON_NULL_GOTO(o, end); > pd = efl_data_scope_get(o, EFL_OBJECT_CLASS); > EINA_SAFETY_ON_NULL_GOTO(pd, end); > + if (pd->invalidate) goto end; I'd use EINA_SAFETY_ON_TRUE_GOTO(pd->invalidate, end); so it will emit a message. -- G

Re: [E-devel] futures again... :(

2018-03-14 Thread Gustavo Sverzut Barbieri
On Wed, Mar 14, 2018 at 2:50 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Tue, 13 Mar 2018 10:35:15 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> On Tue, Mar 13, 2018 at 1:17 AM, Carsten Haitzler <ras...@rasterman.com> >> wrote

Re: [E-devel] futures again... :(

2018-03-13 Thread Gustavo Sverzut Barbieri
don't even see how you can compare this two lines ? And we are >> > > >> >> >> not even looking at the user of the API here which is what >> > > >> >> >> matter even more. How do you make sure that the event is always >> > >

Re: [E-devel] [EGIT] [core/efl] master 01/02: ecore - efl exe/thread - only allow run once ever

2018-03-12 Thread Gustavo Sverzut Barbieri
ah ok! :-) On Mon, Mar 12, 2018 at 1:07 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Sun, 11 Mar 2018 16:51:47 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> On Sat, Mar 10, 2018 at 8:04 AM, Carsten Haitzler <ras...@rasterman.com> >

Re: [E-devel] futures again... :(

2018-03-12 Thread Gustavo Sverzut Barbieri
On Mon, Mar 12, 2018 at 1:01 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > > On Sun, 11 Mar 2018 16:49:37 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > > > On Sat, Mar 10, 2018 at 6:42 AM, Carsten Haitzler <ras...@rasterman.com> > >

Re: [E-devel] [EGIT] [core/efl] master 01/02: ecore - efl exe/thread - only allow run once ever

2018-03-11 Thread Gustavo Sverzut Barbieri
escreveu: > On Sun, Mar 11, 2018 at 8:51 PM, Gustavo Sverzut Barbieri > <barbi...@gmail.com> wrote: > > On Sat, Mar 10, 2018 at 8:04 AM, Carsten Haitzler <ras...@rasterman.com> > wrote: > >> raster pushed a commit to branch master. > >> >

Re: [E-devel] [EGIT] [core/efl] master 01/02: ecore - efl exe/thread - only allow run once ever

2018-03-11 Thread Gustavo Sverzut Barbieri
exit_called : 1; > + Eina_Bool run : 1; > }; if you used pd->promise here, there is no need to keep that flag. I'm not sure why you're trying to co-exist promise with-no-promise for this API, this will just add confusion and code to maintain. Here yo

Re: [E-devel] futures again... :(

2018-03-11 Thread Gustavo Sverzut Barbieri
On Sat, Mar 10, 2018 at 6:42 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 9 Mar 2018 10:52:59 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> > said: > >> On Thu, Mar 8, 2018 at 4:58 AM, Carsten Haitzler <ras...@rasterman.com> >&g

Re: [E-devel] futures again... :(

2018-03-09 Thread Gustavo Sverzut Barbieri
On Thu, Mar 8, 2018 at 4:58 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Thu, 1 Mar 2018 14:11:26 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> > said: > >> On Wed, Feb 28, 2018 at 2:33 AM, Carsten Haitzler <ras...@rasterman.com> >>

Re: [E-devel] Ecore - Efl.Loop + Task + Thread + App + Appthread + Exe

2018-03-06 Thread Gustavo Sverzut Barbieri
On Tue, Mar 6, 2018 at 5:40 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Mon, 5 Mar 2018 11:00:27 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> > said: > >> On Sat, Mar 3, 2018 at 2:02 AM, Carsten Haitzler <ras...@rasterman.c

Re: [E-devel] Ecore - Efl.Loop + Task + Thread + App + Appthread + Exe

2018-03-05 Thread Gustavo Sverzut Barbieri
or things that are the same, so if the methods in process and threads share the same concept, behavior and parameters, make them an interface... when switching from process x threads one doesn't need to "sed" everything. However, definitely constructors are NOT the same concept, behavior or

Re: [E-devel] [EGIT] [core/efl] master 01/03: efl loop promises - cleare out promise data to null

2018-03-05 Thread Gustavo Sverzut Barbieri
; > + d->promise = NULL; > efl_loop_promise_simple_data_mp_free(d); > } this is strange: d comes from the mempool and all calls are protected with "is p valid in the mempool", which should evaluate

Re: [E-devel] futures again... :(

2018-03-01 Thread Gustavo Sverzut Barbieri
ar and standard way. so yes, you're doing bit more work so users don't have to. Like keeping references, canceling, etc. Our hope is that core devs (that usually deal with eina_promise part) will be more careful with managements and the likes. users just pass one callback and *always* get call

Re: [E-devel] Theme MUST be addressed

2018-02-27 Thread Gustavo Sverzut Barbieri
_ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 ---

Re: [E-devel] Terminology support added on mdcat

2018-01-31 Thread Gustavo Sverzut Barbieri
mmunity on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlight

Re: [E-devel] Eolian template based generator presentation

2018-01-26 Thread Gustavo Sverzut Barbieri
hat this is a great tool that you provide here, but I > doubt other languages than Python will adopt this straight away. Unless we > start working on a new binding, maybe? well, point is you can create a new binding just replacing the text files that are the template... so maybe even c++ and c# could be change

Re: [E-devel] efl_add causing confusion

2018-01-11 Thread Gustavo Sverzut Barbieri
On Thu, Jan 11, 2018 at 5:54 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Wed, 10 Jan 2018 16:52:26 -0200 Gustavo Sverzut Barbieri ... >> however, in a more generic OOP system this makes things unusable, as >> we're discussing in this thread. >> >>

Re: [E-devel] efl_add causing confusion

2018-01-11 Thread Gustavo Sverzut Barbieri
k > any of the above can fix this: > - invalidator (called by efl_invalidate) just hides and triggers an event > - but no ref change > - destructor (called when refs = 0) remains unchanged: delete most things > but keep internal evas object data safe for 2 frames for cur/p

Re: [E-devel] [EGIT] [core/efl] master 02/05: selection: add efl_selection interface

2018-01-11 Thread Gustavo Sverzut Barbieri
); > //ecore_event_add(ELM_CNP_EVENT_SELECTION_CHANGED, e, > _wl_selection_changed_free, ev->display); > - //efl_event_callback_call(sel->request_obj, > EFL_SELECTION_EVENT_SELECTION_CHANGED, ); > + efl_event_callback_call(sel->request_obj, > EFL_SELECTION_EVENT_SELECTION_C

Re: [E-devel] [EGIT] [core/efl] master 05/06: eina: add eina_promise_continue_new to create a promise using an existing dead future.

2018-01-11 Thread Gustavo Sverzut Barbieri
ady have a value and want to create a future that will > + * resolve to it directly use the eina_future_resolved(), it has the > + * same effect as creating a promise and immediately resolving it. this comment is confusing here. If you have a value resolved, just RETURN it in this fu

Re: [E-devel] efl_add causing confusion

2018-01-10 Thread Gustavo Sverzut Barbieri
hi all, jpeg, i think that this "destruct" event should have a counterpart method, like in GObject they have dispose + finalize, we could have something like that to allow two clearly distinct phases: - one to release references to others (our invalidate/terminate), announces that everyone

Re: [E-devel] API namespacing

2018-01-08 Thread Gustavo Sverzut Barbieri
HTTP Last-Modified/If-Modified-Since, Etag/If-None-Match... respect Expiry, store in local files, like done for web runtimes). TL;DR: it should but won't go away, so this virtualized file should be renamed, however I have no suggestions as I'm bad at names :-) -- Gustavo Sverzut Barbieri -

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl loop - provide efl namespace versions of begin/end locks on mainloop

2018-01-08 Thread Gustavo Sverzut Barbieri
On Mon, Jan 8, 2018 at 4:53 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 5 Jan 2018 11:26:14 -0200 Gustavo Sverzut Barbieri > <barbi...@gmail.com> ... >> > see https://phab.enlightenment.org/T5522 >> > >> > it has a lot more details

Re: [E-devel] [EGIT] [core/efl] master 01/01: promise: Add even simpler helper for main loop promise creation

2018-01-08 Thread Gustavo Sverzut Barbieri
On Mon, Jan 8, 2018 at 3:38 AM, Jean-Philippe André <j...@videolan.org> wrote: > On Fri, Jan 5, 2018 at 3:18 AM, Gustavo Sverzut Barbieri <barbi...@gmail.com >> wrote: > >> On Thu, Jan 4, 2018 at 2:59 PM, Andrew Williams <a...@andywilliams.me> >> wrote: >

Re: [E-devel] [EGIT] [core/efl] master 03/03: efl signals - add signal callbacks for minimal signal set on loops

2018-01-06 Thread Gustavo Sverzut Barbieri
ntary]] > + signal,usr1; [[System specific, but on unix maps to SIGUSR1 signal to > the process - only called on main loop object]] > + signal,usr2; [[System specific, but on unix maps to SIGUSR2 signal to > the process - only called on main loop object]] > + sig

Re: [E-devel] [EGIT] [core/efl] master 02/03: ecore signal - move to using a pipe (and optional thread) tfor signals

2018-01-06 Thread Gustavo Sverzut Barbieri
*event) > efl_del(event->object); > } > > +static void > +_ecore_signal_waitpid(Eina_Bool once, siginfo_t info) > +{ > + pid_t pid; > + int status; > + > + while ((pid = waitpid(-1, , WNOHANG)) > 0) > + { > + Ecore_Exe_Event_Del *e = _ecore_exe_event_del_new(); > + > +//FIXME

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl loop - provide efl namespace versions of begin/end locks on mainloop

2018-01-05 Thread Gustavo Sverzut Barbieri
On Fri, Jan 5, 2018 at 11:04 AM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 5 Jan 2018 10:53:46 -0200 Gustavo Sverzut Barbieri > <barbi...@gmail.com> > said: > >> On Fri, Jan 5, 2018 at 4:04 AM, Carsten Haitzler <ras...@rasterman.com> >> wr

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl loop - provide efl namespace versions of begin/end locks on mainloop

2018-01-05 Thread Gustavo Sverzut Barbieri
in(loop); efl_loop_thread_usage_end(loop); or my preference: efl_loop_thread_pause(loop); efl_loop_thread_resume(loop); anyway, if by final EO api release we still offer efl_main_loop helpers (I think we shouldn't!), then you can offer your helpers on top of that. -- Gustavo

Re: [E-devel] efl_add causing confusion

2018-01-04 Thread Gustavo Sverzut Barbieri
t;release" to be something related to object lifecycle. maybe "terminate"? as in: - network connection: terminate, clear it should be closed and all - gui element: terminate, clear it should be hidden and all -- Gustavo Sverzut Barbieri -

Re: [E-devel] [EGIT] [core/efl] master 01/01: promise: Add even simpler helper for main loop promise creation

2018-01-04 Thread Gustavo Sverzut Barbieri
ot; (efl_loop_timeout). If there is a wrapper for "events -> future" as said above, then common stuff as "call me when efl.io.copier is done" will also be automatic and fall in this category. This is what most applications would ever use. -- Gustavo Sverzut Barbieri --

Re: [E-devel] [EGIT] [core/efl] master 01/01: promise: Add even simpler helper for main loop promise creation

2018-01-04 Thread Gustavo Sverzut Barbieri
EFL would be to identify code as "efl_loop_main_get()" or others that assume a main loop instead of propagating using loop/loop-user... and mark as a bug. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_loop: move scheduler_get to eo API

2018-01-03 Thread Gustavo Sverzut Barbieri
e above, the Promise constructor implemented in C would be calling 2 EFL functions: - efl_loop_future_scheduler_get() - eina_promise_new() And there is no need to expose efl_loop_future_scheduler_get() at all. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_loop: move scheduler_get to eo API

2018-01-03 Thread Gustavo Sverzut Barbieri
language-native Promise implementation, so it can be chained with other promise/future... like in Python. This requires some extra work, it's not trivial or auto-generated. -- Gustavo Sverzut Barbieri -- Mob

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_loop: move scheduler_get to eo API

2018-01-03 Thread Gustavo Sverzut Barbieri
his all needs manual work, so exposing this method in ".eo" to be parseable by eolian will not be useful. I recall that was the reason to not put it in ".eo", just in eo-only and c-only header. -- Gustavo Sverzut Barbieri

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_loop: move scheduler_get to eo API

2018-01-03 Thread Gustavo Sverzut Barbieri
,7 @@ EAPI int efl_loop_exit_code_process(Eina_Value *value); > > #include "efl_loop_consumer.eo.h" > > -EAPI Eina_Future_Scheduler *efl_loop_future_scheduler_get(Eo *obj); > +EAPI Eina_Future_Scheduler *efl_loop_future_scheduler_get(const Eo *obj); you can remove this one, it's gen

Re: [E-devel] Type info in futures

2017-12-19 Thread Gustavo Sverzut Barbieri
think? You're right, it should be declared as you said, but q66 still needs to convert that part of the code, then we must properly annotate them. but eina_future dispatches eina_value, which always carry a type... then you can do something like: printf("type %

Re: [E-devel] [EGIT] [core/efl] master 06/12: loop: Try harder to find the main loop

2017-12-19 Thread Gustavo Sverzut Barbieri
_Data *pd EINA_UNUSED) > { > + if (eina_main_loop_is()) > + return ecore_main_loop_get(); > return efl_provider_find(obj, EFL_LOOP_CLASS); looks like that should be the fallback, not the first thing to check: only check if the main loop if there is no provider for EFL_LOOP_

Re: [E-devel] [EGIT] [core/efl] master 03/12: eo/eina: Add HACK to avoid calls to EO after shutdown

2017-12-19 Thread Gustavo Sverzut Barbieri
al function. Do not use. > + * > + * @internal > + */ > +EAPI void __eina_promise_cancel_all(void); > > /** > * @} > diff --git a/src/lib/eo/efl_future.c b/src/lib/eo/efl_future.c > index aaa1d88a51..8f19a34e11 100644 > --- a/src/lib/

Re: [E-devel] [EGIT] [tools/examples] master 01/01: eina: Add a first pass futures example (from eina examples)

2017-12-12 Thread Gustavo Sverzut Barbieri
na_value_get(, ); > + > + return *eina_value_util_int_new(val * 2); this leaks the newly allocated Eina_Value, it's better to use: eina_value_int_init(val * 2) > +static Eina_Value > +_chain_with_error_cb(void *data EINA_UNUSED

Re: [E-devel] [EGIT] [core/efl] master 06/07: ecore: rename efl_loop_Eina_FutureXXX_job to efl_loop_job.

2017-12-12 Thread Gustavo Sverzut Barbieri
On Tue, Dec 12, 2017 at 10:23 AM, Gustavo Sverzut Barbieri <barbi...@gmail.com> wrote: >> efl_future_Eina_FutureXXX_then(data, f); > > now must rename these efl_future_Eina_FutureXXX_then() helpers to > efl_future_then(). > > Worth remembering: efl_future_then()

Re: [E-devel] [EGIT] [core/efl] master 06/07: ecore: rename efl_loop_Eina_FutureXXX_job to efl_loop_job.

2017-12-12 Thread Gustavo Sverzut Barbieri
alidator would do extended checks for those types. Eolian has the info to generate those, as we have builtin types. I recall eina_future_race uses a custom struct and can serve as base for such work. -- Gustavo Sverzut Barbieri -

Re: [E-devel] [EGIT] [core/efl] master 02/02: ecore_con: use eina_future based timeout for tests.

2017-12-04 Thread Gustavo Sverzut Barbieri
not sure you need a type, I guess you can pass null, so it will accept all types except error. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Check out the vibrant

Re: [E-devel] [EGIT] [core/efl] master 03/05: efl: Introduce interface Efl.Dup

2017-12-04 Thread Gustavo Sverzut Barbieri
>> > > > > >> > > > > @@ -936,7 +936,7 @@ _evas_event_source_multi_down_ >> > > > > events(Evas_Object_Protected_Data *obj, Evas_Publi >> > > > > >> > > > > if (obj->delete_me || src->delete_me || >> >

Re: [E-devel] [EGIT] [core/efl] master 02/02: ecore_con: use eina_future based timeout for tests.

2017-12-01 Thread Gustavo Sverzut Barbieri
eout(void *data, > + const Eina_Value t, > + const Eina_Future *dead EINA_UNUSED) > { > Eina_Bool *did = data; > + > + if (t.type == EINA_VALUE_TYPE_ERROR) > + return t; if you just want the success case, you can use the

Re: [E-devel] [EGIT] [tools/examples] master 01/01: core: Add Efl_Io_File example into efl-core reference

2017-11-28 Thread Gustavo Sverzut Barbieri
ll "efl_io_reader_read()". The best approach is to use efl_io_copier class, that does all of that for you in a main loop friendly way. if you want to show case the "efl_io_reader/writer" APIs directly, then also use can_{read,write} events... otherwise people will misuse that.

Re: [E-devel] [EGIT] [core/efl] master 07/12: ecore_con: quiet 2 "clobbered" warnings in ecore_con

2017-11-27 Thread Gustavo Sverzut Barbieri
On Mon, Nov 27, 2017 at 4:49 AM, Jean-Philippe André <j...@videolan.org> wrote: > On Sun, Nov 26, 2017 at 9:25 PM, Gustavo Sverzut Barbieri < > barbi...@gmail.com> wrote: > >> On Thu, Nov 23, 2017 at 9:58 PM, Pawel Aksiutowicz >> <p.aksiuto...@partner.samsung.c

Re: [E-devel] [EGIT] [core/efl] master 07/12: ecore_con: quiet 2 "clobbered" warnings in ecore_con

2017-11-26 Thread Gustavo Sverzut Barbieri
tile uint8_t user_len = user ? strlen(user) : 0; > + volatile uint8_t pass_len = pass ? strlen(pass) : 0; what? someone care to explain why adding "volatile" here quites clobbered... what was clobbered? it makes no sense to me to add these vol

Re: [E-devel] ecore main loop -> efl_loop full convert

2017-11-26 Thread Gustavo Sverzut Barbieri
se, just be aware that MY_EVENT_CLASS for legacy is a single one: ECORE_EVENT_LEGACY_CLASS. It will contain "legacy_type: int" property, which uses the global integers to work on. Then ecore_event_callback_add() will connect efl_event_callback_call() using a proxy/wrapper, that will filter by &quo

Re: [E-devel] ecore main loop -> efl_loop full convert

2017-11-25 Thread Gustavo Sverzut Barbieri
free_func... and thus finding it is a simple list walk. bindings will have the same cb/free_func, but different data. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Check

Re: [E-devel] ecore main loop -> efl_loop full convert

2017-11-25 Thread Gustavo Sverzut Barbieri
class). Or impose it's always a structure and in this >> case pass the Eina_Value_Struct_Desc instead of Eina_Value_Type as >> "event_class". > > eina value might be another option for the event object to be posted, but i > kind of leaned to the heavier eo objects... be

Re: [E-devel] ecore main loop -> efl_loop full convert

2017-11-23 Thread Gustavo Sverzut Barbieri
is is consistent with input events (info type are EO objects with a > common base class). > I see no major issue with this design, besides extra memory requirements. > > -- > Jean-Philippe André > -- >

Re: [E-devel] Terminology, one of the coolest linux terminal emulators

2017-11-23 Thread Gustavo Sverzut Barbieri
- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > ___________ > enlightenment-devel mailing list > enlightenment-devel@lists.s

Re: [E-devel] Eo API docs: Large inheritance content

2017-11-23 Thread Gustavo Sverzut Barbieri
at's possible. > > PS: The inheritance graph picture should not be generated with a max size, > as it becomes unreadable. > > -- > Jean-Philippe André > -- > Check out the vibrant

Re: [E-devel] [EGIT] [core/efl] master 01/03: eina: add a function return a reference to a copy of Eina_Value.

2017-11-17 Thread Gustavo Sverzut Barbieri
eturn an empty >>> value? >>> >>> copy is deep-copy, it may need to walk thru arrays, lists and >>> hashes... and some values may not provide copy, then it will fail. > > Right. Maybe actually return an Eina_Error actually ? Not sure which solution > is best a

Re: [E-devel] Eina_str split/join

2017-11-17 Thread Gustavo Sverzut Barbieri
ty on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenmen

Re: [E-devel] .eo.c to .eo.x

2017-11-15 Thread Gustavo Sverzut Barbieri
On Tue, Nov 14, 2017 at 10:37 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Tue, 14 Nov 2017 14:51:38 -0200 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> On Tue, Nov 14, 2017 at 9:35 AM, <marcel-hollerb...@t-online.de> wrote: >> >

Re: [E-devel] .eo.c to .eo.x

2017-11-14 Thread Gustavo Sverzut Barbieri
On Tue, Nov 14, 2017 at 9:35 AM, <marcel-hollerb...@t-online.de> wrote: > On Tue, Nov 14, 2017 at 09:22:01AM -0200, Gustavo Sverzut Barbieri wrote: >> while I'm okay with .eo.x, I'm not sure you should include it in >> "sources", rather do in "dependencies&qu

Re: [E-devel] .eo.c to .eo.x

2017-11-14 Thread Gustavo Sverzut Barbieri
ld speed up a lot the efl build. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdo

Re: [E-devel] .eo.c to .eo.x

2017-11-14 Thread Gustavo Sverzut Barbieri
nlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890 -- Chec

Re: [E-devel] [EGIT] [core/efl] master 01/03: eina: add a function return a reference to a copy of Eina_Value.

2017-11-04 Thread Gustavo Sverzut Barbieri
*val) > +{ > + Eina_Value v = EINA_VALUE_EMPTY; > + > + eina_value_setup(, eina_value_type_get(val)); > + eina_value_copy(val, ); should we detect copy failed and in that case flush v and return an empty value? copy is deep-copy, it may need to walk thru

Re: [E-devel] [EGIT] [core/efl] master 03/03: eo: add helper to manipulate Eo object as Eina_Value.

2017-11-04 Thread Gustavo Sverzut Barbieri
TYPE_OBJECT); > + if (v) eina_value_set(v, obj); > + return v; > +} > + > +/** > + * @brief Create a new #EinaInitializeining the passed parameter typo or we got a new EinaInitalizeining? :-) other than that would note that eina_value holds the reference to the object, thus it will

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_ui_calendar: apply new format_cb

2017-11-01 Thread Gustavo Sverzut Barbieri
calendar... then on other widgets that may need time and date format, you'd just pass the string. Say you create a "date input field", it would need to format similarly to calendar. -- Gustavo Sverzut Barb

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: eina_value: fix the typo in doc

2017-11-01 Thread Gustavo Sverzut Barbieri
@li EINA_VALUE_TYPE_TIMEVAL: struct timeval* > * @li EINA_VALUE_TYPE_BLOB: Eina_Value_Blob* > - * @li EINA_VALUE_TYPE_BLOB: Eina_Value_Blob* > + * @li EINA_VALUE_TYPE_STRUCT: Eina_Value_Struct looking the others, here should be "Struct*", since we're talking about "pset()"

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: eina_value - Add "struct tm" support

2017-11-01 Thread Gustavo Sverzut Barbieri
et, it's pset(). get() and pget() are basically the same. think about printf (set) x scanf (get). then review all other documentation you wrote, things that insert in array/list/hash, etc... are like set(). -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 9935

Re: [E-devel] [EGIT] [core/efl] master 04/04: efl: add an efl-net.pc

2017-10-28 Thread Gustavo Sverzut Barbieri
tdir}${ > eoincludedir}/emile-@VMAJ@ -I${pc_sysrootdir}${eoincludedir}/eina-@VMAJ@ > + > +Name: ecore-con > too much copy & paste? better to name it: efl-net > +Description: E core library, Con module > EFL networking module. other than that, should this automatically defi

Re: [E-devel] [EGIT] [core/efl] master 01/03: Efl.Ui.Format: implement generic format_string function

2017-10-27 Thread Gustavo Sverzut Barbieri
On Fri, Oct 27, 2017 at 12:42 AM, Jean-Philippe André <j...@videolan.org> wrote: > 2017-10-27 11:12 GMT+09:00 Amitesh Singh <singh.amit...@gmail.com>: > > > Hello, > > > > > > On Thu, Oct 26, 2017 at 9:30 PM, Gustavo Sverzut Barbieri < > > barbi.

Re: [E-devel] [EGIT] [core/efl] master 01/03: Efl.Ui.Format: implement generic format_string function

2017-10-26 Thread Gustavo Sverzut Barbieri
Think of bindings (ie: python/javascript/c#), they may want to call the implementation of efl.ui.slider.... how to? you need to provide a method to allow that. -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890

Re: [E-devel] [EGIT] [core/efl] master 03/03: config: Simplify EO API

2017-10-20 Thread Gustavo Sverzut Barbieri
On Fri, Oct 20, 2017 at 4:18 AM, Jean-Philippe André <j...@videolan.org> wrote: > 2017-10-20 8:15 GMT+09:00 Carsten Haitzler <ras...@rasterman.com>: > >> On Thu, 19 Oct 2017 14:28:27 -0200 Gustavo Sverzut Barbieri >> <barbi...@gmail.com> said: >> >&

Re: [E-devel] [EGIT] [core/efl] master 03/03: config: Simplify EO API

2017-10-20 Thread Gustavo Sverzut Barbieri
On Thu, Oct 19, 2017 at 9:15 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Thu, 19 Oct 2017 14:28:27 -0200 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> > + get { >> > +keys { >> > + name: st

Re: [E-devel] [EGIT] [core/efl] master 03/03: config: Simplify EO API

2017-10-19 Thread Gustavo Sverzut Barbieri
> + get { > +keys { > + name: string; [[Configuration option name.]] shall we document and handle this as a path, so nested Eets can be used, such as in E (wm). -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 9

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl_ui_format: fix the namings and docs

2017-10-17 Thread Gustavo Sverzut Barbieri
]] > } > values { > func: Efl.Ui.Format_Func_Cb @nullable; [[The format function > callback]] > } >} > - @property unit @protected { > + @property format_string @protected { > [[Control the format string for a given units l

Re: [E-devel] [EGIT] [core/efl] master 01/01: efl intf: Add format interface

2017-10-16 Thread Gustavo Sverzut Barbieri
of a value. You may use it to format some date, etc. my suggestion is to change it to "format_template" or "format_string"... and pass that to format_cb/func as above, so you could change the template string and get it pass

Re: [E-devel] [EGIT] [core/efl] master 01/01: eina: strbuf - Add strftime related functions

2017-10-16 Thread Gustavo Sverzut Barbieri
info); > + > + buf = eina_strbuf_new(); > + eina_strbuf_append_strftime(buf, "%I:%M%p", info); > + str = eina_strbuf_string_get(buf); > + fail_if(str == NULL || strcmp(str, cbuf) != 0); > + eina_s

Re: [E-devel] [EGIT] [core/efl] master 02/04: eio: migrate efl.io.manager.ls to use Eina_Future.

2017-10-02 Thread Gustavo Sverzut Barbieri
Io_Manager_Ls_Ctx *ctx = malloc(sizeof(*ctx)); ctx->func = func; ctx->func_data = func_data; ctx->func_free = func_free; ctx->p = eina_promise_new(_efl_io_manager_ls_easy_cancel, ctx); ctx->o = efl_io_manager_ls(manager, path); efl_even

Re: [E-devel] [EGIT] [core/efl] master 02/04: eio: migrate efl.io.manager.ls to use Eina_Future.

2017-09-29 Thread Gustavo Sverzut Barbieri
inal signature, why not? Rather than exposing the callback (which as I said above is confusing), just return an EINA_VALUE_TYPE_ARRAY of EINA_VALUE_TYPE_STRING... as eina_array_count() is O(1), there is no need to expose the uint64 (count). With your new signature it just throw away the usefulness of

Re: [E-devel] [EGIT] [core/efl] master 01/04: ecore: allow other thread to write local data on a thread to increase utility.

2017-09-29 Thread Gustavo Sverzut Barbieri
urn d->data; > return NULL; > @@ -1321,15 +1326,18 @@ ecore_thread_local_data_del(Ecore_Thread *thread, > const char *key) > { > Ecore_Pthread_Worker *worker = (Ecore_Pthread_Worker *)thread; > + Eina_Bool r; > > if ((!thread) ||

Re: [E-devel] [EGIT] [core/efl] master 02/02: eio: convert Efl.Io.Manager.stat() to return Eina_Future.

2017-09-28 Thread Gustavo Sverzut Barbieri
u pset(), it will copy everything, then no need to cpy = calloc(), just put it on stack. > - end: > - efl_del(p); > + if (!eina_value_setup(, EINA_VALUE_TYPE_STRUCT)) > + goto on_error; > + if (!eina_value_pset(, ))

Re: [E-devel] [EGIT] [core/efl] master 02/02: ecore: force initialization of Efl.Io.Closer.Fd.

2017-09-25 Thread Gustavo Sverzut Barbieri
m.link/slashdot > ___ > enlightenment-devel mailing list > enlightenment-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Gustavo Sverzut Barbieri -- Mobil

Re: [E-devel] [EGIT] [core/efl] master 02/02: ecore: force initialization of Efl.Io.Closer.Fd.

2017-09-23 Thread Gustavo Sverzut Barbieri
se_on_destructor) > { > + _efl_io_closer_initialize(pd); > pd->close_on_destructor = close_on_destructor; > } > > EOLIAN static Eina_Bool > _efl_io_closer_fd_efl_io_closer_close_on_destructor_get(Eo *o > EINA_UNUSED, Efl_Io_Closer_Fd_Data *pd) >

Re: [E-devel] [EGIT] [core/efl] master 01/01: ecore: Avoid using newer check.h functions.

2017-09-22 Thread Gustavo Sverzut Barbieri
;safety check > failed: r is false"}); > //The last future is NULL, which may cause the cancel. > f = eina_future_all_array(futures); > - ck_assert_ptr_null(f); > + ck_assert_ptr_eq(f, NULL); > ecore_shutdown(); > ck_assert_int_eq(cb_called, le

Re: [E-devel] [EGIT] [core/efl] master 02/03: efl: Use Eina.Position2D for Efl.Gfx.position

2017-09-18 Thread Gustavo Sverzut Barbieri
pos = eina_position2d_move(pos, x - fd->x, y->fd->y); efl_gfx_position_set(o, pos); note: I just skimmed over the patch, didn't look every single line. -- Gustavo Sverzut Barbieri

Re: [E-devel] efl net classes... why is this not ijn a shared parent class or interface?

2017-09-16 Thread Gustavo Sverzut Barbieri
agreed and I'll fix, but need some weeks so I can get to it. On Fri, Sep 15, 2017 at 11:32 PM, Carsten Haitzler <ras...@rasterman.com> wrote: > On Fri, 15 Sep 2017 11:24:54 -0300 Gustavo Sverzut Barbieri > <barbi...@gmail.com> said: > >> because I found the number of

Re: [E-devel] efl net classes... why is this not ijn a shared parent class or interface?

2017-09-15 Thread Gustavo Sverzut Barbieri
to, ergo sum - "I code, therefore I am" -- > Carsten Haitzler - ras...@rasterman.com > > > -- > Check out the vibrant tech community on one of the world's

Re: [E-devel] [EGIT] [core/efl] master 02/03: eina: allow convertion to BLOB from Eina_File Eina_Value by mmap the file.

2017-09-14 Thread Gustavo Sverzut Barbieri
d go with some optimisation and do the trick you described. > > -- > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _

Re: [E-devel] [EGIT] [core/efl] master 01/01: eolian: default free funcs for builtin types

2017-09-14 Thread Gustavo Sverzut Barbieri
+} > +return EINA_TRUE; > + } > /* user defined */ > tpp = (Eolian_Typedecl *)eolian_type_typedecl_get(tp); > if (!tpp) > @@ -189,7 +223,7 @@ _validate_type(Eolian_Type *tp) > return _t

Re: [E-devel] [EGIT] [core/efl] master 02/02: eio: migrate efl.io.manager.open to use Eina_Future.

2017-09-13 Thread Gustavo Sverzut Barbieri
y it. (it's documented!) > - efl_event_callback_array_add(p, promise_handling(), h); > - return efl_promise_future_get(p); > + return efl_future_Eina_FutureXXX_then(obj, future); keep TODO annotations, once we add this "binding"

Re: [E-devel] [EGIT] [core/efl] master 02/03: eina: allow convertion to BLOB from Eina_File Eina_Value by mmap the file.

2017-09-13 Thread Gustavo Sverzut Barbieri
c->size = eina_file_size_get(f); > + > +eina_file_map_free((Eina_File*)f, (void*)m); do you dup the memory because of modifications? otherwise we could provide "ops" that would handle Eina_File, which we could eina_file_dup(). -- Gustavo Sverzut Barbieri --

Re: [E-devel] [EGIT] [core/efl] master 04/04: eina: add an Eina_Value helper for Eina_Rectangle.

2017-09-13 Thread Gustavo Sverzut Barbieri
unsigned int *p = ptr; *p = *tmem; return EINA_TRUE; } so your should read: const Eina_Rectangle *tmem = mem; Eina_Rectangle *p = ptr; *p = *tmem; (or in not-so-clear memcpy: memcpy(p, tmem, sizeof(Eina_Rectangle)); it would be nice to add some tests to the

Re: [E-devel] [EGIT] [core/efl] master 04/04: eina: add an Eina_Value helper for Eina_Rectangle.

2017-09-12 Thread Gustavo Sverzut Barbieri
Eina_Rectangle values". Would emphasize the value, not pointer to value. Usually we add the explicit type in eina_value_get(), eina_value_pget(), eina_value_vget(), eina_value_set(), eina_value_pset() and eina_value_vset()... so users don't do mistakes. (this would

Re: [E-devel] [EGIT] [core/efl] master 02/04: eina: add an Eina_Value helper for Eina_File.

2017-09-12 Thread Gustavo Sverzut Barbieri
;int". > /** > + * @var EINA_VALUE_TYPE_FILE > + * manages optional type. too much copy it should be "manages Eina_File*". -- Gustavo Sverzut Barbieri -- Mobile: +55 (16) 99354-9890

  1   2   3   4   5   6   7   8   9   10   >