Re: [E-devel] E CVS: libs/ewl pfritz
On Fri, 25 Jul 2008, Peter Wehrfritz wrote:
stop confusing e17
ee_window_min_max_size_set(Ewl_Window *win)
{
+int min_w, min_h, max_w, max_h;
DENTER_FUNCTION(DLEVEL_STABLE);
DCHECK_PARAM_PTR(win);
DCHECK_TYPE(win, EWL_WINDOW_TYPE);
+min_w = ewl_object_minimum_w_get(EWL_OBJECT(win));
+min_h = ewl_object_minimum_h_get(EWL_OBJECT(win));
+max_w = ewl_object_maximum_w_get(EWL_OBJECT(win));
+max_h = ewl_object_maximum_h_get(EWL_OBJECT(win));
+
+if (min_w max_w)
+min_w = max_w;
+if (min_h max_h)
+min_h = max_h;
+
ecore_x_icccm_size_pos_hints_set(INTPTR_TO_INT(win-window),
0, ECORE_X_GRAVITY_NW,
-
ewl_object_minimum_w_get(EWL_OBJECT(win)),
-
ewl_object_minimum_h_get(EWL_OBJECT(win)),
-
ewl_object_maximum_w_get(EWL_OBJECT(win)),
-
ewl_object_maximum_h_get(EWL_OBJECT(win)),
+min_w, min_h,
+max_w, max_h,
0, 0, /* base */
0, 0, /* step */
0, 0); /* aspect */
-
+
DLEAVE_FUNCTION(DLEVEL_STABLE);
}
E17 is a bit confused if you set a minimum size to a window that is
greater then the maximum size. I don't know which value should win, we
chose the maximum value. Vincent said that metacity uses the minimum value.
raster: should some tests on the max and min values be done in
ecore_x_icccm_size_pos_hints_set() or in e17 about the possibility to have
max min for height and width (like in the patch) ?
Vincent
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100url=/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: libs/ewl pfritz
libewl_la_LIBADD = $(GCOV_LIBS) @EMOTION_LIBS@ @EPSILON_LIBS@ @EFREET_LIBS@ @EDJE_LIBS@ @ECORE_LIBS@ @EVAS_LIBS@ -lm libewl_la_LDFLAGS = @create_shared_lib@ -version-info @INTERFACE_VERSION@ +libewl_la_LIBTOOLFLAGS = that line is one of the patch about not building the static lib of the modules. Do I add the other line of the patch ? Vincent - Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: libs/ewl pfritz
Enlightenment CVS wrote:
Enlightenment CVS committal
Author : pfritz
Project : e17
Module : libs/ewl
Dir : e17/libs/ewl/src/lib
Modified Files:
ewl_tree.c
Log Message:
i wonder why the compiler didn't cried
Because some of the dlist functions are cast?
# define ecore_dlist_count(list) ecore_list_count(ECORE_LIST(list))
Sebastian
===
RCS file: /cvs/e/e17/libs/ewl/src/lib/ewl_tree.c,v
retrieving revision 1.62
retrieving revision 1.63
diff -u -3 -r1.62 -r1.63
--- ewl_tree.c14 Mar 2008 20:50:29 - 1.62
+++ ewl_tree.c16 Mar 2008 22:50:02 - 1.63
@@ -1461,7 +1461,7 @@
if (w == node-handle)
DRETURN(DLEVEL_STABLE);
- if (ecore_dlist_count(c) 3)
+ if (ecore_dlist_count(c-children) 3)
{
if (node-handle VISIBLE(node-handle))
ewl_widget_hide(node-handle);
@@ -1503,7 +1503,7 @@
node = EWL_TREE_NODE(c);
- if (ecore_list_count(c-children) 2)
+ if (ecore_dlist_count(c-children) 2)
{
/* XXX what do we do if !node-handle? */
if (node-handle HIDDEN(node-handle))
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-cvs mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: libs/ewl pfritz
Sebastian Dransfeld schrieb: Enlightenment CVS wrote: Enlightenment CVS committal Author : pfritz Project : e17 Module : libs/ewl Dir : e17/libs/ewl/src/lib Modified Files: ewl_tree.c Log Message: i wonder why the compiler didn't cried Because some of the dlist functions are cast? # define ecore_dlist_count(list) ecore_list_count(ECORE_LIST(list)) Yes, I realized that and I have removed the dangerous and unnecessary casts. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E CVS: libs/ewl pfritz
You are correct, looks like we were over-eager checking our pointers.
On 10/2/07, Enlightenment CVS [EMAIL PROTECTED] wrote:
Enlightenment CVS committal
Author : pfritz
Project : e17
Module : libs/ewl
Dir : e17/libs/ewl/src/lib
Modified Files:
ewl_embed.c
Log Message:
NULL is a valid value; can anyone confirm this, please
===
RCS file: /cvs/e/e17/libs/ewl/src/lib/ewl_embed.c,v
retrieving revision 1.128
retrieving revision 1.129
diff -u -3 -r1.128 -r1.129
--- ewl_embed.c 6 Sep 2007 16:58:07 - 1.128
+++ ewl_embed.c 2 Oct 2007 10:04:24 - 1.129
@@ -1519,7 +1519,8 @@
/**
* @param embed: The embed to set the focused widget too
- * @param w: The widget to set as having focus
+ * @param w: The widget to set as having focus, NULL is valid value and
+ * signifies that no widget has the focus.
* @return Returns no value.
* @brief Set the current focused widget in the embed
*/
@@ -1528,9 +1529,7 @@
{
DENTER_FUNCTION(DLEVEL_STABLE);
DCHECK_PARAM_PTR(embed, embed);
- DCHECK_PARAM_PTR(w, w);
DCHECK_TYPE(embed, embed, EWL_EMBED_TYPE);
- DCHECK_TYPE(w, w, EWL_WIDGET_TYPE);
if (embed-last.focused (embed-last.focused != w))
ewl_callback_call(embed-last.focused,
EWL_CALLBACK_FOCUS_OUT);
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-cvs mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/enlightenment-cvs
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
