Like before, Split your patch.
Here you remove all the modularity of conf panel. This is really bad
2014-04-02 17:55 GMT+02:00 Marcel Hollerbach marcel.hollerb...@stzedn.de:
bu5hm4n pushed a commit to branch master.
Good idea to use a macro inside a macro, where the first one is never used
...
2014-04-07 10:45 GMT+02:00 Michaël Bouchaud y...@efl.so:
Like before, Split your patch.
Here you remove all the modularity of conf panel. This is really bad
2014-04-02 17:55 GMT+02:00 Marcel Hollerbach
On Mon, Apr 07, 2014 at 10:45:12AM +0200, Michaël Bouchaud wrote:
Like before, Split your patch.
Here you remove all the modularity of conf panel. This is really bad
Where do I remove the modularity ? I moved the theme and log stuff
allready to there own conf modules. (If you mean that)
you don't respect ui design, having multiple toolbar isn't a good things
for user. They go to be lost in multiple menu and can't be a good gui
(multiple context). And why you break modularity because your code don't
match the previous design made by me few weeks ago.
2014-04-07 12:59 GMT+02:00
