Re: [E-devel] [PATCH] ecore-file: don't use ecore-con if it is disabled
On Mon, Oct 12, 2009 at 12:57:51AM +0200, Vincent Torri wrote: On Mon, 12 Oct 2009, Marc Andre Tanner wrote: On Sun, Oct 11, 2009 at 11:43:50PM +0200, Vincent Torri wrote: On Sun, 11 Oct 2009, Marc Andre Tanner wrote: This makes ecore-file useable without ecore-con. better one : http://pastebin.ca/1613582 Why do you think this one is better? It clutters the source with more #ifdef's and if you add a new function you will have to remember to add the check for BUILD_ECORE_CON. because you removed API functions, which must exist, ecore_con installed or not. Ok, I see, missed that. Could someone please apply the fix patch of Vincent then? Or should I I respin + resend. Thanks, Marc -- Marc Andre Tanner http://www.brain-dump.org/ GPG key: CF7D56C0 -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore-file: don't use ecore-con if it is disabled
On Mon, 12 Oct 2009, Marc Andre Tanner wrote: Why do you think this one is better? It clutters the source with more #ifdef's and if you add a new function you will have to remember to add the check for BUILD_ECORE_CON. because you removed API functions, which must exist, ecore_con installed or not. Ok, I see, missed that. Could someone please apply the fix patch of Vincent then? Or should I I respin + resend. I'll apply it Vincent -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] [PATCH] ecore-file: don't use ecore-con if it is disabled
This makes ecore-file useable without ecore-con.
Signed-off-by: Marc Andre Tanner m...@brain-dump.org
---
src/lib/ecore_file/ecore_file_download.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/lib/ecore_file/ecore_file_download.c
b/src/lib/ecore_file/ecore_file_download.c
index a46fce9..17c43ae 100644
--- a/src/lib/ecore_file/ecore_file_download.c
+++ b/src/lib/ecore_file/ecore_file_download.c
@@ -14,6 +14,8 @@
#define ECORE_MAGIC_FILE_DOWNLOAD_JOB 0xf7427cb8
+#ifdef BUILD_ECORE_CON
+
typedef struct _Ecore_File_Download_JobEcore_File_Download_Job;
struct _Ecore_File_Download_Job
{
@@ -282,3 +284,17 @@ _ecore_file_download_abort(Ecore_File_Download_Job *job)
free(job-dst);
free(job);
}
+
+#else
+int
+ecore_file_download_init(void)
+{
+ return 1;
+}
+
+void
+ecore_file_download_shutdown(void)
+{
+
+}
+#endif /* BUILD_ECORE_CON */
--
1.6.4.3
--
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore-file: don't use ecore-con if it is disabled
On Sun, 11 Oct 2009, Marc Andre Tanner wrote:
This makes ecore-file useable without ecore-con.
better one : http://pastebin.ca/1613582
is it working for you ?
Vincent
Signed-off-by: Marc Andre Tanner m...@brain-dump.org
---
src/lib/ecore_file/ecore_file_download.c | 16
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/src/lib/ecore_file/ecore_file_download.c
b/src/lib/ecore_file/ecore_file_download.c
index a46fce9..17c43ae 100644
--- a/src/lib/ecore_file/ecore_file_download.c
+++ b/src/lib/ecore_file/ecore_file_download.c
@@ -14,6 +14,8 @@
#define ECORE_MAGIC_FILE_DOWNLOAD_JOB 0xf7427cb8
+#ifdef BUILD_ECORE_CON
+
typedef struct _Ecore_File_Download_Job Ecore_File_Download_Job;
struct _Ecore_File_Download_Job
{
@@ -282,3 +284,17 @@ _ecore_file_download_abort(Ecore_File_Download_Job *job)
free(job-dst);
free(job);
}
+
+#else
+int
+ecore_file_download_init(void)
+{
+ return 1;
+}
+
+void
+ecore_file_download_shutdown(void)
+{
+
+}
+#endif /* BUILD_ECORE_CON */
--
1.6.4.3
--
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
--
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
___
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore-file: don't use ecore-con if it is disabled
On Sun, Oct 11, 2009 at 11:43:50PM +0200, Vincent Torri wrote: On Sun, 11 Oct 2009, Marc Andre Tanner wrote: This makes ecore-file useable without ecore-con. better one : http://pastebin.ca/1613582 Why do you think this one is better? It clutters the source with more #ifdef's and if you add a new function you will have to remember to add the check for BUILD_ECORE_CON. Anyway whoever maintains the code should decide which solution he prefers. is it working for you ? No, it breaks the build on the first use of EAPI which is probably undefined because you moved the first #ifdef before the inclusion of ecore_file_private.h Marc -- Marc Andre Tanner http://www.brain-dump.org/ GPG key: CF7D56C0 -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH] ecore-file: don't use ecore-con if it is disabled
On Mon, 12 Oct 2009, Marc Andre Tanner wrote: On Sun, Oct 11, 2009 at 11:43:50PM +0200, Vincent Torri wrote: On Sun, 11 Oct 2009, Marc Andre Tanner wrote: This makes ecore-file useable without ecore-con. better one : http://pastebin.ca/1613582 Why do you think this one is better? It clutters the source with more #ifdef's and if you add a new function you will have to remember to add the check for BUILD_ECORE_CON. because you removed API functions, which must exist, ecore_con installed or not. Anyway whoever maintains the code should decide which solution he prefers. no decision, here. the API functions must be available. is it working for you ? No, it breaks the build on the first use of EAPI which is probably undefined because you moved the first #ifdef before the inclusion of ecore_file_private.h indeed. And moving it just after the inclusion of the headers. Vincent -- Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
