Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-05 Thread Daniel Juyung Seo
Dear Hyoyoung. Thanks for the revised patch. I committed that with some changes below. 1) genlist.edc - used '.' instead of '{ }' for one line property setting in edc. rel1.to_y: elm.text; rel2.to_y: elm.text; 2) test_genlist.c - used elm_win_util_standard_add(). - used genlist-flip-mode instead

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-03 Thread Hyoyoung Chang
As discussed in irc, i modified and removed draggable in flip mode. @@ -975,6 +975,8 @@ _mouse_move(void*data, if (ady 0) ady = -dy; minw /= 2; minh /= 2; + if (it-flipped) + return; if ((adx minw) || (ady minh)) { it-dragging = EINA_TRUE; What do

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-02 Thread Daniel Juyung Seo
Thanks for your patch. Everything is fine but I still see the floating item bug. And if the item is on dragging, it should not be unrealized. As far as I know, when an item is on dragging, unrealizing the item will cause unexpected problems. I don't remember what it is exactly. So I politely

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-02 Thread Hyoyoung Chang
On Fri, Mar 2, 2012 at 7:39 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Thanks for your patch. Everything is fine but I still see the floating item bug. Could you tell me how to reproduce? i tried several times but i can't see it And if the item is on dragging, it should not be

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-03-01 Thread Hyoyoung Chang
First of all, thanks for detailed review On Thu, Mar 1, 2012 at 3:01 PM, Daniel Juyung Seo seojuyu...@gmail.com wrote: Thanks Hyoyoung, overall it looks good :) I have some comments. 1. diff option Create a diff with -x -up optoin. It shows c function name for each  changes. This makes

[E-devel] [patch] elm_genlist - add item flip set/get

2012-02-29 Thread Hyoyoung Chang
Dear all. I made a patch to introduce new genlist item mode. Two public apis are added. +EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip); +EAPI Eina_Bool elm_genlist_item_flip_get(Elm_Object_Item *it); It provides on-the-flying item change. It works like that a new item

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-02-29 Thread Elevate Efl
Const for param? On Feb 29, 2012 9:19 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: Dear all. I made a patch to introduce new genlist item mode. Two public apis are added. +EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip); +EAPI Eina_Bool