Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-10-11 Thread Gustavo Sverzut Barbieri
On Mon, Oct 11, 2010 at 12:54 PM, Leandro Pereira wrote: > On Sun, Oct 10, 2010 at 8:54 PM, Enlightenment SVN > wrote: >>  elm_gengrid_item_prev_get() and elm_gengrid_first_item_get() and >> elm_gengrid_last_item_get()... so we don't expose elm_gengrid_items_get(). >> > > Shouldn't it be elm_gen

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-10-11 Thread Leandro Pereira
On Sun, Oct 10, 2010 at 8:54 PM, Enlightenment SVN wrote: >  elm_gengrid_item_prev_get() and elm_gengrid_first_item_get() and > elm_gengrid_last_item_get()... so we don't expose elm_gengrid_items_get(). > Shouldn't it be elm_gengrid_item_first_get()? --   Leandro -

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-10-10 Thread Gustavo Sverzut Barbieri
On Sun, Oct 10, 2010 at 9:04 PM, Rafael Fonseca wrote: >> +   while (wd->selected) >> +     elm_genlist_item_selected_set(wd->selected->data, EINA_FALSE); >> > >> +   while (wd->selected) >> +     elm_genlist_item_selected_set(wd->selected, EINA_FALSE); >> when you find such things, commit the fi

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-10-10 Thread Rafael Fonseca
> + while (wd->selected) > + elm_genlist_item_selected_set(wd->selected->data, EINA_FALSE); > > + while (wd->selected) > + elm_genlist_item_selected_set(wd->selected, EINA_FALSE); > k-s, you've missed ->data here. -- Rafael Fonseca ProFUSION embedded systems http://www.profusion.mob

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-10-10 Thread Gustavo Sverzut Barbieri
On Sun, Oct 10, 2010 at 12:53 PM, Rafael Fonseca wrote: > On 10/09/2010 04:07 PM, Enlightenment SVN wrote: >> Log: >>    elm_gengrid_item_update() >> >>    also missing are elm_gengrid_item_prepend(), >>    elm_gengrid_item_insert_before() and elm_gengrid_item_insert_after()! >>    I can't do them

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-10-10 Thread Rafael Fonseca
On 10/09/2010 04:07 PM, Enlightenment SVN wrote: > Log: >elm_gengrid_item_update() > >also missing are elm_gengrid_item_prepend(), >elm_gengrid_item_insert_before() and elm_gengrid_item_insert_after()! >I can't do them right now, so any help is appreciated. > I've added the functio

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-09-26 Thread Christopher Michael
Ahh, yea that makes sense. Thanks for the fix !! :) Boy, I am just racking up the spankings lately :/ dh On 09/26/2010 11:28 AM, Enlightenment SVN wrote: > Log: >const! bad devilhorns... > > Author: barbieri > Date: 2010-09-26 08:28:04 -0700 (Sun, 26 Sep 2010) > New Revision: 5

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-09-09 Thread Brett Nash
I'm sort of changing the stuff in elm_photo with a number of FIXMEs and hard coded numbers linking in cnp too. Maybe -Wno-unused-parameter? Regards, nash On Thu, 09 Sep 2010 12:39 -0700, "Enlightenment SVN" wrote: > Log: > some -Wall -Wextra warning cleanups. > > elm_cnp_helper

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-07-14 Thread Atton Jonathan
the slideshow bug with only one slide haha I will fix i. 2010/7/14 Enlightenment SVN > Log: > fix widgets that were forcing style to be "default". > > Author: barbieri > Date: 2010-07-14 14:14:52 -0700 (Wed, 14 Jul 2010) > New Revision: 50257 > > Modified: > trunk/TMP/st/elementa

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-03-13 Thread Gustavo Sverzut Barbieri
On Sat, Mar 13, 2010 at 9:46 PM, Carsten Haitzler wrote: > On Sat, 13 Mar 2010 18:16:17 -0300 Gustavo Sverzut Barbieri > said: > >> On Sat, Mar 13, 2010 at 6:01 PM, Enlightenment SVN >> wrote: >> > Log: >> >  Use eina_stringshare_replace to avoid crashes. >> >> And a special note, particularly t

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-03-13 Thread The Rasterman
On Sat, 13 Mar 2010 18:16:17 -0300 Gustavo Sverzut Barbieri said: > On Sat, Mar 13, 2010 at 6:01 PM, Enlightenment SVN > wrote: > > Log: > >  Use eina_stringshare_replace to avoid crashes. > > And a special note, particularly to Raster that takes some time to get > used to new APIs ;-) > > the

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2010-03-13 Thread Gustavo Sverzut Barbieri
On Sat, Mar 13, 2010 at 6:01 PM, Enlightenment SVN wrote: > Log: >  Use eina_stringshare_replace to avoid crashes. And a special note, particularly to Raster that takes some time to get used to new APIs ;-) the problem with the old approach is that the reference count can drop to zero, so you mu

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2009-12-09 Thread The Rasterman
On Wed, 9 Dec 2009 18:00:38 -0200 Luis Felipe Strano Moraes said: thanks! :) in svn! > hm, actually this patch :P > > --lf > > > On Wed, Dec 9, 2009 at 5:49 PM, Luis Felipe Strano Moraes > wrote: > > Gustavo, > > > > the macro you created ELM_LIST_ITEM_CHECK_DELETED_RETURN didn't actually >

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2009-12-09 Thread Luis Felipe Strano Moraes
hm, actually this patch :P --lf On Wed, Dec 9, 2009 at 5:49 PM, Luis Felipe Strano Moraes wrote: > Gustavo, > > the macro you created ELM_LIST_ITEM_CHECK_DELETED_RETURN didn't actually check > for NULL (though the message did imply that). The attached patch fixes > that (and fixes about > 10 or

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2009-12-09 Thread Luis Felipe Strano Moraes
Gustavo, the macro you created ELM_LIST_ITEM_CHECK_DELETED_RETURN didn't actually check for NULL (though the message did imply that). The attached patch fixes that (and fixes about 10 or more null pointer dereferences from the latest clang tests). --lf On Wed, Dec 2, 2009 at 4:59 PM, Enlightenm

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2009-11-13 Thread Vincent Torri
On Fri, 13 Nov 2009, Gustavo Sverzut Barbieri wrote: On Fri, Nov 13, 2009 at 8:52 PM, Vincent Torri wrote: On Fri, 13 Nov 2009, Enlightenment SVN wrote: Log:  fix valgrind reported problems.  GENERAL WARNING:  do NOT delete sub-objects (elm_widget_sub_object_add) or resize object  (elm

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2009-11-13 Thread Gustavo Sverzut Barbieri
On Fri, Nov 13, 2009 at 8:52 PM, Vincent Torri wrote: > > > On Fri, 13 Nov 2009, Enlightenment SVN wrote: > >> Log: >>  fix valgrind reported problems. >> >>  GENERAL WARNING: >> >>  do NOT delete sub-objects (elm_widget_sub_object_add) or resize object >>  (elm_widget_resize_object_set) from del_

Re: [E-devel] E SVN: barbieri trunk/TMP/st/elementary/src/lib

2009-11-13 Thread Vincent Torri
On Fri, 13 Nov 2009, Enlightenment SVN wrote: > Log: > fix valgrind reported problems. > > GENERAL WARNING: > > do NOT delete sub-objects (elm_widget_sub_object_add) or resize object > (elm_widget_resize_object_set) from del_hook()!! These are deleted > automatically before this function is