Re: [E-devel] Patch for evas (eina_log related)

2009-10-26 Thread Mike Frysinger
On Thursday 22 October 2009 09:23:13 Mathieu Taillefumier wrote: It seems that my previous email did not pass through the mailing list. herewith a patch for evas that modify the previous patch I send weeks ago. The changes are listed below - Conversion of the remaining printf to eina_log in

Re: [E-devel] Patch for evas (eina_log related)

2009-10-22 Thread Cedric BAIL
On Thu, Oct 22, 2009 at 3:23 PM, Mathieu Taillefumier mathieu.taillefum...@free.fr wrote: the only thing that is problematic (maybe) is the initialization of the log domains for the engines. It is located in the module_open() (module_close() for destroying it) function. Why do you make this

Re: [E-devel] Patch for evas (eina_log related)

2009-10-22 Thread Cedric BAIL
On Thu, Oct 22, 2009 at 4:04 PM, Cedric BAIL cedric.b...@free.fr wrote: On Thu, Oct 22, 2009 at 3:23 PM, Mathieu Taillefumier mathieu.taillefum...@free.fr wrote: the only thing that is problematic (maybe) is the initialization of the log domains for the engines. It is located in the

Re: [E-devel] Patch for evas (eina_log related)

2009-10-22 Thread Mathieu Taillefumier
Hi, Why do you make this statement ? It's sound good to me to register the domain on module open and unregister on module close. Well, let us say that the eng_info function could have been a good place. I am reviewing your patch, right now. I didn't have time previoulsy to do so.