[EGIT] [legacy/imlib2] master 01/01: XPM loader: Correct signature check (avoid accessing unset data)

[Kim Woelders]

kwo pushed a commit to branch master.

http://git.enlightenment.org/legacy/imlib2.git/commit/?id=9b0ab1269787709692abcd423e86ab61130443c8

commit 9b0ab1269787709692abcd423e86ab61130443c8
Author: Kim Woelders <k...@woelders.dk>
Date:   Fri Nov 22 17:07:22 2019 +0100

    XPM loader: Correct signature check (avoid accessing unset data)
---
 src/modules/loaders/loader_xpm.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/modules/loaders/loader_xpm.c b/src/modules/loaders/loader_xpm.c
index df23181..a732ac7 100644
--- a/src/modules/loaders/loader_xpm.c
+++ b/src/modules/loaders/loader_xpm.c
@@ -125,10 +125,11 @@ load(ImlibImage * im, ImlibProgressFunction progress, 
char progress_granularity,
    if (!f)
       return 0;
 
-   if (fread(s, 1, sizeof(s) - 1, f) < 9)
+   len = fread(s, 1, sizeof(s) - 1, f);
+   if (len < 9)
       goto quit;
 
-   s[sizeof(s) - 1] = '\0';
+   s[len] = '\0';
    if (!strstr(s, " XPM */"))
       goto quit;
 

--