Re: [E-devel] [PATCH 2/2] Zero is a valid fd value

2011-01-24 Thread Tom Hacohen
On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log messages in svn and maybe even use tags like [REMOVED-DEPRECATED] or stuff like that and then it

Re: [E-devel] [PATCH 2/2] Zero is a valid fd value

2011-01-24 Thread Mike Blumenkrantz
On Mon, 24 Jan 2011 10:16:37 + Tom Hacohen tom.haco...@partner.samsung.com wrote: On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log

Re: [E-devel] [PATCH 2/2] Zero is a valid fd value

2011-01-23 Thread Mike Blumenkrantz
On Mon, 24 Jan 2011 10:58:26 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: From: Mike McCormack mj.mccorm...@samsung.com To: enlightenment-devel@lists.sourceforge.net Subject: [E-devel] [PATCH 2/2] Zero is a valid fd value Date: Mon, 24 Jan 2011 10:58:26 +0900 User-Agent: Mozilla/5.0

Re: [E-devel] [PATCH 2/2] Zero is a valid fd value

2011-01-23 Thread Vincent Torri
On Mon, 24 Jan 2011, Mike McCormack wrote: ecore_config code may end up closing stdin, due to assuming 0 is a valid fd. I know this code is deprecated, and it's being kept around for reference. Either: A) this bug should still be fixed so bad code is not copied elsewhere OR B)