Re: [E-devel] [PATCH 2/2] Zero is a valid fd value
On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log messages in svn and maybe even use tags like [REMOVED-DEPRECATED] or stuff like that and then it will be easy to find the wanted revision. We need to start doing that anyway, so that's a good time to start :) -- Tom. -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH 2/2] Zero is a valid fd value
On Mon, 24 Jan 2011 10:16:37 + Tom Hacohen tom.haco...@partner.samsung.com wrote: On Mon, 2011-01-24 at 08:49 +0100, Vincent Torri wrote: imho, B) with a file in it saying at which revision it has been deleted Or better yet, start writing sane *descriptive* and *searchable* log messages in svn balderdash. -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH 2/2] Zero is a valid fd value
On Mon, 24 Jan 2011 10:58:26 +0900 Mike McCormack mj.mccorm...@samsung.com wrote: From: Mike McCormack mj.mccorm...@samsung.com To: enlightenment-devel@lists.sourceforge.net Subject: [E-devel] [PATCH 2/2] Zero is a valid fd value Date: Mon, 24 Jan 2011 10:58:26 +0900 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.15) Gecko/20101027 Thunderbird/3.0.10 ecore_config code may end up closing stdin, due to assuming 0 is a valid fd. I know this code is deprecated, and it's being kept around for reference. Either: A) this bug should still be fixed so bad code is not copied elsewhere OR B) ecore_config should be deleted so bad code is not copied elsewhere thanks, Mike in -- Mike Blumenkrantz Zentific: NULL pointer dereferences now 50% off! -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [PATCH 2/2] Zero is a valid fd value
On Mon, 24 Jan 2011, Mike McCormack wrote: ecore_config code may end up closing stdin, due to assuming 0 is a valid fd. I know this code is deprecated, and it's being kept around for reference. Either: A) this bug should still be fixed so bad code is not copied elsewhere OR B) ecore_config should be deleted so bad code is not copied elsewhere imho, B) with a file in it saying at which revision it has been deleted Vincent -- Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
