[equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Doug Schaefer
Hey gang, I’m aware of the work Tom S has done with class loading hooks to get JavaFX classes to load. I’m just wondering if there are easier approaches we could be following, something we can put in the JavaSE-1.8.profile file or somewhere else so that we can make this a more data driven

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Alex Blewitt
Can you not just install a fragment to the system bundle that exports the javafx packages? Sent from my iPhone 5 On 25 Feb 2014, at 16:15, Doug Schaefer dschae...@qnx.com wrote: Hey gang, I’m aware of the work Tom S has done with class loading hooks to get JavaFX classes to load. I’m

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Doug Schaefer
a) My focus is actually Mars, Luna for now, not Kepler. b) I don¹t care much about swt-embedding, I¹m going the other way. c) Agreed. A FX specific profile makes sense. That requires another property to ensure it gets loaded, but better than the magic extensions property. But I haven¹t had much

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Thomas Watson
Sorry, I have lost track of what the framework extension is doing for JavaFX. Tom Schindl, perhaps you have a link for a quick refresher? Adding the packages to org.osgi.framework.system.packages is not enough because that adds the packages as exported by the system bundle. For that to work

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Thomas Watson
We would not do this in the framework delegation (BundleLoader) by default because it would expose classes to bundles which have no defined dependencies on the package (e.g Import-Package: javafx.*). Bundles should declare their dependencies on the packages they require to function. Providing

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Doug Schaefer
I think I get it. Ideally, we'd have a bundle that exports the packages. That would be easiest to manage. But is that possible with a jar file that’s on the ext path and not in the bundle? I think it’s pretty clear licensing of the Oracle JRE would prevent us from copying that jar file anywhere

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Thomas Watson
Right, I think it is both a licensing issue and, from what I recall, some technical issues as to why javafx must be loaded by the extension class loader instead of some higher up application class loader (or bundle loader). I think one of the things Tom S. javafx framework extension is doing is

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Doug Schaefer
I’m trying to avoid too much magic which is why I’m not sold on Tom S’s approach. Interesting enough adding -Dorg.osgi.framework.bundle.parent=ext worked. Not ideal as you mention, but gets us going until JavaFX gets onto the boot classpath in Java 9, or we come up with a better idea. Thanks!

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Tom Schindl
This is not an option how would you make this work when installing through p2 you need to modify the launch parameters of the framework which is fine a single vendor env but not in a multi-vendor one like Eclipse. Other things: * repackage is not possible (legally) * repackage is not feasable

Re: [equinox-dev] Simpler JavaFX class loading

2014-02-25 Thread Doug Schaefer
I change the contents of the eclipse.ini from p2.inf files all the time. It would be easy to add this option. Also, we're going to need a separate launcher anyway to avoid loading the native UI. It could also be done there. I’m just trying to keep things simple so we can do Eclipse SDK CBI builds