Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-25 Thread Martin Maechler
> Vitalie Spinu > on Wed, 25 Apr 2018 11:16:57 +0200 writes: > I don't see this in 3.4.4 nor in Devel. >>> On Wed, Apr 25 2018 10:55, Lionel Henry wrote: >> Doesn't setting `options(deparse.max.lines = NA)` do the trick? >> Martin fixed this for R 3.5 btw. > Fi

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-25 Thread Lionel Henry
I stand corrected, it's not in 3.5 but in r-devel: https://github.com/lionel-/r-source/commit/284ffb8d9a > On 25 avr. 2018, at 11:16, Vitalie Spinu wrote: > > > I don't see this in 3.4.4 nor in Devel. > >>> On Wed, Apr 25 2018 10:55, Lionel Henry wrote: > >> Doesn't setting `options(depars

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-25 Thread Vitalie Spinu
I don't see this in 3.4.4 nor in Devel. >> On Wed, Apr 25 2018 10:55, Lionel Henry wrote: > Doesn't setting `options(deparse.max.lines = NA)` do the trick? > Martin fixed this for R 3.5 btw. Fixed in what sense? `dump` should not be abiding that option. It has it's own control with .deparseOpt

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-25 Thread Vitalie Spinu
There are two things that could have gone wrong: 1) ess-dump-object-into-edit-buffer doesn't re-dump the object if the temporary file already exists. For me this file is "/tmp/vspinu.bringLibrary.R". It could be that long time ago you edited that file and truncated it unintention

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-25 Thread Lionel Henry
Doesn't setting `options(deparse.max.lines = NA)` do the trick? Martin fixed this for R 3.5 btw. Also see https://github.com/emacs-ess/ESS/issues/516 Lionel > On 25 avr. 2018, at 10:49, Vitalie Spinu wrote: > > > I don't see this either. I use ess-dump-object-into-edit-buffer occasionally >

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-25 Thread Vitalie Spinu
I don't see this either. I use ess-dump-object-into-edit-buffer occasionally and often with long functions. Hard to say. Might be R version or indeed a glitch in ESS which was fixed shortly. I will have a look at the dump code, maybe I can spot something. Vitalie >> On Tue, Apr 24 2018 22:38,

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-24 Thread Ista Zahn
On Tue, Apr 24, 2018 at 8:34 PM, Patrick Connolly wrote: > On Tue, 24-Apr-2018 at 08:20AM -0400, Ista Zahn wrote: > > |> On Tue, Apr 24, 2018 at 4:13 AM, Patrick Connolly > |> wrote: > |> > On Mon, 16-Apr-2018 at 09:02AM -0400, Ista Zahn wrote: > |> > > |> > [...] > |> > > |> > |> This suggests t

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-24 Thread Patrick Connolly
On Tue, 24-Apr-2018 at 08:20AM -0400, Ista Zahn wrote: |> On Tue, Apr 24, 2018 at 4:13 AM, Patrick Connolly |> wrote: |> > On Mon, 16-Apr-2018 at 09:02AM -0400, Ista Zahn wrote: |> > |> > [...] |> > |> > |> This suggests to me that you did _not_ start with emacs -q, so indeed |> > |> you should s

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-24 Thread Ista Zahn
On Tue, Apr 24, 2018 at 4:13 AM, Patrick Connolly wrote: > On Mon, 16-Apr-2018 at 09:02AM -0400, Ista Zahn wrote: > > [...] > > |> This suggests to me that you did _not_ start with emacs -q, so indeed > |> you should start looking at your configuration to see where the > |> problem is. Did you try

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-24 Thread Patrick Connolly
On Mon, 16-Apr-2018 at 09:02AM -0400, Ista Zahn wrote: [...] |> This suggests to me that you did _not_ start with emacs -q, so indeed |> you should start looking at your configuration to see where the |> problem is. Did you try commenting out the 'ess-source-directory' |> setting to see if that i

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-16 Thread Ista Zahn
Hi Patrick, On Mon, Apr 16, 2018 at 5:10 AM, Patrick Connolly wrote: > This is about the shortest I can get that shows what happens: Just > what the example function does is not material to my question. Can you reproduce this following only these instructions starting from 'emacs -q'? I cannot,

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-16 Thread Patrick Connolly
This is about the shortest I can get that shows what happens: Just what the example function does is not material to my question. ## from the bash prompt mkdir ~/Temp/First cd ~/Temp/First emacs & # start R using M-x R ## within the *R* buffer make a short function bringLibrary <- function(la

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-14 Thread Patrick Connolly
G'day Ista, I'm having trouble getting an example small enough to show. Some work properly and others (usually longer ones) don't. Can't imagine what makes the difference. I'll be at the machine where I normally work and there I'll find a small example. Thanks for looking at my problem. best

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Ista Zahn
Hi Patrick, I don't use ess-dump-object-into-edit-buffer, so I'm not sure what exactly you expect it to do. A specific example would help, i.e., a description of exactly what you did, exactly what happened, and how what happened differed from you expectation. For example, if I start R with 'M-x R

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Patrick Connolly
On 04/12/2018 10:00 PM, Martin Maechler wrote: > This is completely undocumented inside R apart from the NEWS > entry, and that (missing docu) is indeed a bug... > and I agree that dput() and dump() should possibly be changed > by getting a version of that as explicit argument. > > Still wonde

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Patrick Connolly
Thanks Ista. The result is not the same, but it's equally useless.  It produces almost the same as typing the name of the function and pressing . That is to say, unless the function has been edited in the working directory, it lists all the code without any of the comments almost in the form o

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Ista Zahn
On Thu, Apr 12, 2018 at 3:56 AM, Patrick Connolly wrote: > Thanks for the response, however, if I start Emacs with a '-q' none of > my ~/.emacs file is read, so Emacs doesn't know how to start R. More > to the point, I'm unable to run R within Emacs any other way. The usual recipe is to start wi

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Martin Maechler
> Lionel Henry > on Thu, 12 Apr 2018 10:52:29 +0200 writes: > I think we should adjust the max lines before calling > dump(). In the mean time you can do it manually: > options(deparse.max.lines = NA) > The reason for the change of behaviour is this change in

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Lionel Henry
We now have continuous integration with Travis btw. I'll look into adding r-devel to the test set to catch this kind of errors before new R releases. Though we still need to significantly improve the test coverage of ESS... > On 12 avr. 2018, at 10:52, Lionel Henry wrote: > > I think we should

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Lionel Henry
I think we should adjust the max lines before calling dump(). In the mean time you can do it manually: options(deparse.max.lines = NA) The reason for the change of behaviour is this change in R: https://github.com/wch/r-source/commit/201ddbd16e8f410c469dcd4695471c0bedd65dd5 dput() and

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-12 Thread Patrick Connolly
Thanks for the response, however, if I start Emacs with a '-q' none of my ~/.emacs file is read, so Emacs doesn't know how to start R. More to the point, I'm unable to run R within Emacs any other way. I gather there is a way of applying individual lines of the .emacs files but a bear with a smal

Re: [ESS] ess-dump-object-into-edit-buffer

2018-04-11 Thread Ista Zahn
I can't reproduce it with the latest ESS from melpa. Can you give reproduction steps starting with emacs -q ? --Ista On Wed, Apr 11, 2018 at 4:58 AM, Patrick Connolly wrote: > For a long time I used to be able to use > > ess-dump-object-into-edit-buffer > > to create a buffer that could be use