[Ethereal-dev] bad buffer bound in packet-cpha.c

2003-12-04 Thread Anil Madhavapeddy
Noticed this in Ethereal-0.9.11 -anil --- packet-cpha.c.orig Tue Apr 15 16:51:02 2003 +++ packet-cpha.c Tue Apr 15 16:51:40 2003 @@ -237,7 +237,7 @@ dissect_cpha(tvbuff_t *tvb, packet_info hdr.filler = g_ntohs(hdr.filler); opcode = g_ntohs(hdr.opcode); - snprintf(info,50,"CPHAv%d:

Re: [Ethereal-dev] bad buffer bound in packet-cpha.c

2003-12-03 Thread Guy Harris
On Tue, Apr 15, 2003 at 08:28:46PM +0100, Anil Madhavapeddy wrote: > Noticed this in Ethereal-0.9.11 ...and then, while looking at the fix, I noticed that there wasn't any need to use "snprintf()" at all: *** packet-cpha.c 31 Jan 2003 03:17:45 - 1.5 --- packet-cpha.c 15 Apr 2