Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-09 Thread Guy Harris
On Tue, Dec 02, 2003 at 03:20:25PM -0800, Guy Harris wrote: > Mainly called from "cell_size_request()", which is, in turn, mainly > called from "gtk_clist_optimal_column_width()", called mainly from > "gtk_clist_set_column_auto_resize()". Not automatically sizing the > columns might be the righ

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-04 Thread Guy Harris
On Dec 2, 2003, at 2:30 PM, didier wrote: Guy Harris wrote: On Dec 1, 2003, at 2:03 AM, didier wrote: Attached a patch for columns stuff. - COL_INFO is the most used column but it was the last one in a linear search array. - Most of the time columns are displayed only once. Where are the "col_fir

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-04 Thread Ian Schorr
Mainly called from "cell_size_request()", which is, in turn, mainly called from "gtk_clist_optimal_column_width()", called mainly from "gtk_clist_set_column_auto_resize()". Not automatically sizing the columns might be the right answer here. We talked about getting rid of the auto-resize a wh

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-04 Thread didier
Richard Sharpe wrote: Hi, Attached is a profile run with the latest version of Ethereal against the 13MB file I used the last couple of times. Here are the highlights: Attached a patch for columns stuff. - COL_INFO is the most used column but it was the last one in a linear search array. - Most

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-03 Thread didier
Richard Sharpe wrote: Hi, Attached is a profile run with the latest version of Ethereal against the 13MB file I used the last couple of times. Here are the highlights: Attached a patch for columns stuff. - COL_INFO is the most used column but it was the last one in a linear search array. - Mos

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-03 Thread Ian Schorr
Mainly called from "cell_size_request()", which is, in turn, mainly called from "gtk_clist_optimal_column_width()", called mainly from "gtk_clist_set_column_auto_resize()". Not automatically sizing the columns might be the right answer here. We talked about getting rid of the auto-resize a wh

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-02 Thread Guy Harris
On Nov 30, 2003, at 3:24 PM, Richard Sharpe wrote: Here are the highlights: Each sample counts as 0.01 seconds. % cumulative self self total time seconds secondscalls s/call s/call name ... 3.60 0.29 0.05 150010 0.00 0.00 get_cell_style

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-02 Thread Guy Harris
On Dec 2, 2003, at 2:30 PM, didier wrote: Guy Harris wrote: On Dec 1, 2003, at 2:03 AM, didier wrote: Attached a patch for columns stuff. - COL_INFO is the most used column but it was the last one in a linear search array. - Most of the time columns are displayed only once. Where are the "col_fir

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-02 Thread didier
Guy Harris wrote: On Dec 1, 2003, at 2:03 AM, didier wrote: Attached a patch for columns stuff. - COL_INFO is the most used column but it was the last one in a linear search array. - Most of the time columns are displayed only once. Where are the "col_first" and "col_last" arrays set? I assume

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-02 Thread Guy Harris
On Dec 1, 2003, at 2:03 AM, didier wrote: Attached a patch for columns stuff. - COL_INFO is the most used column but it was the last one in a linear search array. - Most of the time columns are displayed only once. Where are the "col_first" and "col_last" arrays set? I assume they represent the

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-02 Thread Guy Harris
On Dec 2, 2003, at 12:42 PM, didier wrote: Attached a patch for field_info fvalue_t *value to fvalue_t fvalue Checked in. It appears to have sped things up by about 2%, although there was a fair bit of user-mode CPU time difference between three runs of the *same* version of Ethereal on the *s

Re: [Ethereal-dev] Latest Ethereal profiling data ...

2003-12-02 Thread didier
Guy Harris wrote: On Mon, Dec 01, 2003 at 05:43:46PM +, didier wrote: BTW, why do we use a pointer for value in field_info (proto.h) and in proto_node? fvalue_t*value; } field_info; Probably because that was the most straightforward way to deal with objects o