[Evolution-hackers] Some minor Camel API breaks

2012-08-13 Thread Matthew Barnes
Just for the record, I made a few API changes to Camel over the weekend. The changes help increase Camel's thread-safety. One lesson I learned during the account-mgmt work is when returning a pointer to a reference counted object in a multi-threaded environment, it's better to return a new

Re: [Evolution-hackers] Some minor Camel API breaks

2012-08-13 Thread Matthew Barnes
On Mon, 2012-08-13 at 19:00 +0100, Philip Withnall wrote: This is all great work! Just a point to note: Telepathy uses the convention of calling refcounting getters ‘_dup_’ (e.g. “camel_session_dup_service()”) rather than ‘_ref_’. This seems better (imo) because ‘ref’ could get confused with a

Re: [Evolution-hackers] Some minor Camel API breaks

2012-08-13 Thread Philip Withnall
On Mon, 2012-08-13 at 14:56 -0400, Matthew Barnes wrote: On Mon, 2012-08-13 at 19:00 +0100, Philip Withnall wrote: This is all great work! Just a point to note: Telepathy uses the convention of calling refcounting getters ‘_dup_’ (e.g. “camel_session_dup_service()”) rather than ‘_ref_’.

Re: [Evolution-hackers] Some minor Camel API breaks

2012-08-13 Thread Matthew Barnes
On Mon, 2012-08-13 at 20:35 +0100, Philip Withnall wrote: Is this documented anywhere (perhaps in an introductory section in the EDS docs)? Does the mailing list count? ;) Good idea though. I guess I could document it in to the introductory parts of libedataserver and libebackend for