Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Tor Lillqvist
må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin:
 From: Pavel Roskin [EMAIL PROTECTED]

 --- a/widgets/misc/e-icon-entry.c
 +++ b/widgets/misc/e-icon-entry.c
 @@ -39,6 +39,8 @@ #include e-icon-entry.h
  #include gtk/gtkentry.h
  #include gtk/gtkbox.h
  #include gtk/gtkhbox.h
 +#include gtk/gtkeventbox.h
 +#include gtk/gtkimage.h

Isn't the correct thing here to just include gtk/gtk.h and not attempt
to hand-pick individual gtk headers?

--tml


___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] Help needed with CamelFolderInfo to CamelFolder

2006-08-15 Thread Smartuser
Hello,

I've to add a new message to a folder, but the only things i have are 
CamelStore and the CamelFolderInfo of the folder.
With test-full_name for example i can get the folder name.

That looks oke to me. 
I also look it op in my priv-id_hash. So the folder exists.

But now there already is a CamelFolder with a summary 
and i like to add a new message to it. Is that possible?
Or how can i convert CamelFolderInfo to a CamelFolder?

Thank you in advance.

Kind Regards
Serjan Pruis
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] URL colour in Mail

2006-08-15 Thread Harry Lu
From gtkhtml/src/htmlcolorset.c's html_colorset_set_style(), it seems
should be link_color instead of link-color.

Calum, 
What API could we use to get the gtk theme setings for URL colors?

Thanks,
Harry


On Tue, 2006-08-15 at 12:38 +0100, Calum Benson wrote:
 On Sat, 2006-08-12 at 10:01 +0200, Igor Jagec wrote:
  Hi there!
  
  Is it possible to change URL colour? It is set to #FF by default,
  and I want it to be #006600. I played a bit with gconf editor and my
  ~/.evolution/mail/config/gtkrc-mail-fonts and what ever I did, It didn't
  help.
 
 There's a gtk theme setting for URL colours, but whether Evo respects it
 or not I don't know.  I guess you'd need to add something like:
 
 GtkHTML::link-color = #006600
 
 to your ~/.gtkrc-2.0 file to try it (create the file if it doesn't
 exist).
 
 Cheeri,
 Calum.
 

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Help needed with CamelFolderInfo to CamelFolder

2006-08-15 Thread Smartuser
Hi,

Do I got this right?

It looks like 

folder = camel_store_get_folder(store, lpParentInfo-full_name, 0, ex); 

does the job.

On Tuesday 15 August 2006 12:44, Smartuser wrote:
 Hello,

 I've to add a new message to a folder, but the only things i have are
 CamelStore and the CamelFolderInfo of the folder.
 With test-full_name for example i can get the folder name.

 That looks oke to me.
 I also look it op in my priv-id_hash. So the folder exists.

 But now there already is a CamelFolder with a summary
 and i like to add a new message to it. Is that possible?
 Or how can i convert CamelFolderInfo to a CamelFolder?

 Thank you in advance.

 Kind Regards
 Serjan Pruis
 ___
 Evolution-hackers mailing list
 Evolution-hackers@gnome.org
 http://mail.gnome.org/mailman/listinfo/evolution-hackers
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] URL colour in Mail

2006-08-15 Thread Calum Benson
On Tue, 2006-08-15 at 20:09 +0800, Harry Lu wrote:
 From gtkhtml/src/htmlcolorset.c's html_colorset_set_style(), it seems
 should be link_color instead of link-color.
 
 Calum, 
   What API could we use to get the gtk theme setings for URL colors?

Not sure, I'm not exactly a programmer :)  But presumably the same API
you'd use to get/set any other style property:
http://developer.gnome.org/doc/API/2.0/gtk/GtkWidget.html#GtkWidget--link-color

Cheeri,
Calum.

-- 
CALUM BENSON, Usability Engineer   Sun Microsystems Ireland
mailto:[EMAIL PROTECTED]Java Desktop System Group
http://ie.sun.com  +353 1 819 9771

Any opinions are personal and not necessarily those of Sun Microsystems

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Jeffrey Stedfast
the original idea was to speed up compile time

On Tue, 2006-08-15 at 08:50 +, Tor Lillqvist wrote:
 må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin:
  From: Pavel Roskin [EMAIL PROTECTED]
 
  --- a/widgets/misc/e-icon-entry.c
  +++ b/widgets/misc/e-icon-entry.c
  @@ -39,6 +39,8 @@ #include e-icon-entry.h
   #include gtk/gtkentry.h
   #include gtk/gtkbox.h
   #include gtk/gtkhbox.h
  +#include gtk/gtkeventbox.h
  +#include gtk/gtkimage.h
 
 Isn't the correct thing here to just include gtk/gtk.h and not attempt
 to hand-pick individual gtk headers?
 
 --tml
 
 
 ___
 Evolution-hackers mailing list
 Evolution-hackers@gnome.org
 http://mail.gnome.org/mailman/listinfo/evolution-hackers
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
[EMAIL PROTECTED]  - www.novell.com

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Pavel Roskin
Hello, Tor!

On Tue, 2006-08-15 at 08:50 +, Tor Lillqvist wrote:
 må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin:
  +#include gtk/gtkeventbox.h
  +#include gtk/gtkimage.h
 
 Isn't the correct thing here to just include gtk/gtk.h and not attempt
 to hand-pick individual gtk headers?

Being quite new to all this, I'm trying to follow the existing style
rather than fix warnings and do The Right Thing at once.

It should be easy (for anyone knowing Perl, that is) to replace
gtk/gtk*.h with gtk/gtk.h across the board and then remove duplicate
headers.

-- 
Regards,
Pavel Roskin


___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Tor Lillqvist
ti 2006-08-15 klockan 10:18 -0400 skrev Jeffrey Stedfast:
 the original idea was to speed up compile time

Sure, I can guess that, but is it worth it? Some timings would be
interesting, but on the other hand, it can't be worth spending time on
doing such timings...

--tml


___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Jeffrey Stedfast
Zucchi did timings a while back and found it to be worth it *shrug*

I don't have the timings on me tho, so I have no idea what kind of
difference it made.

On Tue, 2006-08-15 at 15:20 +, Tor Lillqvist wrote:
 ti 2006-08-15 klockan 10:18 -0400 skrev Jeffrey Stedfast:
  the original idea was to speed up compile time
 
 Sure, I can guess that, but is it worth it? Some timings would be
 interesting, but on the other hand, it can't be worth spending time on
 doing such timings...
 
 --tml
 
 
 ___
 Evolution-hackers mailing list
 Evolution-hackers@gnome.org
 http://mail.gnome.org/mailman/listinfo/evolution-hackers
-- 
Jeffrey Stedfast
Evolution Hacker - Novell, Inc.
[EMAIL PROTECTED]  - www.novell.com

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Matthew Barnes
On Tue, 2006-08-15 at 11:16 -0400, Jeffrey Stedfast wrote:
 Zucchi did timings a while back and found it to be worth it *shrug*
 
 I don't have the timings on me tho, so I have no idea what kind of
 difference it made.

If only partial APIs are going to be #include'd in Evolution source
files, then can I ask that the -Werror-implicit-function-declaration
flag be used for compilation?  That would reduce the need for future
patches like the one Pavel is proposing here.

Matthew Barnes

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers