[Evolution-hackers] Evo-Plugin Coding Style

2010-07-01 Thread Christian Hilberg
Hi all, searching evolution-hackers about Evolution coding style, I found http://projects.gnome.org/evolution/patch.shtml referenced as the coding style reference ;-) for Evolution. Is this document still fully valid so we may use it as style guide for our project? Are there any

Re: [Evolution-hackers] Evo-Plugin Coding Style

2010-07-01 Thread Christian Hilberg
On Thursday 01 Juli 2010 at 13:01:22 Matthew Barnes wrote: On Thu, 2010-07-01 at 11:43 +0200, Christian Hilberg wrote: searching evolution-hackers about Evolution coding style, I found http://projects.gnome.org/evolution/patch.shtml [...] That's still more or less valid. There's

Re: [Evolution-hackers] Evo-Plugin Coding Style

2010-07-01 Thread Tor Lillqvist
style. patch.shtml talks about 8-space-tabs Just some nitpicking here: I hate it when people say loosely that tabs correspond to 8 spaces (or four, or whatever). A TAB character indents to the next multiple of the tab width. The tab width is a certain number of columns. Exactly how many spaces

Re: [Evolution-hackers] Evo-Plugin Coding Style

2010-07-01 Thread Matthew Barnes
On Thu, 2010-07-01 at 13:16 +0200, Christian Hilberg wrote: I'll propose this as our style guide then. Just like Ross in one posting (I think back in 2009), I'm interested specially in getting to know about indent style. patch.shtml talks about 8-space-tabs (and true tabs instead of

Re: [Evolution-hackers] Evo-Plugin Coding Style

2010-07-01 Thread Christian Hilberg
On Thursday 01 Juli 2010 at 13:30:26 Tor Lillqvist wrote: style. patch.shtml talks about 8-space-tabs Just some nitpicking here: I hate it when people say loosely that tabs correspond to 8 spaces (or four, or whatever). For good reason. :-) Just quoted

Re: [Evolution-hackers] Heads-up: EBookBackend/EBook ECalBackend/ECal ongoing API changes

2010-07-01 Thread chen
On Thu, 2010-07-01 at 13:41 +0200, Christian Hilberg wrote: On Thursday 01 Juli 2010 at 08:58:32 Milan Crha wrote: Hi all, I'm working on a way to be able to report detailed errors from addressbook/calendar backends to UI, so users will be able to see something more sensible than just

Re: [Evolution-hackers] Heads-up: EBookBackend/EBook ECalBackend/ECal ongoing API changes

2010-07-01 Thread Patrick Ohly
On Thu, 2010-07-01 at 08:58 +0200, Milan Crha wrote: I'm working on a way to be able to report detailed errors from addressbook/calendar backends to UI, so users will be able to see something more sensible than just Other error message in Evolution. This is bug report for this [1], which I'm

Re: [Evolution-hackers] Heads-up: EBookBackend/EBook ECalBackend/ECal ongoing API changes

2010-07-01 Thread Milan Crha
On Thu, 2010-07-01 at 14:42 +0200, Patrick Ohly wrote: Will that break libebook and libecal APIs? The issue only mentions backends, but the subject of your emails includes EBook and ECal. Hi, for EBook it is, all the async API there uses 'status' as an indicator of the operation result

Re: [Evolution-hackers] Heads-up: EBookBackend/EBook ECalBackend/ECal ongoing API changes

2010-07-01 Thread Patrick Ohly
On Thu, 2010-07-01 at 14:57 +0200, Milan Crha wrote: On Thu, 2010-07-01 at 14:42 +0200, Patrick Ohly wrote: Will that break libebook and libecal APIs? The issue only mentions backends, but the subject of your emails includes EBook and ECal. Hi, for EBook it is, all the async API

Re: [Evolution-hackers] Heads-up: EBookBackend/EBook ECalBackend/ECal ongoing API changes

2010-07-01 Thread Matthew Barnes
On Thu, 2010-07-01 at 14:57 +0200, Milan Crha wrote: for EBook it is, all the async API there uses 'status' as an indicator of the operation result in the async callback. I'm changing it to GError too. I'm still on ECalBackend, but it seems some similar change will be in ECal too, though I'm