Hi Andre, Thank you for your concern - but I believe I *did* give Matthew some feedback on the patch over IRC (see Chat transcript [1] below) a couple of weeks ago - about a possible ABI violation and a possible way to avoid it and he had agreed to rework that bit.
We do love those who love to hack on Evo :-). Cheers, Harish [1] Log - #evolution - 29 Jan 2007 (20:19:07) xfceslacker: harish is there something wrong with the email I sent?(http://mail.gnome.org/archives/evolution-hackers/2007-January/msg00053.html) (20:20:23) harish: xfceslacker: none (20:21:42) xfceslacker: I waited nearly a month for a response on my last email. (http://mail.gnome.org/archives/evolution-hackers/2007-January/msg00000.html) (20:22:05) harish: except that on a very quick glance at the patch - I feel that inserting a new element into an enum set violates the ABI (20:22:25) xfceslacker: ok (20:22:30) xfceslacker: thanks (20:22:31) xfceslacker: :) (20:23:16) harish: xfceslacker: I do not primarily hack on the mailer component - I have poked those who do to have a look at it and provide a response <snip> (20:23:46) harish: xfceslacker: sorry - the team is swamped by quite a bit of work..thanks for your patience (20:23:53) xfceslacker: ok. (20:24:01) xfceslacker: Anything else you see wrong with the patch? (20:25:36) xfceslacker: I know my em_utils_load_template function is ugly. (20:25:42) harish: xfceslacker: I am not the best person to make the call - but I'd prefer if you could append the new value so it extends the current set. (20:26:00) xfceslacker: ok (20:27:06) xfceslacker: You're talking about _mail_component_folder_t right? (20:27:35) xfceslacker: or enum { (20:27:35) xfceslacker: SEND, (20:27:35) xfceslacker: SAVE_DRAFT, (20:27:35) xfceslacker: + SAVE_TEMPLATE, (20:27:35) xfceslacker: LAST_SIGNAL (20:27:35) xfceslacker: }; (20:29:04) xfceslacker: or both? (20:30:19) harish: _e_account_item_t on libedataserver (20:30:27) xfceslacker: oh (20:30:29) xfceslacker: sorry (20:31:14) harish: Evolution is not a devel library...EDS is more religious about changes On Sun, 2007-02-11 at 02:30 +0100, Andre Klapper wrote: > may a developer answer this, or shall matthew ask for a third time on > this list, after waiting for six weeks for some feedback? > > andre > _______________________________________________ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers