[Evolution-hackers] e_cal_new_system_calendar() - creates a new calendar each time?

2011-04-07 Thread Patrick Ohly
Hello!

I noticed that in 2.32/MeeGo, e_cal_new_system_calendar() always creates
a new calendar, although there is already one.

It is defined in gconf as:

group uid=1300454894.7178.0@pohly-mobl1 name=On This Computer
base_uri=local: readonly=nosource
uid=1300454894.7178.4@pohly-mobl1 name=Personal
relative_uri=system color_spec=#BECEDD//group

The sequence of events is this:
 1. e_cal_new_system_calendar()
 2. e_cal_new_from_uri(local:system, ...
 3. get source list
 4. search_known_sources() by comparing e_source_peek_absolute_uri()
against local:system
 5. no source found, create anew

Step 4 fails because there is no absolute URI:

(gdb) p source-priv-absolute_uri
$11 = (gchar *) 0x0
(gdb) p source-priv-relative_uri
$12 = (gchar *) 0x8079450 system

Therefore e_source_peek_absolute_uri() returns NULL and the comparison
fails.

What is the root cause for this issue, and how should it be fixed?

-- 
Bye, Patrick Ohly
--  
patrick.o...@gmx.de
http://www.estamos.de/


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] e_cal_new_system_calendar() - creates a new calendar each time?

2011-04-07 Thread Patrick Ohly
On Do, 2011-04-07 at 10:47 +0200, Patrick Ohly wrote:
 Hello!
 
 I noticed that in 2.32/MeeGo, e_cal_new_system_calendar() always creates
 a new calendar, although there is already one.
 
 It is defined in gconf as:
 
 group uid=1300454894.7178.0@pohly-mobl1 name=On This Computer
 base_uri=local: readonly=nosource
 uid=1300454894.7178.4@pohly-mobl1 name=Personal
 relative_uri=system color_spec=#BECEDD//group
 
 The sequence of events is this:
  1. e_cal_new_system_calendar()
  2. e_cal_new_from_uri(local:system, ...
  3. get source list
  4. search_known_sources() by comparing e_source_peek_absolute_uri()
 against local:system
  5. no source found, create anew
 
 Step 4 fails because there is no absolute URI:
 
 (gdb) p source-priv-absolute_uri
 $11 = (gchar *) 0x0
 (gdb) p source-priv-relative_uri
 $12 = (gchar *) 0x8079450 system
 
 Therefore e_source_peek_absolute_uri() returns NULL and the comparison
 fails.
 
 What is the root cause for this issue, and how should it be fixed?

absolute_uri is taken from the uri property, so adding that to the
gconf sources works around the issue.

Perhaps dump_common_to_xml_node() and the code after
/* do not store absolute uris for local:system sources */
is to blame?

Or if uri is correctly not set, then
e_cal_new_system_calendar()/e_cal_new_from_uri() must be fixed to cope
with that?

One more oddity: on the client side, e_source_get_uri() for the system
calendar returns local:/system. What is the correct absolute URI for
the local system calendar?


-- 
Bye, Patrick Ohly
--  
patrick.o...@gmx.de
http://www.estamos.de/


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] (no subject)

2011-04-07 Thread David Woodhouse
On Tue, 2011-04-05 at 16:31 +0530, Chenthill Palanisamy wrote:
 This would certainly help distributions which want to stay with
 Evolution 2.32 for a while.. My only concern here is, while
 cherry-picking patches how would we take care of the translations and
 documentation ? Are we adhering to the freezes in the gnome-2-32
 branch (am not calling this a latest stable branch) ?

I suspect we should apply the same policy that we do on an active
stable branch — string changes should be avoided, unless absolutely
necessary.

-- 
David WoodhouseOpen Source Technology Centre
david.woodho...@intel.com  Intel Corporation

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-07 Thread David Woodhouse
I have built some Fedora 14 packages of Evo 2.32.2 with the latest
additional fixes, for testing.

The main reason for doing this is to fix bug 646164 with modified
instances of recurring appointments, since that's really getting on our
tits as we implement that part of the Evolution-EWS back end. But it
serves as a useful opportunity to test the other patches that we've
backported from HEAD, too.

EDS: http://koji.fedoraproject.org/koji/taskinfo?taskID=2981480
Evo: http://koji.fedoraproject.org/koji/taskinfo?taskID=2981538

This includes the 'proper' fix for GNOME bug #371705 (Calendar's day
view does not reset its IM context), instead of the preliminary
workaround that was previously present in the Fedora package. Is there
anyone who could test and confirm that it's working correctly in the
2.32 backport?

Once this passes muster, I'll push these patches (probably *without* the
NTLM bits, if you're looking closely at what I included) to the
gnome-2-32 branches and perhaps start doing a 'final call' for 2.32.3
candidate bugs/patches.

-- 
David WoodhouseOpen Source Technology Centre
david.woodho...@intel.com  Intel Corporation

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] e_cal_new_system_calendar() - creates a new calendar each time?

2011-04-07 Thread Matthew Barnes
On Thu, 2011-04-07 at 10:47 +0200, Patrick Ohly wrote: 
 The sequence of events is this:
  1. e_cal_new_system_calendar()
  2. e_cal_new_from_uri(local:system, ...
  3. get source list
  4. search_known_sources() by comparing e_source_peek_absolute_uri()
 against local:system
  5. no source found, create anew
 
 Step 4 fails because there is no absolute URI:
 
 (gdb) p source-priv-absolute_uri
 $11 = (gchar *) 0x0
 (gdb) p source-priv-relative_uri
 $12 = (gchar *) 0x8079450 system
 
 Therefore e_source_peek_absolute_uri() returns NULL and the comparison
 fails.

Perhaps it should be calling e_source_get_uri() instead, which either
returns the explicit absolute URI or constructs one from the group's
base URI + the source's relative URI.

The absolute URI for the system calendar is local:system.  There
should be no slash.  That's a bug.

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-07 Thread sean finney
Hi David,

On Thu, Apr 07, 2011 at 11:33:22AM +0100, David Woodhouse wrote:
 Once this passes muster, I'll push these patches (probably *without* the
 NTLM bits, if you're looking closely at what I included) to the
 gnome-2-32 branches and perhaps start doing a 'final call' for 2.32.3
 candidate bugs/patches.

Are there any plans to do the same for -mapi?  I have quite
the patch queue (maybe 10-20 patches) that I'm managing locally for
various backported fixes there.


sean
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers