Re: [Evolution-hackers] Did 3.4 just get really slow?

2012-05-21 Thread Milan Crha
On Sat, 2012-05-19 at 23:21 +0100, David Woodhouse wrote:
 [imapx:B] vanished: 65754
 camel_folder_summary_remove_uid() took 0.033764s
 [imapx:B] vanished: 65755
 camel_folder_summary_remove_uid() took 0.043655s
 ...
 
 What the hell happened? This code wasn't this slow before, was it?

Hi,
it might be after my changes in CamelFolderSummary and
CamelStoreSummary, namely under call of
camel-folder-summary.c: folder_summary_update_counts_by_flags()
That function updates CamelFolderSummary's properties about number of
read/under/junk/deleted/... messages, which can invoke change
notifications, to which CamelStoreSummary listens through
camel_store_summary_connect_folder_summary(), but it sets 5 seconds
delay for its saving (it was significantly slower when saving
immediately :) ), though I do not see what else can be the bottleneck
here.
Bye,
Milan


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] Request: New function in evolution-data-server 3.4.3

2012-05-21 Thread David Woodhouse
I just installed Evolution 3.4 and found a massive performance
regression¹ when it notices that a bunch of messages got deleted on the
server (I archive mail quarterly so thousands of messages disappear at
once).

It was taking about 40ms to delete each one, with individual database
mangling for each message. By introducing a new method to do them in a
batch, I cut that down to about 50µs per message.

It's a simple new function camel_folder_summary_remove_uids() which
parallels the existing camel_folder_summary_remove_uid() function.

I'd like to add this to the 3.4.3 release of EDS. Since it's just a new
function, there should be no compatibility issues... but I believe I
need permission from the release team...

-- 
dwmw2

¹ https://bugzilla.gnome.org/show_bug.cgi?id=676403


smime.p7s
Description: S/MIME cryptographic signature
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Request: New function in evolution-data-server 3.4.3

2012-05-21 Thread Matthias Clasen
On Mon, May 21, 2012 at 8:37 AM, David Woodhouse dw...@infradead.org wrote:


 I'd like to add this to the 3.4.3 release of EDS. Since it's just a new
 function, there should be no compatibility issues... but I believe I
 need permission from the release team...

Not really, no. Hard code freeze only lasts until the .0 release is
out. After that, its back to module maintainer discretion.

But I'm all for fixing evolution performance problems, so +1 anyway !
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers