[Evolution-hackers] problems building from HEAD

2009-11-01 Thread Roberto -MadBob- Guido
Hi all,

I had some problem compiling code from HEAD, all were missing references
in linking phase.
With some patience (and many `./autogen.sh`) I've corrected some
Makefile.am so to include all required libraries in *_LIBADD lists: a
patch is attached, but it sound so strange to me that no-one faced the
same problem I think it exists another reason for the inconvenience,
probably a very dummy one.

Do any other else had compilation (or, better, linking) errors from HEAD
in latest days?

-- 
Roberto -MadBob- Guido
http://claimid.com/madbob

From a7f6b6efeb79367f340a817a4393725465ce8e0d Mon Sep 17 00:00:00 2001
From: Roberto Guido bob4...@gmail.com
Date: Mon, 2 Nov 2009 00:24:51 +0100
Subject: [PATCH] Fixed many LIBADD lists in some Makefile.am

---
 composer/Makefile.am |4 +++-
 mail/Makefile.am |3 +++
 modules/mail/Makefile.am |6 +-
 plugins/email-custom-header/Makefile.am  |1 +
 plugins/groupwise-features/Makefile.am   |1 +
 plugins/mail-notification/Makefile.am|4 +++-
 plugins/mailing-list-actions/Makefile.am |1 +
 plugins/templates/Makefile.am|1 +
 8 files changed, 18 insertions(+), 3 deletions(-)

diff --git a/composer/Makefile.am b/composer/Makefile.am
index 6264266..bd2a285 100644
--- a/composer/Makefile.am
+++ b/composer/Makefile.am
@@ -60,7 +60,9 @@ libcomposer_la_LIBADD =	\
 	$(top_builddir)/shell/libeshell.la		\
 	$(top_builddir)/em-format/libemformat.la	\
 	$(top_builddir)/addressbook/gui/contact-editor/libecontacteditor.la		\
-	$(top_builddir)/addressbook/gui/contact-list-editor/libecontactlisteditor.la
+	$(top_builddir)/addressbook/gui/contact-list-editor/libecontactlisteditor.la	\
+	$(top_builddir)/e-util/libeutil.la		\
+	$(EVOLUTION_MAIL_LIBS)
 
 uidir = $(evolutionuidir)
 ui_DATA = evolution-composer.ui
diff --git a/mail/Makefile.am b/mail/Makefile.am
index 80777de..5a950d8 100644
--- a/mail/Makefile.am
+++ b/mail/Makefile.am
@@ -159,6 +159,8 @@ endif
 libevolution_mail_la_LIBADD =\
 	$(top_builddir)/e-util/libeutil.la		\
 	$(top_builddir)/shell/libeshell.la		\
+	$(top_builddir)/filter/libfilter.la		\
+	$(top_builddir)/em-format/libemformat.la	\
 	$(top_builddir)/composer/libcomposer.la		\
 	$(top_builddir)/widgets/table/libetable.la	\
 	$(top_builddir)/widgets/text/libetext.la	\
@@ -166,6 +168,7 @@ libevolution_mail_la_LIBADD =\
 	$(top_builddir)/addressbook/gui/contact-editor/libecontacteditor.la \
 	$(top_builddir)/addressbook/gui/contact-list-editor/libecontactlisteditor.la \
 	$(GNOME_PLATFORM_LIBS)\
+	$(EVOLUTION_MAIL_LIBS)\
 	$(CANBERRA_LIBS)\
 	$(GTKHTML_LIBS)	\
 	$(SMIME_LIBS)
diff --git a/modules/mail/Makefile.am b/modules/mail/Makefile.am
index 962fc61..9a695de 100644
--- a/modules/mail/Makefile.am
+++ b/modules/mail/Makefile.am
@@ -50,13 +50,17 @@ libevolution_module_mail_la_SOURCES =	\
 libevolution_module_mail_la_LIBADD =	\
 	$(top_builddir)/e-util/libeutil.la\
 	$(top_builddir)/shell/libeshell.la\
+	$(top_builddir)/filter/libfilter.la\
+	$(top_builddir)/em-format/libemformat.la			\
 	$(top_builddir)/composer/libcomposer.la\
 	$(top_builddir)/widgets/table/libetable.la			\
 	$(top_builddir)/widgets/text/libetext.la			\
 	$(top_builddir)/widgets/misc/libemiscwidgets.la			\
+	$(top_builddir)/widgets/menus/libmenus.la			\
 	$(top_builddir)/mail/libevolution-mail.la			\
 	$(top_builddir)/mail/importers/libevolution-mail-importers.la	\
-	$(GNOME_PLATFORM_LIBS)
+	$(GNOME_PLATFORM_LIBS)		\
+	$(EVOLUTION_MAIL_LIBS)
 
 libevolution_module_mail_la_LDFLAGS =	\
 	-avoid-version -module $(NO_UNDEFINED)
diff --git a/plugins/email-custom-header/Makefile.am b/plugins/email-custom-header/Makefile.am
index 9e827eb..976da5f 100644
--- a/plugins/email-custom-header/Makefile.am
+++ b/plugins/email-custom-header/Makefile.am
@@ -25,6 +25,7 @@ liborg_gnome_email_custom_header_la_LIBADD = 			\
 	$(top_builddir)/e-util/libeutil.la 			\
 	$(top_builddir)/widgets/misc/libemiscwidgets.la		\
 	$(top_builddir)/mail/libevolution-mail.la 		\
+	$(top_builddir)/composer/libcomposer.la			\
 	$(GNOME_PLATFORM_LIBS)	\
 	$(EVOLUTION_MAIL_LIBS)
 
diff --git a/plugins/groupwise-features/Makefile.am b/plugins/groupwise-features/Makefile.am
index 52e33fe..aea545b 100644
--- a/plugins/groupwise-features/Makefile.am
+++ b/plugins/groupwise-features/Makefile.am
@@ -55,6 +55,7 @@ liborg_gnome_groupwise_features_la_LIBADD=			\
 	$(top_builddir)/widgets/misc/libemiscwidgets.la		\
 	$(top_builddir)/filter/libfilter.la			\
 	$(top_builddir)/mail/libevolution-mail.la		\
+	$(top_builddir)/composer/libcomposer.la			\
 	$(EVOLUTION_CALENDAR_LIBS)\
 	$(EVOLUTION_MAIL_LIBS)	\
 	$(CAMEL_GROUPWISE_LIBS)
diff --git a/plugins/mail-notification/Makefile.am b/plugins/mail-notification/Makefile.am
index ddd1b51..0171926 100644
--- a/plugins/mail-notification/Makefile.am
+++ b/plugins/mail-notification/Makefile.am
@@ -30,8 +30,10

Re: [Evolution-hackers] mail address validation

2010-01-21 Thread Roberto -MadBob- Guido
On Thu, 2010-01-21 at 15:16 -0500, Paul Smith wrote:
 Please read my comment to the bug report
 
I've read, and you noticed something I didn't: it already exists a
policy to validate a mail address, in the New Account wizard (more
exactly: is_email() in mail/em-account-editor.c).

It is ultra-permissive, the only comment above the only if() is
/* make sure we have an '@' and that it's not the first or last gchar */

I think the same behaviour may be adopted elsewhere, because as you note
mail address validation is far more complex than the rules described in
RFCs and perhaps impossible to cover completely, but this little check
would be far better than no validation at all.

A `grep is_email * -r` find that this exactly routine has been pasted
also in plugins/google-account-setup/google-source.c,
e-util/e-html-utils.c also handles mail addresses checks, and it is now
required in Contact List: what about move it once in some shared file?

-- 
Roberto -MadBob- Guido
http://claimid.com/madbob


___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers