Re: [Evolution-hackers] [PATCH 1/2] e_cal_new_system_foo() should create corresponding source in GConf

2011-05-27 Thread Christophe Dumez

On 05/10/2011 01:43 PM, David Woodhouse wrote:

On Tue, 2011-05-10 at 11:40 +0100, Dumez, Christophe wrote:

I have tested the patch but it does not seem to help. I don't know
what the reason is yet.

It may depend on earlier fixes? Can you show your patch?


This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

Please don't post to public mailing lists with this unenforceable
nonsense. If you file a ticket with the helpdesk, they will remove it
for your outbound mail. (And if they refuse, get a name and contact me
in private).


I have attached the correct patches for libebook to bug:
https://bugzilla.gnome.org/show_bug.cgi?id=651226

I would appreciate if you could review them and apply them to gnome-3-32 
and master.


Kr,

--
Dr. Christophe Dumez
Linux Software Engineer
Intel Finland Oy - Open Source Technology Center

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] [libebook] unknown field name warnings

2011-05-23 Thread Christophe Dumez

Hi,

I'm currently working on the QtContacts backend for EDS in MeeGo. While 
testing the backend, I noticed warnings such as:


(process:30563): libebook-WARNING **: unknown field name `X-GENDER'
(process:30563): libebook-WARNING **: unknown field name 
`X-EDS-QTCONTACTS-FAVORITE'


I realized than those are caused by queries on custom EContact vcard 
fields. Those queries work fine though because e-book-query::func_*() 
test the return value of e_contact_field_id() and call 
e_book_query_vcard_field_test() instead of e_book_query_field_test() 
whenever the return value is 0 (unknown EContact field).


The warning is misleading because it makes developer think that he is 
doing something wrong (but as far as I know, this is the correct way to 
query custom fields). As a consequence, I believe that this warning 
should be removed (see patch attached).


Alternatively, a additional function could be added to test the 
existence of an EContact field, and then e-book-query::func_*() should 
be fixed to use this new function to check that this is a known field 
because calling e_contact_field_id().


Could something please comment on this?

Kr,

--
Dr. Christophe Dumez
Linux Software Engineer
Intel Finland Oy - Open Source Technology Center

From 204d7b742312c8d1e89e56657522ac49bc93ce72 Mon Sep 17 00:00:00 2001
From: Christophe Dumez christophe.du...@intel.com
Date: Mon, 23 May 2011 15:27:29 +0300
Subject: [PATCH] e_contact_field_id: Remove unknown field warning

EBookQuery supports queries based on custom contact
fields by calling e_contact_field_id() and handling
differently the case where the function returns 0.
The warnings are therefore confusing because the
queries on those unknown fields do work.

Calls to e_contact_field_id() are required because
there is no function to check if a field is known.
---
 addressbook/libebook/e-contact.c |1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/addressbook/libebook/e-contact.c b/addressbook/libebook/e-contact.c
index 9875103..033694f 100644
--- a/addressbook/libebook/e-contact.c
+++ b/addressbook/libebook/e-contact.c
@@ -1355,7 +1355,6 @@ e_contact_field_id (const gchar *field_name)
return field_info[i].field_id;
}
 
-   g_warning (unknown field name `%s', field_name);
return 0;
 }
 
-- 
1.7.4.4

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] libebook: errors when using asynchronous contact addition/removal functions

2011-05-13 Thread Christophe Dumez
Hi,

 

I'm currently working on the QtContacts backend for EDS part of MeeGo. While
testing our backend, I experienced some issues when using asynchronous
functions to add /remove contacts from the address book using libebook.

 

I'm attaching to this email a short test program that often fails on my
machine (I'm running EDS 2.32.3). It can be compiled using:

g++ main.cpp `pkg-config --cflags --libs libebook-1.2`

 

The test program is merely trying to add 100 contacts by calling 100 times
e_book_add_contact_async().

Then it tries to remove all of them at once by calling
e_book_remove_contacts_async().

 

On my machine some of the insertions often fail with error:
E_BOOK_ERROR_NOT_SUPPORTED.

When it happens that the insertions succeed, then trying to remove them
shortly after often fails with E_BOOK_ERROR_CONTACT_NOT_FOUND error.

 

Could someone please have a look? Hopefully it should be easy to reproduce
by running the program attached.

 

Thanks in advance,

Christophe Dumez.

 

 



main.cpp
Description: Binary data
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] [PATCH 1/2] e_cal_new_system_foo() should create corresponding source in GConf

2011-05-11 Thread Christophe Dumez
Hi,

No, I'm definitely not working on this (EDS), I thought you were :)
I actually followed Patrick's advice and I executed Evolution once so that it 
created the system addressbook. This way I can work around the bug and keep on 
working on the QtContacts backend for EDS. I don't have time to look into EDS 
code for now (I'm not familiar enough with EDS internals to do a quick fix).

Kr,
Christophe Dumez.

-Original Message-
From: David Woodhouse [mailto:dw...@infradead.org] 
Sent: Wednesday, May 11, 2011 2:26 PM
To: Dumez, Christophe
Cc: Patrick Ohly; Evolution Hackers; r...@burtonini.com
Subject: RE: [PATCH 1/2] e_cal_new_system_foo() should create corresponding 
source in GConf

On Tue, 2011-05-10 at 11:40 +0100, Dumez, Christophe wrote:
 I have tested the patch but it does not seem to help. I don't know
 what the reason is yet.

I'm going to assume you're still happily working on this and don't need
my assistance, until such time as you turn up on the #evolution IRC
channel and bug me about it. OK? :)

-- 
dwmw2


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers