On Mon, 2013-02-25 at 18:25 +0900, Tristan wrote:
> Perhaps, if performance at connection time is very slow, we should
> take an approach that the factory connection be released when
> all EBookClients are finalized (with a sort of internal ref-counting
> logic)... if of course, performance of open
On Mon, 2013-02-25 at 19:46 +0900, Tristan wrote:
[...]
> I've made some fixes and now test cases are working much better
> with the workarounds in place. I think the final touch will be
> to run the module-prompter test relocated and then make check
> will be completely passing again.
Correction,
On Sun, 2013-02-24 at 20:54 -0500, Matthew Barnes wrote:
> On Sat, 2013-02-23 at 23:38 +0900, Tristan wrote:
> > This indicates that somewhere, in the client or server, we
> > are leaking references to the GDBusConnections. I've tested
> > this in raw GIO (and added a test case there) to ensure it
On Mon, 2013-02-25 at 09:23 +0100, Milan Crha wrote:
> On Sun, 2013-02-24 at 23:01 -0500, Matthew Barnes wrote:
> > I went ahead and committed it for 3.8.
> >
> > We'll see if this has any impact on the GDBusConnection leak, but it's
> > an improvement regardless.
>
> Hi,
> easy to test it
On Sun, 2013-02-24 at 23:01 -0500, Matthew Barnes wrote:
> I went ahead and committed it for 3.8.
>
> We'll see if this has any impact on the GDBusConnection leak, but it's
> an improvement regardless.
Hi,
easy to test it with Tristan's [1], isn't it? You'll realize it'll not
help, just t
On Sun, 2013-02-24 at 20:54 -0500, Matthew Barnes wrote:
> We could try letting EBookClient create its own EDBusAddressBookFactory
> proxy, call its OpenAddressBook method, and then immediately destroy it.
>
> That would simplify the code, eliminate the global variable, and quite
> possibly fix th
On Sat, 2013-02-23 at 23:38 +0900, Tristan wrote:
> This indicates that somewhere, in the client or server, we
> are leaking references to the GDBusConnections. I've tested
> this in raw GIO (and added a test case there) to ensure it
> is indeed possible to stop/start the GTestDBus between tests,
>
Since I spent some time today debugging the situation, I wanted to just
share my findings so that we can hopefully fix up the remaining messy
parts, piece by piece.
There are a few remaining problems which cause the test cases to
not consistently pass, so let's run through them in a random order
(
