Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-06-27 at 13:22 +0100, David Woodhouse wrote: On Mon, 2011-05-23 at 16:55 +0400, James Bottomley wrote: I kid you not. You can see this just by going to your own outlook web server (when you highlight a message, you'll see an empty tall oblong, click and it will bring up the categories). Exchange allows arbitrary labels (like we do), but the default ones are Blue, Green, Orange, Purple, Red and Yellow. Evolution has label mappings for everything apart from Yellow. I figured we should map default to default. I don't really like mapping 'Red' to 'Important', etc. I was just doing a mapping of what seems to be intended. This is also what the imap camel plugin does (except it maps $label1 - important etc.) Given that we support arbitrary labels on both sides, I think the best solution is to synchronise the set of labels. If we see a label on an Exchange message which isn't already known in Evolution, *add* it to Evolution's list. And if we're trying to add a label to an Exchange item which isn't already known on the Exchange side, add it there too. I don't think we can ... at least it's an invasive change. There doesn't seem to be a way to show arbitrary labels. The plugins have a label map, which is partly provider supplied and partly user supplied (if the provider allows user labels). If the imap server comes across a label it doesn't have a map for, it just ignores it ... This keeps biting me because I use a custom patch label in my mailboxes for my git workflow. When I move to a new machine, I always have a WTF where are my patches moment ... until I remember to add the label mapping. James ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 16:55 +0400, James Bottomley wrote: I kid you not. You can see this just by going to your own outlook web server (when you highlight a message, you'll see an empty tall oblong, click and it will bring up the categories). Exchange allows arbitrary labels (like we do), but the default ones are Blue, Green, Orange, Purple, Red and Yellow. Evolution has label mappings for everything apart from Yellow. I figured we should map default to default. I don't really like mapping 'Red' to 'Important', etc. Given that we support arbitrary labels on both sides, I think the best solution is to synchronise the set of labels. If we see a label on an Exchange message which isn't already known in Evolution, *add* it to Evolution's list. And if we're trying to add a label to an Exchange item which isn't already known on the Exchange side, add it there too. -- dwmw2 ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 16:01 +0100, David Woodhouse wrote: On Mon, 2011-05-23 at 17:46 +0400, James Bottomley wrote: I think you probably need me to get a feel for evolution development initially before you set me loose in the repo ... Why? It's mostly my baby, and I'm a kernel hacker too... :) Incidentally, I presume you use bugzilla for bugs? I just ran across one experimenting with Categories. Apparently if I change the category on the outlook webserver, it causes us to delete the email (with or without my patch applied). That'll be a bug that Chen introduced on Thursday. I've reverted those commits for now. We're currently between Alpha and Beta releases; I don't mind a little bit of 'churn', but I draw the line at data loss :) Sorry about that. Sorry for it, its a bad assumption I made. Fixed it in master. - Chenthill. Note that HEAD doesn't compile at the moment because of something committed by Pavel Ocheretny pochere...@src.gnome.com last night. I'll change that to a real, working email address and *POKE*. ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 14:41 +0400, James Bottomley wrote:
+
+ /* this is a mapping from Exchange/Outlook categories to
+* evolution labels based on the standard colours */
+ const gchar *labels[] = {
+ Red Category, $Labelimportant,
+ Orange Category, $Labelwork,
+ Green Category, $Labelpersonal,
+ Blue Category, $Labeltodo,
+ Purple Category, $Labellater,
+ NULL, NULL
+ };
That's the only reason I might *not* want to apply your patch
immediately, right?
Is there a correct way to handle the mapping? Does Exchange really
just store them by colour?
--
dwmw2
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 14:41 +0400, James Bottomley wrote: This patch ... Hi, could you use Gnome's bugzilla for patch reviews, please? It has couple reasons why: a) bugzilla is meant for that b) bugzilla has integrated tools for patches and their review c) it's easier to follow (broken) commit with bugzilla reference than with some mailing list message to which the reference cannot be added such easily like a bug reference. Basically all the tools used in Gnome are ready and capable of bugzilla and makes life much easier when it is used, especially the part with commits and git and so on. There used to be evolution-patches message list, but it was dropped because the history showed it as an unusable medium for patch submission. That's how I understood it. Thanks and bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 12:19 +0100, David Woodhouse wrote:
On Mon, 2011-05-23 at 14:41 +0400, James Bottomley wrote:
+
+ /* this is a mapping from Exchange/Outlook categories to
+* evolution labels based on the standard colours */
+ const gchar *labels[] = {
+ Red Category, $Labelimportant,
+ Orange Category, $Labelwork,
+ Green Category, $Labelpersonal,
+ Blue Category, $Labeltodo,
+ Purple Category, $Labellater,
+ NULL, NULL
+ };
That's the only reason I might *not* want to apply your patch
immediately, right?
Is there a correct way to handle the mapping? Does Exchange really
just store them by colour?
I kid you not.
You can see this just by going to your own outlook web server (when you
highlight a message, you'll see an empty tall oblong, click and it will
bring up the categories).
Exchange allows arbitrary labels (like we do), but the default ones are
Blue, Green, Orange, Purple, Red and Yellow. Evolution has label
mappings for everything apart from Yellow. I figured we should map
default to default.
James
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 14:21 +0200, Milan Crha wrote: On Mon, 2011-05-23 at 14:41 +0400, James Bottomley wrote: This patch ... Hi, could you use Gnome's bugzilla for patch reviews, please? Consider this more an RFC requiring feedback than a patch requiring review. James It has couple reasons why: a) bugzilla is meant for that b) bugzilla has integrated tools for patches and their review c) it's easier to follow (broken) commit with bugzilla reference than with some mailing list message to which the reference cannot be added such easily like a bug reference. Basically all the tools used in Gnome are ready and capable of bugzilla and makes life much easier when it is used, especially the part with commits and git and so on. There used to be evolution-patches message list, but it was dropped because the history showed it as an unusable medium for patch submission. That's how I understood it. Thanks and bye, Milan ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH] evolution-ews: implement Exchange categories as evolution labels (read only)
On Mon, 2011-05-23 at 17:08 +0400, James Bottomley wrote: could you use Gnome's bugzilla for patch reviews, please? Consider this more an RFC requiring feedback than a patch requiring review. For Evo-EWS I'm much happier with patches in email anyway. I find it a lot easier to review patches, and to apply them with 'git am', if they are in email. I'm going to get notified by email *anyway* — that's how I learn about new bugs in bugzilla too. So it's just a question of whether all the information I need is right there in the email when I first see it, or whether I have to go grubbing around in a web browser to find it, download it, and then play silly buggers to apply it and get the authorship right. In fact, James, if you're going to make a habit of sending patches for Evo-EWS why not just get an account in GNOME git and apply them directly? :) http://live.gnome.org/NewAccounts -- dwmw2 ___ evolution-hackers mailing list evolution-hackers@gnome.org To change your list options or unsubscribe, visit ... http://mail.gnome.org/mailman/listinfo/evolution-hackers
