Re: [Evolution-hackers] Build failure in evolution 2.30.0 (was Re: Patch for Evo 2.30 - size of mail sidebar)
On Tue, 2010-03-30 at 04:10 +0200, Vincent Untz wrote:
Can we get a 2.30.0.1 tarball that uses some non-deprecated API or, even
better, that doesn't use -DGTK_DISABLE_DEPRECATED by default?
Even better, can we get a macro added to gnome-common that implements
this deprecation flag policy, and perhaps even set a GNOME Goal for it?
From what I've read on d-d-l, GNOME_MAINTAINER_MODE_DEFINES should be
deprecated and replaced with something we can agree on.
Proposed patch attached.
Matt
commit f6a4ce37e5ea1dc0df62ac244fbeb158de3d2cb2
Author: Matthew Barnes mbar...@redhat.com
Date: Tue Mar 30 09:06:49 2010 -0400
Add GNOME_DEVELOPER_DEFINES
Similiar to GNOME_MAINTAINER_MODE_DEFINES, but checks for the presence
of $srcdir/.git instead of checking maintainer mode.
diff --git a/macros2/gnome-common.m4 b/macros2/gnome-common.m4
index a5a0ead..b3ec5a8 100644
--- a/macros2/gnome-common.m4
+++ b/macros2/gnome-common.m4
@@ -48,3 +48,19 @@ AC_DEFUN([GNOME_MAINTAINER_MODE_DEFINES],
AC_SUBST(DISABLE_DEPRECATED)
])
+
+dnl GNOME_DEVELOPER_DEFINES ()
+dnl define DISABLE_DEPRECATED
+dnl
+AC_DEFUN([GNOME_DEVELOPER_DEFINES],
+[
+ DISABLE_DEPRECATED=
+ if test -d $srcdir/.git; then
+ DOMAINS=G ATK PANGO GDK GDK_PIXBUF GTK GCONF BONOBO BONOBO_UI GNOME LIBGLADE VTE GNOME_VFS WNCK LIBSOUP
+ for DOMAIN in $DOMAINS; do
+ DISABLE_DEPRECATED=$DISABLE_DEPRECATED -D${DOMAIN}_DISABLE_DEPRECATED -D${DOMAIN}_DISABLE_SINGLE_INCLUDES
+ done
+ fi
+
+ AC_SUBST(DISABLE_DEPRECATED)
+])
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Build failure in evolution 2.30.0 (was Re: Patch for Evo 2.30 - size of mail sidebar)
On Tue, 2010-03-30 at 15:35 +0200, Vincent Untz wrote: Le mardi 30 mars 2010, à 09:18 -0400, Matthew Barnes a écrit : Even better, can we get a macro added to gnome-common that implements this deprecation flag policy, and perhaps even set a GNOME Goal for it? Sure, it'd be nice to have that. Please attach the patch in bugzilla, though: it will help get this integrated. FWIW, I'm not a maintainer of gnome-common, but I would prefer to have a configure flag for this too. Done. https://bugzilla.gnome.org/show_bug.cgi?id=614360 ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Build failure in evolution 2.30.0 (was Re: Patch for Evo 2.30 - size of mail sidebar)
On Tue, 2010-03-30 at 10:18 -0400, Matthew Barnes wrote: On Tue, 2010-03-30 at 15:35 +0200, Vincent Untz wrote: Le mardi 30 mars 2010, à 09:18 -0400, Matthew Barnes a écrit : Even better, can we get a macro added to gnome-common that implements this deprecation flag policy, and perhaps even set a GNOME Goal for it? Sure, it'd be nice to have that. Please attach the patch in bugzilla, though: it will help get this integrated. FWIW, I'm not a maintainer of gnome-common, but I would prefer to have a configure flag for this too. Done. https://bugzilla.gnome.org/show_bug.cgi?id=614360 Released the updated tarballs for 2.30.0.1 - Chenthill. ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] Build failure in evolution 2.30.0 (was Re: Patch for Evo 2.30 - size of mail sidebar)
On Tue, 2010-03-30 at 04:10 +0200, Vincent Untz wrote: Can we get a 2.30.0.1 tarball that uses some non-deprecated API or, even better, that doesn't use -DGTK_DISABLE_DEPRECATED by default? Ugh, sorry about the breakage. I'm building Evo on GTK+ for GNOME 2.28; that's why I didn't notice this. Thanks for the quick fix. Federico ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
