Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
Am Dienstag, den 15.08.2006, 11:41 -0400 schrieb Matthew Barnes: If only partial APIs are going to be #include'd in Evolution source files, then can I ask that the -Werror-implicit-function-declaration flag be used for compilation? That would reduce the need for future patches like the one Pavel is proposing here. let's get matthew's patch at bug 351332 in and from that on, we should compile always with -Werror-implicit-function-declaration and G_LOG_LEVEL_CRITICAL enabled to both avoid problems on other platforms and unusable 2.7.4 releases. harish, poornima? cheers, andre -- mailto:[EMAIL PROTECTED] | failed! http://www.iomc.de signature.asc Description: Dies ist ein digital signierter Nachrichtenteil ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
Pavel, I guess it is good to follow what is already there. Please commit. Thanks Srini. On Mon, 2006-08-14 at 19:58 -0400, Pavel Roskin wrote: From: Pavel Roskin [EMAIL PROTECTED] --- widgets/misc/e-icon-entry.c |2 ++ widgets/table/e-cell-text.c |1 + widgets/table/e-table-utils.c |1 + 3 files changed, 4 insertions(+), 0 deletions(-) diff --git a/widgets/misc/e-icon-entry.c b/widgets/misc/e-icon-entry.c index 8b8e5af..28779dc 100644 --- a/widgets/misc/e-icon-entry.c +++ b/widgets/misc/e-icon-entry.c @@ -39,6 +39,8 @@ #include e-icon-entry.h #include gtk/gtkentry.h #include gtk/gtkbox.h #include gtk/gtkhbox.h +#include gtk/gtkeventbox.h +#include gtk/gtkimage.h #define E_ICON_ENTRY_GET_PRIVATE(object)(G_TYPE_INSTANCE_GET_PRIVATE ((object), E_TYPE_ICON_ENTRY, EIconEntryPrivate)) diff --git a/widgets/table/e-cell-text.c b/widgets/table/e-cell-text.c index fee7d04..0de2375 100644 --- a/widgets/table/e-cell-text.c +++ b/widgets/table/e-cell-text.c @@ -45,6 +45,7 @@ #include gdk/gdkkeysyms.h #include gtk/gtk.h #include libgnomecanvas/gnome-canvas.h #include libgnomecanvas/gnome-canvas-rect-ellipse.h +#include libgnomeprint/gnome-print-pango.h #include a11y/e-table/gal-a11y-e-cell-registry.h #include a11y/e-table/gal-a11y-e-cell-text.h diff --git a/widgets/table/e-table-utils.c b/widgets/table/e-table-utils.c index 178842c..ac149e1 100644 --- a/widgets/table/e-table-utils.c +++ b/widgets/table/e-table-utils.c @@ -24,6 +24,7 @@ #include config.h #include libintl.h /* This file uses dgettext() but no _() */ +#include string.h #include e-util/e-util.h #include misc/e-unicode.h ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: From: Pavel Roskin [EMAIL PROTECTED] --- a/widgets/misc/e-icon-entry.c +++ b/widgets/misc/e-icon-entry.c @@ -39,6 +39,8 @@ #include e-icon-entry.h #include gtk/gtkentry.h #include gtk/gtkbox.h #include gtk/gtkhbox.h +#include gtk/gtkeventbox.h +#include gtk/gtkimage.h Isn't the correct thing here to just include gtk/gtk.h and not attempt to hand-pick individual gtk headers? --tml ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
the original idea was to speed up compile time On Tue, 2006-08-15 at 08:50 +, Tor Lillqvist wrote: må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: From: Pavel Roskin [EMAIL PROTECTED] --- a/widgets/misc/e-icon-entry.c +++ b/widgets/misc/e-icon-entry.c @@ -39,6 +39,8 @@ #include e-icon-entry.h #include gtk/gtkentry.h #include gtk/gtkbox.h #include gtk/gtkhbox.h +#include gtk/gtkeventbox.h +#include gtk/gtkimage.h Isn't the correct thing here to just include gtk/gtk.h and not attempt to hand-pick individual gtk headers? --tml ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. [EMAIL PROTECTED] - www.novell.com ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
Hello, Tor! On Tue, 2006-08-15 at 08:50 +, Tor Lillqvist wrote: må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: +#include gtk/gtkeventbox.h +#include gtk/gtkimage.h Isn't the correct thing here to just include gtk/gtk.h and not attempt to hand-pick individual gtk headers? Being quite new to all this, I'm trying to follow the existing style rather than fix warnings and do The Right Thing at once. It should be easy (for anyone knowing Perl, that is) to replace gtk/gtk*.h with gtk/gtk.h across the board and then remove duplicate headers. -- Regards, Pavel Roskin ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
Zucchi did timings a while back and found it to be worth it *shrug* I don't have the timings on me tho, so I have no idea what kind of difference it made. On Tue, 2006-08-15 at 15:20 +, Tor Lillqvist wrote: ti 2006-08-15 klockan 10:18 -0400 skrev Jeffrey Stedfast: the original idea was to speed up compile time Sure, I can guess that, but is it worth it? Some timings would be interesting, but on the other hand, it can't be worth spending time on doing such timings... --tml ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers -- Jeffrey Stedfast Evolution Hacker - Novell, Inc. [EMAIL PROTECTED] - www.novell.com ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes
On Tue, 2006-08-15 at 11:16 -0400, Jeffrey Stedfast wrote: Zucchi did timings a while back and found it to be worth it *shrug* I don't have the timings on me tho, so I have no idea what kind of difference it made. If only partial APIs are going to be #include'd in Evolution source files, then can I ask that the -Werror-implicit-function-declaration flag be used for compilation? That would reduce the need for future patches like the one Pavel is proposing here. Matthew Barnes ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
