Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-19 Thread Andre Klapper
Am Dienstag, den 15.08.2006, 11:41 -0400 schrieb Matthew Barnes: If only partial APIs are going to be #include'd in Evolution source files, then can I ask that the -Werror-implicit-function-declaration flag be used for compilation? That would reduce the need for future patches like the one

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-17 Thread Kjartan Maraas
tir, 15,.08.2006 kl. 08.50 +, skrev Tor Lillqvist: må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: From: Pavel Roskin [EMAIL PROTECTED] --- a/widgets/misc/e-icon-entry.c +++ b/widgets/misc/e-icon-entry.c @@ -39,6 +39,8 @@ #include e-icon-entry.h #include gtk/gtkentry.h

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-16 Thread Srinivasa Ragavan
Pavel, I guess it is good to follow what is already there. Please commit. Thanks Srini. On Mon, 2006-08-14 at 19:58 -0400, Pavel Roskin wrote: From: Pavel Roskin [EMAIL PROTECTED] --- widgets/misc/e-icon-entry.c |2 ++ widgets/table/e-cell-text.c |1 +

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Tor Lillqvist
må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: From: Pavel Roskin [EMAIL PROTECTED] --- a/widgets/misc/e-icon-entry.c +++ b/widgets/misc/e-icon-entry.c @@ -39,6 +39,8 @@ #include e-icon-entry.h #include gtk/gtkentry.h #include gtk/gtkbox.h #include gtk/gtkhbox.h +#include

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Jeffrey Stedfast
the original idea was to speed up compile time On Tue, 2006-08-15 at 08:50 +, Tor Lillqvist wrote: må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: From: Pavel Roskin [EMAIL PROTECTED] --- a/widgets/misc/e-icon-entry.c +++ b/widgets/misc/e-icon-entry.c @@ -39,6 +39,8 @@

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Pavel Roskin
Hello, Tor! On Tue, 2006-08-15 at 08:50 +, Tor Lillqvist wrote: må 2006-08-14 klockan 19:58 -0400 skrev Pavel Roskin: +#include gtk/gtkeventbox.h +#include gtk/gtkimage.h Isn't the correct thing here to just include gtk/gtk.h and not attempt to hand-pick individual gtk headers?

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Tor Lillqvist
ti 2006-08-15 klockan 10:18 -0400 skrev Jeffrey Stedfast: the original idea was to speed up compile time Sure, I can guess that, but is it worth it? Some timings would be interesting, but on the other hand, it can't be worth spending time on doing such timings... --tml

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Jeffrey Stedfast
Zucchi did timings a while back and found it to be worth it *shrug* I don't have the timings on me tho, so I have no idea what kind of difference it made. On Tue, 2006-08-15 at 15:20 +, Tor Lillqvist wrote: ti 2006-08-15 klockan 10:18 -0400 skrev Jeffrey Stedfast: the original idea was to

Re: [Evolution-hackers] [PATCH 3/3] Add some missing includes

2006-08-15 Thread Matthew Barnes
On Tue, 2006-08-15 at 11:16 -0400, Jeffrey Stedfast wrote: Zucchi did timings a while back and found it to be worth it *shrug* I don't have the timings on me tho, so I have no idea what kind of difference it made. If only partial APIs are going to be #include'd in Evolution source files,