Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-11 Thread Patrick Ohly
On Fr, 2011-04-08 at 16:31 +0100, David Woodhouse wrote:
 On Fri, 2011-04-08 at 15:31 +0200, Patrick Ohly wrote:
  On Do, 2011-04-07 at 11:33 +0100, David Woodhouse wrote:
   Once this passes muster, I'll push these patches (probably *without* the
   NTLM bits, if you're looking closely at what I included) to the
   gnome-2-32 branches and perhaps start doing a 'final call' for 2.32.3
   candidate bugs/patches.
  
  Please consider backporting the fixes for e_cal_new_system_*(). They are
  unusable in 2.32.x but I intended to use them soon in MeeGo.
  
  I'm not sure which fixed from the master branch are all needed, I hope
  Matthew and Milan can provide a list.
 
 I am trying hard not to bother Matthew and Milan; I don't want the
 continued maintenance of the gnome-2-32 branch to be a burden to them in
 any way.

I know, but Matthew had already kindly offered some help here.

 I have cherry-picked the patches from master which look relevant; please
 could you test what is currently in
 
 http://git.infradead.org/evolution-data-server-2.32.git
  git://git.infradead.org/evolution-data-server-2.32.git

Listing sources shows local:/system instead of local:system and opening
local:system also still fails.

Milan pointed to the history of e-source.c, but I don't see which
(other?) commits are needed to fix these issues.

-- 
Best Regards, Patrick Ohly

The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-11 Thread Milan Crha
On Mon, 2011-04-11 at 10:54 +0200, Patrick Ohly wrote:
 Listing sources shows local:/system instead of local:system and opening
 local:system also still fails.
 
 Milan pointed to the history of e-source.c, but I don't see which
 (other?) commits are needed to fix these issues.

Hi,
try these commits from eds:

1443076ae96133f7046f7ea96cb39352f0ca4508
fc9462d477b098b8f15db5cde3952db6d92e2868

and probably this from evo:

8e33ff0fbb5908d06c9f32f58f35eca694b3f50c

I didn't check if they had any followup commits done by others, I only
chose commits I did in this area, though I've a feeling there might be
some followups.
Hope that helps,
Milan

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-08 Thread sean finney
Hi David,

On Thu, Apr 07, 2011 at 01:07:38PM +0100, David Woodhouse wrote:
 Personally, no. I'd rather ignore MAPI completely and get on with the
 implementation of evolution-ews.

Understandable, though as we've discussed on IRC we don't really have
the option of using that here, at least for another couple quarters.

 
   I have quite the patch queue (maybe 10-20 patches) that I'm managing
  locally for various backported fixes there.
 
 Sounds like you would be in a good position to do it though.

Because I'm not a gnome dev, I (a) don't have push access, and (b)
am a bit hesitant to go against Milan's wishes, since he's the dev
who is primarily keeping things up for -mapi and has made his stance
pretty clear.  I only brought it up because it seemed like there might
be a change in that stance, and if so I'd be happy to share my currently
unshared fixes in .32.

Then again, now that 3.0 is released I may try again to get something
rolled together based on that since there are already a number of api
breaks making backports difficult for .32, and it seems there are lots
more in the pipe for 3.1.


sean
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-08 Thread David Woodhouse
On Fri, 2011-04-08 at 09:54 +0200, sean finney wrote:
 
  Sounds like you would be in a good position to do it though.
 
 Because I'm not a gnome dev, I (a) don't have push access, and (b)
 am a bit hesitant to go against Milan's wishes, since he's the dev
 who is primarily keeping things up for -mapi and has made his stance
 pretty clear.  I only brought it up because it seemed like there might
 be a change in that stance, and if so I'd be happy to share my
 currently unshared fixes in .32.

You're more than welcome to use git.infradead.org if you want. But even
if Milan sees the 2.32 branch as being dead and doesn't want to spend
any of his own time on it (and nobody can blame him for that), I would
hope that he wouldn't try to obstruct *you* if you feel you need to do
so.

 Then again, now that 3.0 is released I may try again to get something
 rolled together based on that since there are already a number of api
 breaks making backports difficult for .32, and it seems there are lots
 more in the pipe for 3.1.

Certainly, my point in maintaining fixes for 2.32 was *not* to
discourage people from upgrading. So if 3.0 is a viable option for you
then please do go ahead.

Having said that, the API breaks haven't *yet* reached the point where
we can't build evo-ews for 2.32 and 3.x from the *same* code base,
albeit with a number of icky ifdefs.

-- 
dwmw2

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-08 Thread David Woodhouse
On Thu, 2011-04-07 at 15:08 +0200, Milan Crha wrote:
 Hmm, I still do not like the idea of adding things to gnome-2-32 branch,
 I thought I saw you telling that if anyone will complain then you'll not
 do that and I thought I complained to it, but I cannot find the email
 right now, so I cannot point to the logic error I see in such
 statement. :) 

Sorry, I do still owe you a reply to that. Shortly...

-- 
dwmw2

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-08 Thread sean finney
Hi David,

On Fri, Apr 08, 2011 at 09:08:28AM +0100, David Woodhouse wrote:
 You're more than welcome to use git.infradead.org if you want. But even
 if Milan sees the 2.32 branch as being dead and doesn't want to spend
 any of his own time on it (and nobody can blame him for that), I would
 hope that he wouldn't try to obstruct *you* if you feel you need to do
 so.

Well it would be nice to get them *somewhere*, anyway, since it does feel
silly that there are a number of distro's and organizations in the same
situation who are forced to basically do the same work and have no way
to cooperate.  Maybe we can fix something out-of-band from this discussion
then, and leave it as an internal decision for the evo team whether or
not to include them.

  Then again, now that 3.0 is released I may try again to get something
  rolled together based on that since there are already a number of api
  breaks making backports difficult for .32, and it seems there are lots
  more in the pipe for 3.1.
 
 Certainly, my point in maintaining fixes for 2.32 was *not* to
 discourage people from upgrading. So if 3.0 is a viable option for you
 then please do go ahead.

I'd certainly like to upgrade if possible to stay relatively current,
but also have implementation constraints about installation size and
compatability with being run from older gnome desktops.  And last time
i tried (about a month pre-release) it didn't pan out so well.


Sean

-- 
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-08 Thread Patrick Ohly
On Do, 2011-04-07 at 11:33 +0100, David Woodhouse wrote:
 Once this passes muster, I'll push these patches (probably *without* the
 NTLM bits, if you're looking closely at what I included) to the
 gnome-2-32 branches and perhaps start doing a 'final call' for 2.32.3
 candidate bugs/patches.

Please consider backporting the fixes for e_cal_new_system_*(). They are
unusable in 2.32.x but I intended to use them soon in MeeGo.

I'm not sure which fixed from the master branch are all needed, I hope
Matthew and Milan can provide a list.

-- 
Bye, Patrick Ohly
--  
patrick.o...@gmx.de
http://www.estamos.de/


___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


[Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-07 Thread David Woodhouse
I have built some Fedora 14 packages of Evo 2.32.2 with the latest
additional fixes, for testing.

The main reason for doing this is to fix bug 646164 with modified
instances of recurring appointments, since that's really getting on our
tits as we implement that part of the Evolution-EWS back end. But it
serves as a useful opportunity to test the other patches that we've
backported from HEAD, too.

EDS: http://koji.fedoraproject.org/koji/taskinfo?taskID=2981480
Evo: http://koji.fedoraproject.org/koji/taskinfo?taskID=2981538

This includes the 'proper' fix for GNOME bug #371705 (Calendar's day
view does not reset its IM context), instead of the preliminary
workaround that was previously present in the Fedora package. Is there
anyone who could test and confirm that it's working correctly in the
2.32 backport?

Once this passes muster, I'll push these patches (probably *without* the
NTLM bits, if you're looking closely at what I included) to the
gnome-2-32 branches and perhaps start doing a 'final call' for 2.32.3
candidate bugs/patches.

-- 
David WoodhouseOpen Source Technology Centre
david.woodho...@intel.com  Intel Corporation

___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] Fedora builds with 2.32.2+ patches

2011-04-07 Thread sean finney
Hi David,

On Thu, Apr 07, 2011 at 11:33:22AM +0100, David Woodhouse wrote:
 Once this passes muster, I'll push these patches (probably *without* the
 NTLM bits, if you're looking closely at what I included) to the
 gnome-2-32 branches and perhaps start doing a 'final call' for 2.32.3
 candidate bugs/patches.

Are there any plans to do the same for -mapi?  I have quite
the patch queue (maybe 10-20 patches) that I'm managing locally for
various backported fixes there.


sean
___
evolution-hackers mailing list
evolution-hackers@gnome.org
To change your list options or unsubscribe, visit ...
http://mail.gnome.org/mailman/listinfo/evolution-hackers