Re: [Evolution-hackers] Proposed fix for bug 311512

2007-06-01 Thread Karl Relton
Review from anyone? ... Hi friends I have submitted new patches to bugzilla for bug http://bugzilla.gnome.org/show_bug.cgi?id=311512 One changes e-d-s as Fejj suggested, the other does the Evolution side so it will only do mail-notification on 'truely' new messages. I'll be pleased if

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-05-20 Thread Karl Relton
Hi friends I have submitted new patches to bugzilla for bug http://bugzilla.gnome.org/show_bug.cgi?id=311512 One changes e-d-s as Fejj suggested, the other does the Evolution side so it will only do mail-notification on 'truely' new messages. I'll be pleased if you could review. Karl On

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-05-20 Thread Srinivasa Ragavan
Karl, This is a killer problem and you have been rocking with your patches on this right from the beginning. Awesome work! I'm sure that the Mailer hackers would review it asap and It will be great if we can get this in for 2.11.3. Thanks for your great work! -Srini. On Sun, 2007-05-20 at

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-04-26 Thread Jeffrey Stedfast
On Thu, 2007-04-26 at 07:50 +0100, Karl Relton wrote: On Wed, 2007-04-25 at 09:48 -0400, Jeffrey Stedfast wrote: I'm not sure I'd call it get_filter_thread() because it's not getting a thread, all it is really doing is getting you a 'wait' id (and ugh, the new session_thread_wait() just

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-04-26 Thread Karl Relton
On Thu, 2007-04-26 at 09:29 -0400, Jeffrey Stedfast wrote: Yes - I had thought of this too. The trouble is with the current code its not quite so simple AFAIK. The filtering that takes place is actually launched from the folder_changed() function in camel-folder.c. In other words, it is

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-04-25 Thread Karl Relton
Hi friends, Could anyone take a look at my proposed patches for fixing bug 311512. Srini has had a look, and noted the ABI breakage (see below). This was deliberate on my part - the only way to get newmail notification to take note of the results of a filter thread. Many thanks Karl On Fri,

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-04-25 Thread Jeffrey Stedfast
I'm not sure I'd call it get_filter_thread() because it's not getting a thread, all it is really doing is getting you a 'wait' id (and ugh, the new session_thread_wait() just busy-waits?) I think if this type of solution is really the best way of doing it, then I think it'd be better to just have

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-04-09 Thread Karl Relton
Matthew As a new Mail maintainer, could you take a look at my proposed patches for fixing bug 311512. Srini has had a look, and noted the ABI breakage (see below). This was deliberate on my part - the only way to get newmail notification to take note of the results of a filter thread. Many

Re: [Evolution-hackers] Proposed fix for bug 311512

2007-03-30 Thread Srinivasa Ragavan
On Fri, 2007-03-30 at 07:51 +0100, Karl Relton wrote: Srini Welcome to your new role (again!). Last week I posted two patches (one for eds, one for evo) on evo bugzill that I believe fix bug 311512. --- camel-folder.h.1102007-03-20 16:57:40.0 + +++ camel-folder.h

[Evolution-hackers] Proposed fix for bug 311512

2007-03-29 Thread Karl Relton
Srini Welcome to your new role (again!). Last week I posted two patches (one for eds, one for evo) on evo bugzill that I believe fix bug 311512. Could you take a look - any comments are welcome! Regards Karl ___ Evolution-hackers mailing list