Re: [Evolution-hackers] libebook master: obsolete vCard used despite updated properties

2012-03-04 Thread Milan Crha
On Sun, 2012-03-04 at 15:35 +0100, Patrick Ohly wrote: > Please include this patch. Hi, thanks for the catch, I committed your patch as 58199a4 in eds. Either 3.3.91 or 3.3.92 will have it included. > > Question: why does the removed comment only mention UID? Isn't any > > contact modific

Re: [Evolution-hackers] libebook master: obsolete vCard used despite updated properties

2012-03-04 Thread Patrick Ohly
On Sat, 2012-03-03 at 13:26 +0100, Patrick Ohly wrote: > It removes the check for evc->priv->attributes. Adding that check back > fixes the problem. Attached is the patch. I must admit that I'm not up-to-date about release plans. From Matthew's email I gathered that there will be a release on Mond

[Evolution-hackers] libebook master: obsolete vCard used despite updated properties

2012-03-03 Thread Patrick Ohly
Hello! I tested SyncEvolution against current EDS master and found a problem: setting a UID before committing an updated contact has no effect. The sequence of events is this: 1. e_contact_new_from_vcard() where the vCard contains no UID. 2. e_contact_set(E_CONTACT_UID, ) -> g_object_se