Hi All,
Probably I have managed to cook a fix for bug 697632. Code review is
required to confirm the fix.
I am not sure how to create patch. I took a diff and attaching here.
File:
pluginshttp://bazaar.launchpad.net/%7Esamarjit-adhikari/evolution/evolution-3.6.2/files/353/plugins
On Mon, 2013-04-15 at 12:20 +0530, samarjit Adhikari wrote:
Probably I have managed to cook a fix for bug 697632. Code review is
required to confirm the fix.
I am not sure how to create patch. I took a diff and attaching here.
Hi,
thanks for the work on this. If it's related to a
Thanks Milan for the review.
Good catch, the e_mail_reader_get_folder() doesn't return reffed
folder, but the mail-to-task still unrefs the folder. I guess it's
some artifact from the time when the function was introduced. I see
few more places in the mail-to-task.c which does the unref, please
On Mon, 2013-04-15 at 14:14 +0530, samarjit Adhikari wrote:
That's the confusion I have. So will the good fix be a g_object_ref
inside e_mail_reader_get_folder on folder object? or is it ok to
delete the unref. In that case I need to delete all unref
consistently in mail-to-task.
I'm fine
Thanks for holding my hands and helping me to move forward.
With regards,
Samarjit
On Mon, Apr 15, 2013 at 2:24 PM, Milan Crha mc...@redhat.com wrote:
On Mon, 2013-04-15 at 14:14 +0530, samarjit Adhikari wrote:
That's the confusion I have. So will the good fix be a g_object_ref
inside
