Re: [Evolution-hackers] Closing a NSS connection

2007-12-15 Thread Matthew Barnes
On Sat, 2007-12-15 at 10:02 -0500, Matthew Barnes wrote: On Sat, 2007-12-15 at 13:53 +0100, Philip Van Hoof wrote: I don't think just doing a PR_Close is sufficient. I think you need to do a PR_Shutdown too. GMail's IMAP server, for example, after pressing really often connect-disconnect,

Re: [Evolution-hackers] Closing a NSS connection

2007-12-15 Thread Srinivasa Ragavan
On Sat, 2007-12-15 at 10:02 -0500, Matthew Barnes wrote: On Sat, 2007-12-15 at 13:53 +0100, Philip Van Hoof wrote: I don't think just doing a PR_Close is sufficient. I think you need to do a PR_Shutdown too. GMail's IMAP server, for example, after pressing really often connect-disconnect,

Re: [Evolution-hackers] Closing a NSS connection

2007-12-15 Thread Matthew Barnes
Philip, I see PR_Close() being used on its own in two other places in that file, particularly stream_close() but also during error cleanup in socket_connect(). Do either of these locations also need to call PR_Shutdown()? Yes, I fixed the other locations in Camel-lite too. Sorry for

Re: [Evolution-hackers] Closing a NSS connection

2007-12-15 Thread Philip Van Hoof
On Sat, 2007-12-15 at 11:36 -0500, Matthew Barnes wrote: Looks like there's a couple more PR_Close() calls in e_msgport_destroy() (libedataserver/e-msgport.c). I'm assuming these need shutdown too? No, as far as I know those are named pipes. Not socket filedescriptors. But feel free to