Re: [Evolution-hackers] Reviewing imap_update_summary

2006-10-23 Thread Sankar P
On Sun, 2006-10-22 at 15:41 +0200, Philip Van Hoof wrote: Greetings, imap_update_summary is implemented in three or four steps: o. Getting (all) the headers/uids o. Finding the ones that we must still fetch o. Fetching those (x) o. Writing out the summary The steps each

Re: [Evolution-hackers] Reviewing imap_update_summary

2006-10-23 Thread Philip Van Hoof
On Tue, 2006-10-24 at 01:56 +0200, Philip Van Hoof wrote: static guint32 imap_get_uids ( { ... while ((type = camel_imap_command_response (store, resp, ex)) == CAMEL_IMAP_RESPONSE_UNTAGGED) { ... if (size 0)

Re: [Evolution-hackers] Reviewing imap_update_summary

2006-10-22 Thread Philip Van Hoof
On Sun, 2006-10-22 at 15:41 +0200, Philip Van Hoof wrote: In the code I have found no real reason to why this was done in separated loops (steps) rather than one step and at the end of the loop, free the data already. Especially for the third step (x), which seem to consume most memory while