Re: [Evolution-hackers] default bug handling policy
On Mon, 2008-05-05 at 17:09 -0400, Matthew Barnes wrote: Distro maintainers can always cherry-pick from trunk if they want, though I personally have stopped doing that. I would expect the upstream developers to do that instead of multiplying the work by expecting all downstream packagers to do it independently. But of course it is not my time I am talking about here ;-} It's kind of an engineering judgment call whether to backport. If the patch doesn't break any freezes in effect for the stable version and is considered not-too-risky or fixes a severe problem, then it will likely be applied to the stable branch. Makes sense. It would help to comment in the bug report itself whether back porting was considered. If back porting was considered and the reasons against it are documented, then expect that no further time will be wasted on reopening the issue. If a bug gets resolved as FIXED without the patch being backported and you think it should have been, feel free to re-open the bug and ask. Sometimes it's just an oversight. I cannot re-open bugs. Taking the bug 523541 as example, it is set to RESOLVED/FIXED although Chentill asked to have the patch applied to gnome-2-22. I'm a bit afraid that this will be forgotten. -- Bye, Patrick Ohly -- [EMAIL PROTECTED] http://www.estamos.de/ ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] default bug handling policy
On Tue, 2008-05-06 at 21:43 +0200, Patrick Ohly wrote: I cannot re-open bugs. Taking the bug 523541 as example, it is set to RESOLVED/FIXED although Chentill asked to have the patch applied to gnome-2-22. I'm a bit afraid that this will be forgotten. I reopened the bug and asked Chentill to commit it himself since Milan won't be back for a few weeks. Matthew Barnes ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] default bug handling policy
Hello Patrick, On Mon, 2008-05-05 at 20:25 +0200, Patrick Ohly wrote: Hello, are bugs discovered on the trunk also fixed on the latest maintenance branch by default or only if someone asks for it? Different projects handle this differently. We backport to stable branch, if they don't break any freezes like UI/String/API/ABI. If we find the fixes a bit risky, we dont put them to stable, or atleast wait for a dot release on the unstable trunk. I personally prefer to apply fixes to the maintenance branch, then port them forward to the trunk automatically. In my experience that reduces the risk of forgetting fixes. But there are valid arguments for both positions; I just want to know where Evolution stands, not start a discussion. Most of the hackers work on the trunk and back port the fixes to stable branch. But user/other-hackers who use stable release make patches on stable release and while committing we forward port to trunk also. I (incorrectly?) assumed that for Evolution patches would be manually applied to all affected and maintained branches, but at least in one case that I just ran into ([1], [2]) this wasn't done. Because I didn't check the code on the trunk I needlessly ended up fixing the memory leak on the 2.22.x branch again. [1] http://bugzilla.gnome.org/show_bug.cgi?id=531197 [2] http://bugzilla.gnome.org/show_bug.cgi?id=523541 May be it is missed or kept pending, other wise I dont see any reason why not to. -Srini. ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
[Evolution-hackers] default bug handling policy
Hello, are bugs discovered on the trunk also fixed on the latest maintenance branch by default or only if someone asks for it? Different projects handle this differently. I personally prefer to apply fixes to the maintenance branch, then port them forward to the trunk automatically. In my experience that reduces the risk of forgetting fixes. But there are valid arguments for both positions; I just want to know where Evolution stands, not start a discussion. I (incorrectly?) assumed that for Evolution patches would be manually applied to all affected and maintained branches, but at least in one case that I just ran into ([1], [2]) this wasn't done. Because I didn't check the code on the trunk I needlessly ended up fixing the memory leak on the 2.22.x branch again. [1] http://bugzilla.gnome.org/show_bug.cgi?id=531197 [2] http://bugzilla.gnome.org/show_bug.cgi?id=523541 -- Bye, Patrick Ohly -- [EMAIL PROTECTED] http://www.estamos.de/ ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
Re: [Evolution-hackers] default bug handling policy
On Mon, 2008-05-05 at 20:25 +0200, Patrick Ohly wrote: are bugs discovered on the trunk also fixed on the latest maintenance branch by default or only if someone asks for it? Different projects handle this differently. The source code in trunk is considered the master copy, so bugs are always fixed there first and then backported to the latest stable branch (currently gnome-2-22) if deemed appropriate. Distro maintainers can always cherry-pick from trunk if they want, though I personally have stopped doing that. It's kind of an engineering judgment call whether to backport. If the patch doesn't break any freezes in effect for the stable version and is considered not-too-risky or fixes a severe problem, then it will likely be applied to the stable branch. If a bug gets resolved as FIXED without the patch being backported and you think it should have been, feel free to re-open the bug and ask. Sometimes it's just an oversight. Matthew Barnes ___ Evolution-hackers mailing list Evolution-hackers@gnome.org http://mail.gnome.org/mailman/listinfo/evolution-hackers
