Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-25 Thread Jeffrey Stedfast
On Tue, 2007-12-25 at 15:56 +0800, jacky wrote: > But the problem describe below has not been solved. > > 1) An encoded-word was divided into two line. This > was > > sent by dotProject v2.0.1 . > > As I seen this kind of email use quoted encode only, > and header_decode_text() can get all encode

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-25 Thread jacky
--- jacky <[EMAIL PROTECTED]>worte: > > --- Peter Volkov <[EMAIL PROTECTED]>wrote: > > > > > В Пнд, 24/12/2007 в 13:21 +0800, jacky > > пишет: > > > --- Jeff Stedfast <[EMAIL PROTECTED]>wrote: > > > There are two kind of email need to support: > > > 1) An encoded-word was divided into two line

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-24 Thread jacky
--- Peter Volkov <[EMAIL PROTECTED]>wrote: > > В Пнд, 24/12/2007 в 13:21 +0800, jacky > пишет: > > --- Jeff Stedfast <[EMAIL PROTECTED]>wrote: > > There are two kind of email need to support: > > 1) An encoded-word was divided into two line. This > was > > sent by dotProject v2.0.1 . > > And th

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-24 Thread Philip Van Hoof
On Mon, 2007-12-24 at 13:21 +0800, jacky wrote: > Yes, I use a fixed length string to store some value, it maybe > overflow. I write another version by using heap insteads of > stack. I think the stack version is simple and enough, so I > send it only. Two version of rfc2047_decode_word() is i

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-23 Thread Peter Volkov
В Пнд, 24/12/2007 в 13:21 +0800, jacky пишет: > --- Jeff Stedfast <[EMAIL PROTECTED]>wrote: > There are two kind of email need to support: > 1) An encoded-word was divided into two line. This was > sent by dotProject v2.0.1 . And there are even more users affected by this. I've already reported s

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-23 Thread jacky
--- Jeff Stedfast <[EMAIL PROTECTED]>wrote: > Hi Jacky, > > I've looked over your patch, but unfortunately it is > unusable. The patch > is riddled with buffer overflows and incorrect > logic. > Yes, I use a fixed length string to store some value, it maybe overflow. I write another version by

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-23 Thread Philip Van Hoof
On Sun, 2007-12-23 at 14:51 -0700, Jeff Stedfast wrote: > What types of bugs are you actually trying to fix? What is it about CJK > messages in particular that are not getting decoded properly? Your email > was overly vague. Looks like he wants to support both 'B' and 'b' and 'Q' and 'q' in stea

Re: [Evolution-hackers] [patch] fixed incorrect rfc2047 decode for CJKheader

2007-12-23 Thread Jeff Stedfast
Hi Jacky, I've looked over your patch, but unfortunately it is unusable. The patch is riddled with buffer overflows and incorrect logic. What types of bugs are you actually trying to fix? What is it about CJK messages in particular that are not getting decoded properly? Your email was overly vagu