Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-06-02 Thread Patrick Ohly
On Fr, 2011-05-27 at 11:59 -0400, Matthew Barnes wrote: On Fri, 2011-05-27 at 16:49 +0200, Milan Crha wrote: Maybe it can pump them, but it doesn't deliver them, as far as my tests showed, because they are usually delivered on idle, which never happen with blocked main loop. That's the

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-31 Thread Alexander Larsson
On Tue, 2011-05-31 at 05:50 +0200, Milan Crha wrote: On Mon, 2011-05-30 at 15:33 +0200, Alexander Larsson wrote: Btw, I was thinking about this. Is this kind of solution really needed? I mean, its easy to bump the timeout for the async ops, and i think the current maximum dbus timeout is

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-30 Thread Alexander Larsson
On Fri, 2011-05-27 at 16:49 +0200, Milan Crha wrote: Main reason for this change was a fact that some operations may timeout on a DBus call, because backend wasn't able to finish the requested operation in a given time (defined by DBus; later with some workaround on eds side). It could

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-30 Thread Milan Crha
On Mon, 2011-05-30 at 15:33 +0200, Alexander Larsson wrote: Btw, I was thinking about this. Is this kind of solution really needed? I mean, its easy to bump the timeout for the async ops, and i think the current maximum dbus timeout is six hours. Are there actual correct evolution operations

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-27 Thread Milan Crha
On Fri, 2011-05-27 at 13:01 +0200, Alexander Larsson wrote: I needed the most recent eds to test the folks eds backend, and I picked up the new dbus EBook APIs. Unfortunatelly that seemed to be completely broken for me (evolution contacts hanged, test-self in the tests hanged), so I have

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-27 Thread Milan Crha
On Fri, 2011-05-27 at 13:01 +0200, Alexander Larsson wrote: Secondly, why is it using a dbus signal for the done callbacks? Wouldn't it be more sane to use a direct message (without expecting a reply)? A signal will be sent to everyone subscribing to that signal, which will be all clients

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-27 Thread Matthew Barnes
On Fri, 2011-05-27 at 16:49 +0200, Milan Crha wrote: Maybe it can pump them, but it doesn't deliver them, as far as my tests showed, because they are usually delivered on idle, which never happen with blocked main loop. That's the reason why I added there this loop. Only notice that this loop

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-27 Thread Milan Crha
On Fri, 2011-05-27 at 11:59 -0400, Matthew Barnes wrote: On Fri, 2011-05-27 at 16:49 +0200, Milan Crha wrote: Maybe it can pump them, but it doesn't deliver them, as far as my tests showed, because they are usually delivered on idle, which never happen with blocked main loop. That's the

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-27 Thread Alexander Larsson
On Fri, 2011-05-27 at 16:49 +0200, Milan Crha wrote: On Fri, 2011-05-27 at 13:01 +0200, Alexander Larsson wrote: I needed the most recent eds to test the folks eds backend, and I picked up the new dbus EBook APIs. Unfortunatelly that seemed to be completely broken for me (evolution contacts

Re: [Evolution-hackers] Issues with new EBook dbus implementation

2011-05-27 Thread Alexander Larsson
On Fri, 2011-05-27 at 17:09 +0200, Milan Crha wrote: On Fri, 2011-05-27 at 13:01 +0200, Alexander Larsson wrote: Secondly, why is it using a dbus signal for the done callbacks? Wouldn't it be more sane to use a direct message (without expecting a reply)? A signal will be sent to everyone