Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-07-04 Thread Gilles Dartiguelongue
Le jeudi 31 mai 2007 à 11:01 -0400, Daniel Gryniewicz a écrit :
 On Thu, 2007-05-31 at 15:00 +0530, Srinivasa Ragavan wrote:
  On Thu, 2007-05-31 at 11:19 +0200, Gilles Dartiguelongue wrote:
   Le jeudi 31 mai 2007 à 08:59 +, Srinivasa Ragavan a écrit :
On Thu, 2007-05-31 at 10:36 +0200, Gilles Dartiguelongue wrote:
 I've seen that too, but the point was more: Why are the message view
 headers looking different than every other ETable I can see in
 evolution ?. I've looked at different themes and it was always
 different. I'm not an expert in GtkWidget hacking but can't we 
 inherit
 some properties from regular list headers ?

Different in what sense? I see that message-list is not consistent with
GtkTreeview but so as is the other memo/task list. Im sorry, I'm not
getting it.
   
   See attachements: 
- in mail view, even if it's not perfect it looks like a GtkTreeView
   header
- in memo view, the header looks like a button
   
   This is even more flagrant with the Glossy theme.
  
  Frankly, for me with Industrial, it looks the same in both places.
 
 For me, it looks like Gilles.  I have a clearlooks-based theme.  I'd
 guess it's engine related?
 
 Daniel
 
indeed, for reference (and non pgo readers):
http://abock.org/2007/07/02/suboptimal-theming-in-gtk/
http://blogs.gnome.org/thos/2007/07/04/re-suboptimal-theming-in-gtk/

long story short, ETree needs special handling of the gtk-engine to be
drawn in a way that makes it look like a GtkTreeView and even then, it
is very possible it won't be perfect.
-- 
Gilles Dartiguelongue [EMAIL PROTECTED]


signature.asc
Description: Ceci est une partie de message	numériquement signée
___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Frederic Crozat
Le jeudi 31 mai 2007 à 07:19 +, Srinivasa Ragavan a écrit :

  Last point is, why is the mail view headers fixed (like not look like
  buttons) in 2.10 and not the other views as well (memos, calendars,
  contacts)
 
 In few themes, Ive seen that it looks like a table header, but not in
 all themes. If you have seen this 2.10, may be with a right theme. Im
 sure that this should be fixable in widgets/table. I don't think it
 would right to fix all the other themes for this.

Well, speaking with my theme writer hat on, I'm forced to do some
matching on ETable class name and so on to get a consistent rendering,
compared to TreeView. 

-- 
Frederic Crozat [EMAIL PROTECTED]
Mandriva

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Gilles Dartiguelongue
Le jeudi 31 mai 2007 à 07:19 +, Srinivasa Ragavan a écrit :
 On Thu, 2007-05-31 at 00:17 +0200, Gilles Dartiguelongue wrote: 
  First thing that hit me was that it didn't use GtkTreeView and that it
  doesn't understand _ markup. 
 
 I think that can be moved to GtkTreeView and shouldn't have a issue.
 Patches are welcome :).
I'll fill a bug and work on a patch.

 It is not that, it doesn't understand markup. The '_' is there to
 provide key accelerator in visible UI items, and it isn't stripped of at
 those places. I don't think that '_' makes any sense in the table/row.
Yep, that's what I meant

  I know evolution has its own ETable widget
  and that it does thing that evolution needs and gtk+ doesn't provide but
  why use this widget here ?
 
 It is that, we have moved to GtkTreeView to in lots of places and we
 have list of places where we want to move and don't want to move.
 Message list is a place where we don't want to move.
The why was refering to the Customize View dialog, not the message view. But 
see next point.

  
  The second thing is the Edit button. It is not the same as everywhere
  I looked in the preferences window, this is bad.
 
 This can be fixed. 
Will fill a bug an provide a patch unless somebody is quicker than me :)
  
  Last point is, why is the mail view headers fixed (like not look like
  buttons) in 2.10 and not the other views as well (memos, calendars,
  contacts)
 
 In few themes, Ive seen that it looks like a table header, but not in
 all themes. If you have seen this 2.10, may be with a right theme. Im
 sure that this should be fixable in widgets/table. I don't think it
 would right to fix all the other themes for this.

I've seen that too, but the point was more: Why are the message view
headers looking different than every other ETable I can see in
evolution ?. I've looked at different themes and it was always
different. I'm not an expert in GtkWidget hacking but can't we inherit
some properties from regular list headers ?
-- 
Gilles Dartiguelongue [EMAIL PROTECTED]

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Srinivasa Ragavan
On Thu, 2007-05-31 at 10:24 +0200, Frederic Crozat wrote:
 Le jeudi 31 mai 2007 à 07:19 +, Srinivasa Ragavan a écrit :
 
   Last point is, why is the mail view headers fixed (like not look like
   buttons) in 2.10 and not the other views as well (memos, calendars,
   contacts)
  
  In few themes, Ive seen that it looks like a table header, but not in
  all themes. If you have seen this 2.10, may be with a right theme. Im
  sure that this should be fixable in widgets/table. I don't think it
  would right to fix all the other themes for this.
 
 Well, speaking with my theme writer hat on, I'm forced to do some
 matching on ETable class name and so on to get a consistent rendering,
 compared to TreeView. 

Right. IIRC the New button too had some similar issues, but that was
resolved in 2.8.x.

-Srini
 

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Frederic Crozat
Le jeudi 31 mai 2007 à 08:38 +, Srinivasa Ragavan a écrit :
 On Thu, 2007-05-31 at 10:24 +0200, Frederic Crozat wrote:
  Le jeudi 31 mai 2007 à 07:19 +, Srinivasa Ragavan a écrit :
  
Last point is, why is the mail view headers fixed (like not look like
buttons) in 2.10 and not the other views as well (memos, calendars,
contacts)
   
   In few themes, Ive seen that it looks like a table header, but not in
   all themes. If you have seen this 2.10, may be with a right theme. Im
   sure that this should be fixable in widgets/table. I don't think it
   would right to fix all the other themes for this.
  
  Well, speaking with my theme writer hat on, I'm forced to do some
  matching on ETable class name and so on to get a consistent rendering,
  compared to TreeView. 
 
 Right. IIRC the New button too had some similar issues, but that was
 resolved in 2.8.x.

Not entirely : EComboButton still need to be treated differently for
themes with rounded edges for buttons (like Ia Ora or Galaxy) otherwise
the separations between both part of the button looks strange..

-- 
Frederic Crozat [EMAIL PROTECTED]
Mandriva

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Srinivasa Ragavan
On Thu, 2007-05-31 at 10:36 +0200, Gilles Dartiguelongue wrote:
 Le jeudi 31 mai 2007 à 07:19 +, Srinivasa Ragavan a écrit :
  On Thu, 2007-05-31 at 00:17 +0200, Gilles Dartiguelongue wrote: 
   First thing that hit me was that it didn't use GtkTreeView and that it
   doesn't understand _ markup. 
  
  I think that can be moved to GtkTreeView and shouldn't have a issue.
  Patches are welcome :).
 I'll fill a bug and work on a patch.

Cool :-)

 
  It is not that, it doesn't understand markup. The '_' is there to
  provide key accelerator in visible UI items, and it isn't stripped of at
  those places. I don't think that '_' makes any sense in the table/row.
 Yep, that's what I meant
 
   I know evolution has its own ETable widget
   and that it does thing that evolution needs and gtk+ doesn't provide but
   why use this widget here ?
  
  It is that, we have moved to GtkTreeView to in lots of places and we
  have list of places where we want to move and don't want to move.
  Message list is a place where we don't want to move.
 The why was refering to the Customize View dialog, not the message view. 
 But see next point.
 
   
   The second thing is the Edit button. It is not the same as everywhere
   I looked in the preferences window, this is bad.
  
  This can be fixed. 
 Will fill a bug an provide a patch unless somebody is quicker than me :)
   
   Last point is, why is the mail view headers fixed (like not look like
   buttons) in 2.10 and not the other views as well (memos, calendars,
   contacts)
  
  In few themes, Ive seen that it looks like a table header, but not in
  all themes. If you have seen this 2.10, may be with a right theme. Im
  sure that this should be fixable in widgets/table. I don't think it
  would right to fix all the other themes for this.
 
 I've seen that too, but the point was more: Why are the message view
 headers looking different than every other ETable I can see in
 evolution ?. I've looked at different themes and it was always
 different. I'm not an expert in GtkWidget hacking but can't we inherit
 some properties from regular list headers ?

Different in what sense? I see that message-list is not consistent with
GtkTreeview but so as is the other memo/task list. Im sorry, I'm not
getting it.

-Srini

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Srinivasa Ragavan
On Thu, 2007-05-31 at 11:19 +0200, Gilles Dartiguelongue wrote:
 Le jeudi 31 mai 2007 à 08:59 +, Srinivasa Ragavan a écrit :
  On Thu, 2007-05-31 at 10:36 +0200, Gilles Dartiguelongue wrote:
   I've seen that too, but the point was more: Why are the message view
   headers looking different than every other ETable I can see in
   evolution ?. I've looked at different themes and it was always
   different. I'm not an expert in GtkWidget hacking but can't we inherit
   some properties from regular list headers ?
  
  Different in what sense? I see that message-list is not consistent with
  GtkTreeview but so as is the other memo/task list. Im sorry, I'm not
  getting it.
 
 See attachements: 
  - in mail view, even if it's not perfect it looks like a GtkTreeView
 header
  - in memo view, the header looks like a button
 
 This is even more flagrant with the Glossy theme.

Frankly, for me with Industrial, it looks the same in both places.

-Srini.
 ___
 Evolution-hackers mailing list
 Evolution-hackers@gnome.org
 http://mail.gnome.org/mailman/listinfo/evolution-hackers

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers


Re: [Evolution-hackers] evolution's UI, consistency and codebase

2007-05-31 Thread Daniel Gryniewicz
On Thu, 2007-05-31 at 15:00 +0530, Srinivasa Ragavan wrote:
 On Thu, 2007-05-31 at 11:19 +0200, Gilles Dartiguelongue wrote:
  Le jeudi 31 mai 2007 à 08:59 +, Srinivasa Ragavan a écrit :
   On Thu, 2007-05-31 at 10:36 +0200, Gilles Dartiguelongue wrote:
I've seen that too, but the point was more: Why are the message view
headers looking different than every other ETable I can see in
evolution ?. I've looked at different themes and it was always
different. I'm not an expert in GtkWidget hacking but can't we inherit
some properties from regular list headers ?
   
   Different in what sense? I see that message-list is not consistent with
   GtkTreeview but so as is the other memo/task list. Im sorry, I'm not
   getting it.
  
  See attachements: 
   - in mail view, even if it's not perfect it looks like a GtkTreeView
  header
   - in memo view, the header looks like a button
  
  This is even more flagrant with the Glossy theme.
 
 Frankly, for me with Industrial, it looks the same in both places.

For me, it looks like Gilles.  I have a clearlooks-based theme.  I'd
guess it's engine related?

Daniel

___
Evolution-hackers mailing list
Evolution-hackers@gnome.org
http://mail.gnome.org/mailman/listinfo/evolution-hackers