Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-15 Thread Tristan Van Berkom
On Thu, 2011-07-14 at 17:19 -0400, Tristan Van Berkom wrote: On Fri, 2011-07-08 at 13:02 +0200, Patrick Ohly wrote: On Thu, 2011-07-07 at 20:39 -0400, Tristan Van Berkom wrote: I now have a much simpler patch up on the openismus-work branch[0]. (it's also in patch form on the bug[1]).

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-14 Thread Tristan Van Berkom
On Fri, 2011-07-08 at 13:02 +0200, Patrick Ohly wrote: On Thu, 2011-07-07 at 20:39 -0400, Tristan Van Berkom wrote: I now have a much simpler patch up on the openismus-work branch[0]. (it's also in patch form on the bug[1]). That looks a lot saner than the previous solution. Removing all

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-14 Thread Tristan Van Berkom
On Thu, 2011-07-14 at 17:19 -0400, Tristan Van Berkom wrote: On Fri, 2011-07-08 at 13:02 +0200, Patrick Ohly wrote: On Thu, 2011-07-07 at 20:39 -0400, Tristan Van Berkom wrote: I now have a much simpler patch up on the openismus-work branch[0]. (it's also in patch form on the bug[1]).

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-09 Thread Patrick Ohly
On Fri, 2011-07-08 at 14:45 -0400, Tristan Van Berkom wrote: However the EContact passed to e_book_commit_contact() will not be modified by the call to the backend (the gdbus call simply queues a job in the addressbook thread and returns)... so for the caller to get the real uri one must

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-08 Thread Burton, Ross
On 7 July 2011 09:48, Patrick Ohly patrick.o...@gmx.de wrote: At any rate, if it's judged that the performance gain of using a staging directory is worth the added complexity then let's do it. I'd like to hear some other opinions about this. Ross? It does sound like a lot of extra complexity

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-08 Thread Patrick Ohly
On Fri, 2011-07-08 at 10:42 +0100, Burton, Ross wrote: On 7 July 2011 09:48, Patrick Ohly patrick.o...@gmx.de wrote: At any rate, if it's judged that the performance gain of using a staging directory is worth the added complexity then let's do it. I'd like to hear some other opinions

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-08 Thread Patrick Ohly
On Thu, 2011-07-07 at 20:54 -0400, Tristan Van Berkom wrote: It's possible but will need to be conditional, probably depending on whether there is a staging directory available or not. I'll start thinking about how this staging directory could be implemented, I suppose the client needs to

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-08 Thread Patrick Ohly
On Thu, 2011-07-07 at 20:39 -0400, Tristan Van Berkom wrote: I now have a much simpler patch up on the openismus-work branch[0]. (it's also in patch form on the bug[1]). That looks a lot saner than the previous solution. Removing all the attempts to keep clients perfectly informed about file

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-08 Thread Tristan Van Berkom
On Fri, 2011-07-08 at 12:49 +0200, Patrick Ohly wrote: On Thu, 2011-07-07 at 20:54 -0400, Tristan Van Berkom wrote: It's possible but will need to be conditional, probably depending on whether there is a staging directory available or not. I'll start thinking about how this staging

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-07 Thread Patrick Ohly
On Wed, 2011-07-06 at 16:16 -0400, Tristan Van Berkom wrote: [staging directory for out-of-band photo data transmission] This alternative proposal is strictly regarding the photo data for which the server must take ownership of I assume, correct ? Yes. I might not have been clear enough in my

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-07 Thread Chenthill
On Thu, 2011-07-07 at 10:48 +0200, Patrick Ohly wrote: On Wed, 2011-07-06 at 16:16 -0400, Tristan Van Berkom wrote: [staging directory for out-of-band photo data transmission] This alternative proposal is strictly regarding the photo data for which the server must take ownership of I assume,

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-07 Thread Patrick Ohly
On Thu, 2011-07-07 at 15:09 +0530, Chenthill wrote: I like the staging directory approach. Would it be possible for implementing the logic to convert the inline data -file inside e_book_client_add_contact so that the clients need to worry about changing the code ? need *not* worry, right?

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-07 Thread Tristan Van Berkom
On Thu, 2011-07-07 at 10:48 +0200, Patrick Ohly wrote: On Wed, 2011-07-06 at 16:16 -0400, Tristan Van Berkom wrote: [staging directory for out-of-band photo data transmission] This alternative proposal is strictly regarding the photo data for which the server must take ownership of I assume,

Re: [Evolution-hackers] improve PHOTO support in libebook/EDS

2011-07-06 Thread Tristan Van Berkom
On Wed, 2011-07-06 at 18:15 +0200, Patrick Ohly wrote: Hello! It was pointed out before that support for PHOTO data in EDS is sub-optimal because the data has to be encoded as B64 data in the vCard and then gets transmitted like that via D-BUs and stored in Berkley DB. Hi, Unfortunately