[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-07 Thread Hoang-Nam Nguyen
On Tuesday 07 August 2007 07:34, Michael S. Tsirkin wrote: Hmm, I thought about it some more. kmem_cache struct is not exported on recent kernels, so this might br hard to do. I looked at slab.h in various kernel and see this function extern unsigned int kmem_cache_size(kmem_cache_t *); which

[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-07 Thread Hoang-Nam Nguyen
Hello Michael! Below is the patch to backport kmem_cache_zalloc() for 2.6.16/sles10/sles10_sp1 as we've discussed previously. Thereby I realized current backport code in slab.h looks weird to me (sort of copypaste mixture) - actually no build error, only coding issue. Therefore this patch also

[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-07 Thread Michael S. Tsirkin
I'm happy with stuff as it is: the ifdefs make it easy to figure which version does the backport apply. BTW, I think the same backport will be needed for older kernels as well, no? Quoting Hoang-Nam Nguyen [EMAIL PROTECTED]: Subject: Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for

[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-07 Thread Michael S. Tsirkin
Quoting Hoang-Nam Nguyen [EMAIL PROTECTED]: Subject: Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1 On Tuesday 07 August 2007 15:23, Michael S. Tsirkin wrote: Quoting Hoang-Nam Nguyen [EMAIL PROTECTED]: Subject: Re: [PATCH ofed-1.2.c] ehca:

[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-07 Thread Michael S. Tsirkin
Quoting Hoang-Nam Nguyen [EMAIL PROTECTED]: Subject: Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1 On Tuesday 07 August 2007 15:23, Michael S. Tsirkin wrote: Quoting Hoang-Nam Nguyen [EMAIL PROTECTED]: Subject: Re: [PATCH ofed-1.2.c] ehca:

[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-06 Thread Michael S. Tsirkin
Let's not do it this way. I think the right thing is to implement kmem_cache_zalloc by means of kmem_cache_allocand memset in kernel_addons. Quoting Hoang-Nam Nguyen [EMAIL PROTECTED]: Subject: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1 Hello Michael

[ewg] Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc() for 2.6.10/sles10/sles10_sp1

2007-08-06 Thread Michael S. Tsirkin
Hmm, I thought about it some more. kmem_cache struct is not exported on recent kernels, so this might br hard to do. So I think the patch is probably the right approach, after all. Quoting Michael S. Tsirkin [EMAIL PROTECTED]: Subject: Re: [PATCH ofed-1.2.c] ehca: backport kmem_cache_zalloc()