[ewg] Re: [PATCH v4] libibmad: Handle MAD redirection

2009-07-14 Thread Joachim Fenkes
Hal Rosenstock hal.rosenst...@gmail.com wrote on 08.07.2009 18:48:29: This patch should make its way into OFED 1.5... so who should pull it? You? Vlad? Someone not on CC? Whoever, please apply for OFED 1.5 -- thanks! Sasha is the management maintainer. Userspace trees for OFED 1.5

[ewg] Re: [PATCH v4] libibmad: Handle MAD redirection

2009-07-08 Thread Joachim Fenkes
Hal Rosenstock hal.rosenst...@gmail.com wrote on 07.07.2009 17:23:18: +static int redirect_port(ib_portid_t *port, uint8_t *mad) +{ + port-lid = mad_get_field(mad, 64, IB_CPI_REDIRECT_LID_F); + if (!port-lid) { + IBWARN(GID-based redirection is not supported);

[ewg] Re: [PATCH v4] libibmad: Handle MAD redirection

2009-07-08 Thread Hal Rosenstock
On 7/8/09, Joachim Fenkes fen...@de.ibm.com wrote: Hal Rosenstock hal.rosenst...@gmail.com wrote on 07.07.2009 17:23:18: +static int redirect_port(ib_portid_t *port, uint8_t *mad) +{ + port-lid = mad_get_field(mad, 64, IB_CPI_REDIRECT_LID_F); + if (!port-lid) { +

[ewg] Re: [PATCH v4] libibmad: Handle MAD redirection

2009-07-08 Thread Joachim Fenkes
Hal Rosenstock hal.rosenst...@gmail.com wrote on 08.07.2009 15:24:53: I suppose this can be fixed down the road. Is that an ACK? ;) Indeed, a qualified ACK :-) Cool, thanks! This patch should make its way into OFED 1.5... so who should pull it? You? Vlad? Someone not on CC? Whoever,

[ewg] Re: [PATCH v4] libibmad: Handle MAD redirection

2009-07-08 Thread Hal Rosenstock
On 7/8/09, Joachim Fenkes fen...@de.ibm.com wrote: Hal Rosenstock hal.rosenst...@gmail.com wrote on 08.07.2009 15:24:53: I suppose this can be fixed down the road. Is that an ACK? ;) Indeed, a qualified ACK :-) Cool, thanks! This patch should make its way into OFED 1.5... so who

[ewg] Re: [PATCH v4] libibmad: Handle MAD redirection

2009-07-07 Thread Hal Rosenstock
On Tue, Jul 7, 2009 at 10:20 AM, Joachim Fenkesfen...@de.ibm.com wrote: Previously, libibmad reacted to GSI MAD responses with a redirect status by throwing an error. IBM eHCA adapters use redirection, so most infiniband_diags tools didn't work against eHCA. Fix: Modify mad_rpc() so that it