[ewg] RE: [PATCH 3/6] nes: add missing unlock in error path of nes_alloc_fmr()

2007-12-14 Thread Glenn Grundstrom
To avoid problems in the future you should fix up your procedure to preserve the Author: and Signed-off-by: lines when assimilating a patch. Got it. These 6 patches just bring the OFED tree in line with yours. Another question - How do you like to see multiple patches in a set where more

Re: [ewg] RE: [PATCH 3/6] nes: add missing unlock in error path of nes_alloc_fmr()

2007-12-14 Thread Roland Dreier
Another question - How do you like to see multiple patches in a set where more than one of those patches affects the same file? I've been creating them where the second patch relies on the first patch being successfully applied. Correct? Yes, if you have multiple patches that touch the

[ewg] ofed-1.3-rc1 problem

2007-12-14 Thread Steve Wise
linking with libibumad fails on ofed-1.3-rc1. I get a 'cannot find -libumad' from ld. I looked in /usr/lib64 and there wasn't a link from libibumad.so to libibumad.so.1.0.2. I added the link and the ld works now. This was on PPC64. I think this is some install problem with libibumad.

[ewg] [PATCH] OFED/kernel_addons - fix compiler warnings in 2.6.9_U5

2007-12-14 Thread Arthur Jones
hi vlad, here is a patch which fixes a couple compiler warnings for me on 2.6.9_U5... arthur commit 3440f69777a4d29590d437308f364f22ada84e9b Author: Arthur Jones [EMAIL PROTECTED] Date: Thu Dec 13 12:07:40 2007 -0800 OFED/kernel_addons - fix compiler warnings in 2.6.9_U5 build

Re: [ewg] [PATCH] OFED/kernel_addons - fix compiler warnings in 2.6.9_U5

2007-12-14 Thread Steve Wise
Hey Arthur, did you compile all the modules with this fix? Arthur Jones wrote: hi vlad, here is a patch which fixes a couple compiler warnings for me on 2.6.9_U5... arthur